mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
c7b1e5ba38
Both getDynamicPortRange() and sanitizePortRange() could produce and error, and the error message was currently discarded, silently falling back to using the default port range. This patch: - Moves the fallback message from getDynamicPortRange() to getDefaultPortRange(), which is where the actual fallback occurs. - Logs the fallback message and the error that causes the fallback. The message/error is currently printed at the INFO level, but could be raised to a WARN, depending on what kind of situations can cause the error. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
294 lines
7.5 KiB
Go
294 lines
7.5 KiB
Go
package portallocator
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"net"
|
|
"sync"
|
|
|
|
"github.com/sirupsen/logrus"
|
|
)
|
|
|
|
func sanitizePortRange(start int, end int) (newStart, newEnd int, err error) {
|
|
if start > defaultPortRangeEnd || end < defaultPortRangeStart || start > end {
|
|
return 0, 0, fmt.Errorf("Request out allowed range [%v, %v]",
|
|
defaultPortRangeStart, defaultPortRangeEnd)
|
|
}
|
|
err = nil
|
|
newStart, newEnd = start, end
|
|
if start < defaultPortRangeStart {
|
|
newStart = defaultPortRangeStart
|
|
}
|
|
if end > defaultPortRangeEnd {
|
|
newEnd = defaultPortRangeEnd
|
|
}
|
|
return
|
|
}
|
|
|
|
type ipMapping map[string]protoMap
|
|
|
|
var (
|
|
// ErrAllPortsAllocated is returned when no more ports are available
|
|
ErrAllPortsAllocated = errors.New("all ports are allocated")
|
|
// ErrUnknownProtocol is returned when an unknown protocol was specified
|
|
ErrUnknownProtocol = errors.New("unknown protocol")
|
|
defaultIP = net.ParseIP("0.0.0.0")
|
|
once sync.Once
|
|
instance *PortAllocator
|
|
)
|
|
|
|
// ErrPortAlreadyAllocated is the returned error information when a requested port is already being used
|
|
type ErrPortAlreadyAllocated struct {
|
|
ip string
|
|
port int
|
|
}
|
|
|
|
func newErrPortAlreadyAllocated(ip string, port int) ErrPortAlreadyAllocated {
|
|
return ErrPortAlreadyAllocated{
|
|
ip: ip,
|
|
port: port,
|
|
}
|
|
}
|
|
|
|
// IP returns the address to which the used port is associated
|
|
func (e ErrPortAlreadyAllocated) IP() string {
|
|
return e.ip
|
|
}
|
|
|
|
// Port returns the value of the already used port
|
|
func (e ErrPortAlreadyAllocated) Port() int {
|
|
return e.port
|
|
}
|
|
|
|
// IPPort returns the address and the port in the form ip:port
|
|
func (e ErrPortAlreadyAllocated) IPPort() string {
|
|
return fmt.Sprintf("%s:%d", e.ip, e.port)
|
|
}
|
|
|
|
// Error is the implementation of error.Error interface
|
|
func (e ErrPortAlreadyAllocated) Error() string {
|
|
return fmt.Sprintf("Bind for %s:%d failed: port is already allocated", e.ip, e.port)
|
|
}
|
|
|
|
type (
|
|
// PortAllocator manages the transport ports database
|
|
PortAllocator struct {
|
|
mutex sync.Mutex
|
|
ipMap ipMapping
|
|
Begin int
|
|
End int
|
|
}
|
|
portRange struct {
|
|
begin int
|
|
end int
|
|
last int
|
|
}
|
|
portMap struct {
|
|
p map[int]struct{}
|
|
defaultRange string
|
|
portRanges map[string]*portRange
|
|
}
|
|
protoMap map[string]*portMap
|
|
)
|
|
|
|
// Get returns the default instance of PortAllocator
|
|
func Get() *PortAllocator {
|
|
// Port Allocator is a singleton
|
|
// Note: Long term solution will be each PortAllocator will have access to
|
|
// the OS so that it can have up to date view of the OS port allocation.
|
|
// When this happens singleton behavior will be removed. Clients do not
|
|
// need to worry about this, they will not see a change in behavior.
|
|
once.Do(func() {
|
|
instance = newInstance()
|
|
})
|
|
return instance
|
|
}
|
|
|
|
func getDefaultPortRange() (int, int) {
|
|
start, end, err := getDynamicPortRange()
|
|
if err == nil {
|
|
start, end, err = sanitizePortRange(start, end)
|
|
}
|
|
if err != nil {
|
|
logrus.WithError(err).Infof("falling back to default port range %d-%d", defaultPortRangeStart, defaultPortRangeEnd)
|
|
start, end = defaultPortRangeStart, defaultPortRangeEnd
|
|
}
|
|
return start, end
|
|
}
|
|
|
|
func newInstance() *PortAllocator {
|
|
start, end := getDefaultPortRange()
|
|
return &PortAllocator{
|
|
ipMap: ipMapping{},
|
|
Begin: start,
|
|
End: end,
|
|
}
|
|
}
|
|
|
|
// RequestPort requests new port from global ports pool for specified ip and proto.
|
|
// If port is 0 it returns first free port. Otherwise it checks port availability
|
|
// in proto's pool and returns that port or error if port is already busy.
|
|
func (p *PortAllocator) RequestPort(ip net.IP, proto string, port int) (int, error) {
|
|
return p.RequestPortInRange(ip, proto, port, port)
|
|
}
|
|
|
|
// RequestPortInRange requests new port from global ports pool for specified ip and proto.
|
|
// If portStart and portEnd are 0 it returns the first free port in the default ephemeral range.
|
|
// If portStart != portEnd it returns the first free port in the requested range.
|
|
// Otherwise (portStart == portEnd) it checks port availability in the requested proto's port-pool
|
|
// and returns that port or error if port is already busy.
|
|
func (p *PortAllocator) RequestPortInRange(ip net.IP, proto string, portStart, portEnd int) (int, error) {
|
|
p.mutex.Lock()
|
|
defer p.mutex.Unlock()
|
|
|
|
if proto != "tcp" && proto != "udp" && proto != "sctp" {
|
|
return 0, ErrUnknownProtocol
|
|
}
|
|
|
|
if ip == nil {
|
|
ip = defaultIP
|
|
}
|
|
ipstr := ip.String()
|
|
protomap, ok := p.ipMap[ipstr]
|
|
if !ok {
|
|
protomap = protoMap{
|
|
"tcp": p.newPortMap(),
|
|
"udp": p.newPortMap(),
|
|
"sctp": p.newPortMap(),
|
|
}
|
|
|
|
p.ipMap[ipstr] = protomap
|
|
}
|
|
mapping := protomap[proto]
|
|
if portStart > 0 && portStart == portEnd {
|
|
if _, ok := mapping.p[portStart]; !ok {
|
|
mapping.p[portStart] = struct{}{}
|
|
return portStart, nil
|
|
}
|
|
return 0, newErrPortAlreadyAllocated(ipstr, portStart)
|
|
}
|
|
|
|
port, err := mapping.findPort(portStart, portEnd)
|
|
if err != nil {
|
|
return 0, err
|
|
}
|
|
return port, nil
|
|
}
|
|
|
|
// ReleasePort releases port from global ports pool for specified ip and proto.
|
|
func (p *PortAllocator) ReleasePort(ip net.IP, proto string, port int) error {
|
|
p.mutex.Lock()
|
|
defer p.mutex.Unlock()
|
|
|
|
if ip == nil {
|
|
ip = defaultIP
|
|
}
|
|
protomap, ok := p.ipMap[ip.String()]
|
|
if !ok {
|
|
return nil
|
|
}
|
|
delete(protomap[proto].p, port)
|
|
return nil
|
|
}
|
|
|
|
// SetPortRange sets dynamic port allocation range.
|
|
// if both portBegin and portEnd are 0, the port range reverts to default
|
|
// value. Otherwise they are sanitized against the default values to
|
|
// ensure their validity.
|
|
func (p *PortAllocator) SetPortRange(portBegin, portEnd int) error {
|
|
// if begin and end is zero, revert to default values
|
|
var begin, end int
|
|
var err error
|
|
if portBegin == 0 && portEnd == 0 {
|
|
begin, end = getDefaultPortRange()
|
|
} else if begin, end, err = sanitizePortRange(portBegin, portEnd); err != nil {
|
|
return err
|
|
}
|
|
logrus.Debugf("Setting up port allocator to range %v-%v, current %v-%v", begin, end, p.Begin, p.End)
|
|
p.mutex.Lock()
|
|
defer p.mutex.Unlock()
|
|
if p.Begin == begin && p.End == end {
|
|
return nil
|
|
}
|
|
p.ipMap = ipMapping{}
|
|
p.Begin, p.End = begin, end
|
|
return nil
|
|
}
|
|
|
|
func (p *PortAllocator) newPortMap() *portMap {
|
|
defaultKey := getRangeKey(p.Begin, p.End)
|
|
pm := &portMap{
|
|
p: map[int]struct{}{},
|
|
defaultRange: defaultKey,
|
|
portRanges: map[string]*portRange{
|
|
defaultKey: newPortRange(p.Begin, p.End),
|
|
},
|
|
}
|
|
return pm
|
|
}
|
|
|
|
// ReleaseAll releases all ports for all ips.
|
|
func (p *PortAllocator) ReleaseAll() error {
|
|
p.mutex.Lock()
|
|
p.ipMap = ipMapping{}
|
|
p.mutex.Unlock()
|
|
return nil
|
|
}
|
|
|
|
func getRangeKey(portStart, portEnd int) string {
|
|
return fmt.Sprintf("%d-%d", portStart, portEnd)
|
|
}
|
|
|
|
func newPortRange(portStart, portEnd int) *portRange {
|
|
return &portRange{
|
|
begin: portStart,
|
|
end: portEnd,
|
|
last: portEnd,
|
|
}
|
|
}
|
|
|
|
func (pm *portMap) getPortRange(portStart, portEnd int) (*portRange, error) {
|
|
var key string
|
|
if portStart == 0 && portEnd == 0 {
|
|
key = pm.defaultRange
|
|
} else {
|
|
key = getRangeKey(portStart, portEnd)
|
|
if portStart == portEnd ||
|
|
portStart == 0 || portEnd == 0 ||
|
|
portEnd < portStart {
|
|
return nil, fmt.Errorf("invalid port range: %s", key)
|
|
}
|
|
}
|
|
|
|
// Return existing port range, if already known.
|
|
if pr, exists := pm.portRanges[key]; exists {
|
|
return pr, nil
|
|
}
|
|
|
|
// Otherwise create a new port range.
|
|
pr := newPortRange(portStart, portEnd)
|
|
pm.portRanges[key] = pr
|
|
return pr, nil
|
|
}
|
|
|
|
func (pm *portMap) findPort(portStart, portEnd int) (int, error) {
|
|
pr, err := pm.getPortRange(portStart, portEnd)
|
|
if err != nil {
|
|
return 0, err
|
|
}
|
|
port := pr.last
|
|
|
|
for i := 0; i <= pr.end-pr.begin; i++ {
|
|
port++
|
|
if port > pr.end {
|
|
port = pr.begin
|
|
}
|
|
|
|
if _, ok := pm.p[port]; !ok {
|
|
pm.p[port] = struct{}{}
|
|
pr.last = port
|
|
return port, nil
|
|
}
|
|
}
|
|
return 0, ErrAllPortsAllocated
|
|
}
|