mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
386e0f36c4
Begin to copy the data until the command to exit and any coping to stdin or copy from stdout/stderr has completed. Also adding defense code to trim the possible '\x00' null value. Signed-off-by: Dennis Chen <dennis.chen@arm.com>
97 lines
2.7 KiB
Go
97 lines
2.7 KiB
Go
// +build !windows,!test_no_exec
|
|
|
|
package main
|
|
|
|
import (
|
|
"bytes"
|
|
"io"
|
|
"os/exec"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/docker/docker/integration-cli/checker"
|
|
"github.com/go-check/check"
|
|
"github.com/kr/pty"
|
|
)
|
|
|
|
// regression test for #12546
|
|
func (s *DockerSuite) TestExecInteractiveStdinClose(c *check.C) {
|
|
testRequires(c, DaemonIsLinux)
|
|
out, _ := dockerCmd(c, "run", "-itd", "busybox", "/bin/cat")
|
|
contID := strings.TrimSpace(out)
|
|
|
|
cmd := exec.Command(dockerBinary, "exec", "-i", contID, "echo", "-n", "hello")
|
|
p, err := pty.Start(cmd)
|
|
c.Assert(err, checker.IsNil)
|
|
|
|
b := bytes.NewBuffer(nil)
|
|
|
|
ch := make(chan error)
|
|
go func() { ch <- cmd.Wait() }()
|
|
|
|
select {
|
|
case err := <-ch:
|
|
c.Assert(err, checker.IsNil)
|
|
io.Copy(b, p)
|
|
p.Close()
|
|
bs := b.Bytes()
|
|
bs = bytes.Trim(bs, "\x00")
|
|
output := string(bs[:])
|
|
c.Assert(strings.TrimSpace(output), checker.Equals, "hello")
|
|
case <-time.After(5 * time.Second):
|
|
p.Close()
|
|
c.Fatal("timed out running docker exec")
|
|
}
|
|
}
|
|
|
|
func (s *DockerSuite) TestExecTTY(c *check.C) {
|
|
testRequires(c, DaemonIsLinux, SameHostDaemon)
|
|
dockerCmd(c, "run", "-d", "--name=test", "busybox", "sh", "-c", "echo hello > /foo && top")
|
|
|
|
cmd := exec.Command(dockerBinary, "exec", "-it", "test", "sh")
|
|
p, err := pty.Start(cmd)
|
|
c.Assert(err, checker.IsNil)
|
|
defer p.Close()
|
|
|
|
_, err = p.Write([]byte("cat /foo && exit\n"))
|
|
c.Assert(err, checker.IsNil)
|
|
|
|
chErr := make(chan error)
|
|
go func() {
|
|
chErr <- cmd.Wait()
|
|
}()
|
|
select {
|
|
case err := <-chErr:
|
|
c.Assert(err, checker.IsNil)
|
|
case <-time.After(3 * time.Second):
|
|
c.Fatal("timeout waiting for exec to exit")
|
|
}
|
|
|
|
buf := make([]byte, 256)
|
|
read, err := p.Read(buf)
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(bytes.Contains(buf, []byte("hello")), checker.Equals, true, check.Commentf(string(buf[:read])))
|
|
}
|
|
|
|
// Test the TERM env var is set when -t is provided on exec
|
|
func (s *DockerSuite) TestExecWithTERM(c *check.C) {
|
|
testRequires(c, DaemonIsLinux, SameHostDaemon)
|
|
out, _ := dockerCmd(c, "run", "-id", "busybox", "/bin/cat")
|
|
contID := strings.TrimSpace(out)
|
|
cmd := exec.Command(dockerBinary, "exec", "-t", contID, "sh", "-c", "if [ -z $TERM ]; then exit 1; else exit 0; fi")
|
|
if err := cmd.Run(); err != nil {
|
|
c.Assert(err, checker.IsNil)
|
|
}
|
|
}
|
|
|
|
// Test that the TERM env var is not set on exec when -t is not provided, even if it was set
|
|
// on run
|
|
func (s *DockerSuite) TestExecWithNoTERM(c *check.C) {
|
|
testRequires(c, DaemonIsLinux, SameHostDaemon)
|
|
out, _ := dockerCmd(c, "run", "-itd", "busybox", "/bin/cat")
|
|
contID := strings.TrimSpace(out)
|
|
cmd := exec.Command(dockerBinary, "exec", contID, "sh", "-c", "if [ -z $TERM ]; then exit 0; else exit 1; fi")
|
|
if err := cmd.Run(); err != nil {
|
|
c.Assert(err, checker.IsNil)
|
|
}
|
|
}
|