mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
8913dace34
This fix tries to address the issue raised in #20083 where comment is not supported in `.dockerignore`. This fix updated the processing of `.dockerignore` so that any lines starting with `#` are ignored, which is similiar to the behavior of `.gitignore`. Related documentation has been updated. Additional tests have been added to cover the changes. This fix fixes #20083. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
40 lines
975 B
Go
40 lines
975 B
Go
package dockerignore
|
|
|
|
import (
|
|
"bufio"
|
|
"fmt"
|
|
"io"
|
|
"path/filepath"
|
|
"strings"
|
|
)
|
|
|
|
// ReadAll reads a .dockerignore file and returns the list of file patterns
|
|
// to ignore. Note this will trim whitespace from each line as well
|
|
// as use GO's "clean" func to get the shortest/cleanest path for each.
|
|
func ReadAll(reader io.ReadCloser) ([]string, error) {
|
|
if reader == nil {
|
|
return nil, nil
|
|
}
|
|
defer reader.Close()
|
|
scanner := bufio.NewScanner(reader)
|
|
var excludes []string
|
|
|
|
for scanner.Scan() {
|
|
// Lines starting with # (comments) are ignored before processing
|
|
pattern := scanner.Text()
|
|
if strings.HasPrefix(pattern, "#") {
|
|
continue
|
|
}
|
|
pattern = strings.TrimSpace(pattern)
|
|
if pattern == "" {
|
|
continue
|
|
}
|
|
pattern = filepath.Clean(pattern)
|
|
pattern = filepath.ToSlash(pattern)
|
|
excludes = append(excludes, pattern)
|
|
}
|
|
if err := scanner.Err(); err != nil {
|
|
return nil, fmt.Errorf("Error reading .dockerignore: %v", err)
|
|
}
|
|
return excludes, nil
|
|
}
|