mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
8936789919
There has been a lot of discussion (issues 4242 and 5262) about making `FROM scratch` either a special case or making `FROM` optional, implying starting from an empty file system. This patch makes the build command `FROM scratch` special cased from now on and if used does not pull/set the the initial layer of the build to the ancient image ID (511136ea..) but instead marks the build as having no base image. The next command in the dockerfile will create an image with a parent image ID of "". This means every image ever can now use one fewer layer! This also makes the image name `scratch` a reserved name by the TagStore. You will not be able to tag an image with this name from now on. If any users currently have an image tagged as `scratch`, they will still be able to use that image, but will not be able to tag a new image with that name. Goodbye '511136ea3c5a64f264b78b5433614aec563103b4d4702f3ba7d4d2698e22c158', it was nice knowing you. Fixes #4242 Docker-DCO-1.1-Signed-off-by: Josh Hawn <josh.hawn@docker.com> (github: jlhawn)
26 lines
914 B
Go
26 lines
914 B
Go
package main
|
|
|
|
import (
|
|
"os/exec"
|
|
"testing"
|
|
)
|
|
|
|
// FIXME: we need a test for pulling all aliases for an image (issue #8141)
|
|
|
|
// pulling an image from the central registry should work
|
|
func TestPullImageFromCentralRegistry(t *testing.T) {
|
|
pullCmd := exec.Command(dockerBinary, "pull", "hello-world")
|
|
if out, _, err := runCommandWithOutput(pullCmd); err != nil {
|
|
t.Fatalf("pulling the hello-world image from the registry has failed: %s, %v", out, err)
|
|
}
|
|
logDone("pull - pull hello-world")
|
|
}
|
|
|
|
// pulling a non-existing image from the central registry should return a non-zero exit code
|
|
func TestPullNonExistingImage(t *testing.T) {
|
|
pullCmd := exec.Command(dockerBinary, "pull", "fooblahblah1234")
|
|
if out, _, err := runCommandWithOutput(pullCmd); err == nil {
|
|
t.Fatalf("expected non-zero exit status when pulling non-existing image: %s", out)
|
|
}
|
|
logDone("pull - pull fooblahblah1234 (non-existing image)")
|
|
}
|