mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
da3d3b97eb
Common patterns: - Multiple images were built with same name but only one cleanup. - Containers were deleted after images. - Images not removed after retagging. Signed-off-by: Tõnis Tiigi <tonistiigi@gmail.com> (github: tonistiigi)
129 lines
3.5 KiB
Go
129 lines
3.5 KiB
Go
package main
|
|
|
|
import (
|
|
"os"
|
|
"os/exec"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func TestRmContainerWithRemovedVolume(t *testing.T) {
|
|
cmd := exec.Command(dockerBinary, "run", "--name", "losemyvolumes", "-v", "/tmp/testing:/test", "busybox", "true")
|
|
if _, err := runCommand(cmd); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if err := os.Remove("/tmp/testing"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
cmd = exec.Command(dockerBinary, "rm", "-v", "losemyvolumes")
|
|
if out, _, err := runCommandWithOutput(cmd); err != nil {
|
|
t.Fatal(out, err)
|
|
}
|
|
|
|
deleteAllContainers()
|
|
|
|
logDone("rm - removed volume")
|
|
}
|
|
|
|
func TestRmContainerWithVolume(t *testing.T) {
|
|
cmd := exec.Command(dockerBinary, "run", "--name", "foo", "-v", "/srv", "busybox", "true")
|
|
if _, err := runCommand(cmd); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
cmd = exec.Command(dockerBinary, "rm", "-v", "foo")
|
|
if _, err := runCommand(cmd); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
deleteAllContainers()
|
|
|
|
logDone("rm - volume")
|
|
}
|
|
|
|
func TestRmRunningContainer(t *testing.T) {
|
|
createRunningContainer(t, "foo")
|
|
|
|
// Test cannot remove running container
|
|
cmd := exec.Command(dockerBinary, "rm", "foo")
|
|
if _, err := runCommand(cmd); err == nil {
|
|
t.Fatalf("Expected error, can't rm a running container")
|
|
}
|
|
|
|
deleteAllContainers()
|
|
|
|
logDone("rm - running container")
|
|
}
|
|
|
|
func TestRmForceRemoveRunningContainer(t *testing.T) {
|
|
createRunningContainer(t, "foo")
|
|
|
|
// Stop then remove with -s
|
|
cmd := exec.Command(dockerBinary, "rm", "-f", "foo")
|
|
if _, err := runCommand(cmd); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
deleteAllContainers()
|
|
|
|
logDone("rm - running container with --force=true")
|
|
}
|
|
|
|
func TestRmContainerOrphaning(t *testing.T) {
|
|
dockerfile1 := `FROM busybox:latest
|
|
ENTRYPOINT ["/bin/true"]`
|
|
img := "test-container-orphaning"
|
|
dockerfile2 := `FROM busybox:latest
|
|
ENTRYPOINT ["/bin/true"]
|
|
MAINTAINER Integration Tests`
|
|
|
|
// build first dockerfile
|
|
img1, err := buildImage(img, dockerfile1, true)
|
|
if err != nil {
|
|
t.Fatalf("Could not build image %s: %v", img, err)
|
|
}
|
|
// run container on first image
|
|
if out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", img)); err != nil {
|
|
t.Fatalf("Could not run image %s: %v: %s", img, err, out)
|
|
}
|
|
// rebuild dockerfile with a small addition at the end
|
|
if _, err := buildImage(img, dockerfile2, true); err != nil {
|
|
t.Fatalf("Could not rebuild image %s: %v", img, err)
|
|
}
|
|
// try to remove the image, should error out.
|
|
if out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "rmi", img)); err == nil {
|
|
t.Fatalf("Expected to error out removing the image, but succeeded: %s", out)
|
|
}
|
|
// check if we deleted the first image
|
|
out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "images", "-q", "--no-trunc"))
|
|
if err != nil {
|
|
t.Fatalf("%v: %s", err, out)
|
|
}
|
|
if !strings.Contains(out, img1) {
|
|
t.Fatalf("Orphaned container (could not find %q in docker images): %s", img1, out)
|
|
}
|
|
|
|
deleteAllContainers()
|
|
deleteImages(img1)
|
|
|
|
logDone("rm - container orphaning")
|
|
}
|
|
|
|
func TestRmInvalidContainer(t *testing.T) {
|
|
if out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "rm", "unknown")); err == nil {
|
|
t.Fatal("Expected error on rm unknown container, got none")
|
|
} else if !strings.Contains(out, "failed to remove one or more containers") {
|
|
t.Fatalf("Expected output to contain 'failed to remove one or more containers', got %q", out)
|
|
}
|
|
|
|
logDone("rm - delete unknown container")
|
|
}
|
|
|
|
func createRunningContainer(t *testing.T, name string) {
|
|
cmd := exec.Command(dockerBinary, "run", "-dt", "--name", name, "busybox", "top")
|
|
if _, err := runCommand(cmd); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|