1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
Moby Project - a collaborative project for the container ecosystem to assemble container-based systems
Find a file
Stephen Benjamin 89dd10b06e archive: fix race condition in cmdStream
There is a race condition in pkg/archive when using `cmd.Start` for pigz
and xz where the `*bufio.Reader` could be returned to the pool while the
command is still writing to it, and then picked up and used by a new
command.

The command is wrapped in a `CommandContext` where the process will be
killed when the context is cancelled, however this is not instantaneous,
so there's a brief window while the command is still running but the
`*bufio.Reader` was already returned to the pool.

wrapReadCloser calls `cancel()`, and then `readBuf.Close()` which
eventually returns the buffer to the pool. However, because cmdStream
runs `cmd.Wait` in a go routine that we never wait for to finish, it is
not safe to return the reader to the pool yet.  We need to ensure we
wait for `cmd.Wait` to finish!

Signed-off-by: Stephen Benjamin <stephen@redhat.com>
2019-09-11 07:37:14 -04:00
.github hack: remove integration-cli-on-swarm 2019-06-01 04:45:26 +09:00
api Fix phrasing when referring to the freezer cgroup 2019-08-16 20:39:30 +02:00
builder fix build after merge of outdated PR 2019-08-28 03:14:28 +02:00
cli
client Merge pull request #39588 from zappy-shu/DESKTOP-1286-win-admin-error-readability 2019-08-30 11:33:55 +02:00
cmd/dockerd Allow system.MkDirAll() to be used as drop-in for os.MkDirAll() 2019-08-08 15:05:49 +02:00
container Merge pull request #39699 from thaJeztah/mkdirall_dropin 2019-08-27 16:27:53 -07:00
contrib mkimage-yum.sh: Fix install of additional packages 2019-08-17 12:18:58 -07:00
daemon daemon:containerStart() fix unhandled error for saveApparmorConfig 2019-08-29 20:28:58 +02:00
distribution Add deprecation message for schema1 2019-06-18 01:40:25 +00:00
dockerversion
docs Added information regarding our new Jenkins ci on moby/moby 2019-07-30 13:48:00 -07:00
errdefs Merge pull request #39527 from thaJeztah/pull_platform_regression 2019-07-16 03:29:16 +02:00
hack Merge pull request #39804 from thaJeztah/defender_warning_only 2019-09-02 18:34:48 +03:00
image
integration Change TestCgroupNamespacesRunPrivileged requirement 2019-08-23 11:27:27 -07:00
integration-cli Use new windows labels 2019-08-21 13:12:52 +02:00
internal Jenkinsfile: reduce time of integration tests by dividing tests into 3 parallel runs 2019-08-12 20:41:03 +00:00
layer First step to implement full garbage collector for image layers 2019-06-05 22:02:42 +03:00
libcontainerd Allow system.MkDirAll() to be used as drop-in for os.MkDirAll() 2019-08-08 15:05:49 +02:00
oci
opts Adjust tests for changes in Go 1.12.8 / 1.11.13 2019-08-14 02:51:08 +02:00
pkg archive: fix race condition in cmdStream 2019-09-11 07:37:14 -04:00
plugin Add (hidden) flags to set containerd namespaces 2019-07-11 17:27:48 -07:00
profiles Add sigprocmask to default seccomp profile 2019-08-29 13:52:45 -04:00
project
reference
registry Remove v1 manifest code 2019-06-18 01:40:25 +00:00
reports
restartmanager
rootless dockerd: fix rootless detection (alternative to #39024) 2019-04-25 16:47:01 +09:00
runconfig Make cgroup namespaces configurable 2019-05-07 10:22:16 -07:00
vendor bump containerd/ttrpc 92c8520ef9f86600c650dd540266a007bf03670f 2019-08-29 00:16:46 +02:00
volume Merge pull request #39250 from shuchow/706-cifs-lookup 2019-09-03 11:07:20 +02:00
.DEREK.yml Update .DEREK.yml 2019-05-06 13:27:04 -07:00
.dockerignore hack: remove integration-cli-on-swarm 2019-06-01 04:45:26 +09:00
.gitignore run unit tests and generate junit report 2019-08-01 06:08:35 +00:00
.mailmap Update AUTHORS and mailmap 2019-04-27 16:50:47 -07:00
AUTHORS Update AUTHORS and mailmap 2019-04-27 16:50:47 -07:00
CHANGELOG.md
codecov.yml
CONTRIBUTING.md Update CONTRIBUTING.md to have an option to keep name anonymous if requested 2019-07-15 16:04:11 +02:00
Dockerfile Replace libprotobuf-c0-dev with libprotobuf-c-dev 2019-08-26 14:37:38 +02:00
Dockerfile.e2e Bump Golang 1.12.9 2019-08-16 10:02:22 +08:00
Dockerfile.simple Bump Golang 1.12.9 2019-08-16 10:02:22 +08:00
Dockerfile.windows Bump Golang 1.12.9 2019-08-16 10:02:22 +08:00
Jenkinsfile Jenkinsfile: fix invalid expression in bundles script 2019-08-28 02:16:40 +02:00
LICENSE
MAINTAINERS fix some spelling mistakes 2019-08-13 22:57:55 +08:00
Makefile Jenkinsfile: reduce time of integration tests by dividing tests into 3 parallel runs 2019-08-12 20:41:03 +00:00
NOTICE switch kr/pty to creack/pty v1.1.7 2019-07-29 16:59:08 -07:00
poule.yml
README.md
ROADMAP.md
SECURITY.md Update SECURITY.md to have an option to keep name anonymous if requested. 2019-06-18 16:37:16 +00:00
TESTING.md Bump golang 1.12.8 (CVE-2019-9512, CVE-2019-9514) 2019-08-14 02:27:05 +02:00
vendor.conf bump containerd/ttrpc 92c8520ef9f86600c650dd540266a007bf03670f 2019-08-29 00:16:46 +02:00
VENDORING.md

The Moby Project

Moby Project logo

Moby is an open-source project created by Docker to enable and accelerate software containerization.

It provides a "Lego set" of toolkit components, the framework for assembling them into custom container-based systems, and a place for all container enthusiasts and professionals to experiment and exchange ideas. Components include container build tools, a container registry, orchestration tools, a runtime and more, and these can be used as building blocks in conjunction with other tools and projects.

Principles

Moby is an open project guided by strong principles, aiming to be modular, flexible and without too strong an opinion on user experience. It is open to the community to help set its direction.

  • Modular: the project includes lots of components that have well-defined functions and APIs that work together.
  • Batteries included but swappable: Moby includes enough components to build fully featured container system, but its modular architecture ensures that most of the components can be swapped by different implementations.
  • Usable security: Moby provides secure defaults without compromising usability.
  • Developer focused: The APIs are intended to be functional and useful to build powerful tools. They are not necessarily intended as end user tools but as components aimed at developers. Documentation and UX is aimed at developers not end users.

Audience

The Moby Project is intended for engineers, integrators and enthusiasts looking to modify, hack, fix, experiment, invent and build systems based on containers. It is not for people looking for a commercially supported system, but for people who want to work and learn with open source code.

Relationship with Docker

The components and tools in the Moby Project are initially the open source components that Docker and the community have built for the Docker Project. New projects can be added if they fit with the community goals. Docker is committed to using Moby as the upstream for the Docker Product. However, other projects are also encouraged to use Moby as an upstream, and to reuse the components in diverse ways, and all these uses will be treated in the same way. External maintainers and contributors are welcomed.

The Moby project is not intended as a location for support or feature requests for Docker products, but as a place for contributors to work on open source code, fix bugs, and make the code more useful. The releases are supported by the maintainers, community and users, on a best efforts basis only, and are not intended for customers who want enterprise or commercial support; Docker EE is the appropriate product for these use cases.


Legal

Brought to you courtesy of our legal counsel. For more context, please see the NOTICE document in this repo.

Use and transfer of Moby may be subject to certain restrictions by the United States and other governments.

It is your responsibility to ensure that your use and/or transfer does not violate applicable laws.

For more information, please see https://www.bis.doc.gov

Licensing

Moby is licensed under the Apache License, Version 2.0. See LICENSE for the full license text.