mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
39be36658d
When using a named volume without --volume-driver, the driver was hardcoded to "local". Even when the volume was already created by some other driver (and visible in `docker volume ls`), the container would store in it's own config that it was the `local` driver. The external driver would work perfecly fine until the daemon is restarted, at which point the `local` driver was assumed because that is as it was set in the container config. Set the bind driver to the driver returned by createVolume. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
76 lines
2 KiB
Go
76 lines
2 KiB
Go
// +build !windows
|
|
|
|
package daemon
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
|
|
"github.com/docker/docker/image"
|
|
"github.com/docker/docker/pkg/stringid"
|
|
"github.com/docker/docker/runconfig"
|
|
"github.com/docker/docker/volume"
|
|
"github.com/opencontainers/runc/libcontainer/label"
|
|
)
|
|
|
|
// createContainerPlatformSpecificSettings performs platform specific container create functionality
|
|
func createContainerPlatformSpecificSettings(container *Container, config *runconfig.Config, img *image.Image) error {
|
|
for spec := range config.Volumes {
|
|
var (
|
|
name, destination string
|
|
parts = strings.Split(spec, ":")
|
|
)
|
|
switch len(parts) {
|
|
case 2:
|
|
name, destination = parts[0], filepath.Clean(parts[1])
|
|
default:
|
|
name = stringid.GenerateNonCryptoID()
|
|
destination = filepath.Clean(parts[0])
|
|
}
|
|
// Skip volumes for which we already have something mounted on that
|
|
// destination because of a --volume-from.
|
|
if container.isDestinationMounted(destination) {
|
|
continue
|
|
}
|
|
path, err := container.GetResourcePath(destination)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
stat, err := os.Stat(path)
|
|
if err == nil && !stat.IsDir() {
|
|
return fmt.Errorf("cannot mount volume over existing file, file exists %s", path)
|
|
}
|
|
|
|
volumeDriver := config.VolumeDriver
|
|
if destination != "" && img != nil {
|
|
if _, ok := img.ContainerConfig.Volumes[destination]; ok {
|
|
// check for whether bind is not specified and then set to local
|
|
if _, ok := container.MountPoints[destination]; !ok {
|
|
volumeDriver = volume.DefaultDriverName
|
|
}
|
|
}
|
|
}
|
|
|
|
v, err := container.daemon.createVolume(name, volumeDriver, nil)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if err := label.Relabel(v.Path(), container.MountLabel, "z"); err != nil {
|
|
return err
|
|
}
|
|
|
|
// never attempt to copy existing content in a container FS to a shared volume
|
|
if v.DriverName() == volume.DefaultDriverName {
|
|
if err := container.copyImagePathContent(v, destination); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
container.addMountPointWithVolume(destination, v, true)
|
|
}
|
|
return nil
|
|
}
|