1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
moby--moby/pkg
Sebastiaan van Stijn 4f08346686
fix formatting of "nolint" tags for go1.19
The correct formatting for machine-readable comments is;

    //<some alphanumeric identifier>:<options>[,<option>...][ // comment]

Which basically means:

- MUST NOT have a space before `<identifier>` (e.g. `nolint`)
- Identified MUST be alphanumeric
- MUST be followed by a colon
- MUST be followed by at least one `<option>`
- Optionally additional `<options>` (comma-separated)
- Optionally followed by a comment

Any other format will not be considered a machine-readable comment by `gofmt`,
and thus formatted as a regular comment. Note that this also means that a
`//nolint` (without anything after it) is considered invalid, same for `//#nosec`
(starts with a `#`).

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-07-13 22:31:53 +02:00
..
aaparser
archive gofmt GoDoc comments with go1.19 2022-07-08 19:56:23 +02:00
authorization
broadcaster
capabilities
chrootarchive gofmt GoDoc comments with go1.19 2022-07-08 19:56:23 +02:00
containerfs
devicemapper fix formatting of "nolint" tags for go1.19 2022-07-13 22:31:53 +02:00
directory fix unclosed file-handles in tests 2022-05-31 21:53:38 +02:00
dmesg
fileutils
fsutils
homedir
idtools
ioutils
jsonmessage test: use T.Setenv to set env vars in tests 2022-04-23 17:44:16 +08:00
longpath
loopback
namesgenerator Fix alphabetisation of possible names 2022-06-03 15:07:52 +01:00
parsers Merge pull request #43786 from thaJeztah/gofmt_119 2022-07-08 21:56:26 -07:00
pidfile
platform all: use unix.ByteSliceToString for utsname fields 2022-05-18 17:13:20 -07:00
plugingetter
plugins gofmt GoDoc comments with go1.19 2022-07-08 19:56:23 +02:00
pools
progress
pubsub
reexec
signal
stack all: replace strings.Replace with strings.ReplaceAll 2022-05-09 19:45:40 +08:00
stdcopy
streamformatter
stringid
sysinfo Fix constant WARNING: No swap limit support on cgroup v2 hosts 2022-05-27 10:51:54 +09:00
system gofmt GoDoc comments with go1.19 2022-07-08 19:56:23 +02:00
tailfile
tarsum
urlutil pkg/urlutil: deprecate, and move to builder/remotecontext/urlutil 2022-04-12 19:58:05 +02:00
useragent
README.md

pkg/ is a collection of utility packages used by the Moby project without being specific to its internals.

Utility packages are kept separate from the moby core codebase to keep it as small and concise as possible. If some utilities grow larger and their APIs stabilize, they may be moved to their own repository under the Moby organization, to facilitate re-use by other projects. However that is not the priority.

The directory pkg is named after the same directory in the camlistore project. Since Brad is a core Go maintainer, we thought it made sense to copy his methods for organizing Go code :) Thanks Brad!

Because utility packages are small and neatly separated from the rest of the codebase, they are a good place to start for aspiring maintainers and contributors. Get in touch if you want to help maintain them!