mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
5f89a6a78e
pkg/urlutil (despite its poorly chosen name) is not really intended as a generic utility to handle URLs, and should only be used by the builder to handle (remote) build contexts. - IsURL() only does a very rudimentary check for http(s):// prefixes, without any other validation, but due to its name may give incorrect expectations. - IsGitURL() is written specifically with docker build remote git contexts in mind, and has handling for backward-compatibility, where strings that are not URLs, but start with "github.com/" are accepted. Because of the above, this patch: - moves the package inside builder/remotecontext, close to where it's intended to be used (ideally this would be part of build/remotecontext itself, but this package imports many other dependencies, which would introduce those as extra dependencies in the CLI). - deprecates pkg/urlutil, but adds aliases as there are some external consumers. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> |
||
|---|---|---|
| .. | ||
| buildargs.go | ||
| buildargs_test.go | ||
| builder.go | ||
| builder_unix.go | ||
| builder_windows.go | ||
| containerbackend.go | ||
| copy.go | ||
| copy_test.go | ||
| copy_unix.go | ||
| copy_windows.go | ||
| dispatchers.go | ||
| dispatchers_test.go | ||
| dispatchers_unix.go | ||
| dispatchers_unix_test.go | ||
| dispatchers_windows.go | ||
| dispatchers_windows_test.go | ||
| evaluator.go | ||
| evaluator_test.go | ||
| imagecontext.go | ||
| imagecontext_test.go | ||
| imageprobe.go | ||
| internals.go | ||
| internals_linux.go | ||
| internals_linux_test.go | ||
| internals_test.go | ||
| internals_windows.go | ||
| internals_windows_test.go | ||
| metrics.go | ||
| mockbackend_test.go | ||
| utils_test.go | ||