mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
0cef21cfba
I noticed a few things that were bugging me in the output of the integration-cli tests. - one of the tests used println to stdout so we had garage sent to the screen - some of the test, in their final log message, didn't include the name of the group/file e.g. daemon - run,iptables was just run,iptables And yes, I noticed this because I'm anal :-) but also because we should keep the output of the tests as clean as possible so its easy to spot it when things go bad. Signed-off-by: Doug Davis <dug@us.ibm.com>
101 lines
3 KiB
Go
101 lines
3 KiB
Go
package main
|
|
|
|
import (
|
|
"os/exec"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func TestRmiWithContainerFails(t *testing.T) {
|
|
errSubstr := "is using it"
|
|
|
|
// create a container
|
|
runCmd := exec.Command(dockerBinary, "run", "-d", "busybox", "true")
|
|
out, _, err := runCommandWithOutput(runCmd)
|
|
if err != nil {
|
|
t.Fatalf("failed to create a container: %s, %v", out, err)
|
|
}
|
|
|
|
cleanedContainerID := stripTrailingCharacters(out)
|
|
|
|
// try to delete the image
|
|
runCmd = exec.Command(dockerBinary, "rmi", "busybox")
|
|
out, _, err = runCommandWithOutput(runCmd)
|
|
if err == nil {
|
|
t.Fatalf("Container %q is using image, should not be able to rmi: %q", cleanedContainerID, out)
|
|
}
|
|
if !strings.Contains(out, errSubstr) {
|
|
t.Fatalf("Container %q is using image, error message should contain %q: %v", cleanedContainerID, errSubstr, out)
|
|
}
|
|
|
|
// make sure it didn't delete the busybox name
|
|
images, _, _ := cmd(t, "images")
|
|
if !strings.Contains(images, "busybox") {
|
|
t.Fatalf("The name 'busybox' should not have been removed from images: %q", images)
|
|
}
|
|
|
|
deleteContainer(cleanedContainerID)
|
|
|
|
logDone("rmi- container using image while rmi, should not remove image name")
|
|
}
|
|
|
|
func TestRmiTag(t *testing.T) {
|
|
imagesBefore, _, _ := cmd(t, "images", "-a")
|
|
cmd(t, "tag", "busybox", "utest:tag1")
|
|
cmd(t, "tag", "busybox", "utest/docker:tag2")
|
|
cmd(t, "tag", "busybox", "utest:5000/docker:tag3")
|
|
{
|
|
imagesAfter, _, _ := cmd(t, "images", "-a")
|
|
if nLines(imagesAfter) != nLines(imagesBefore)+3 {
|
|
t.Fatalf("before: %q\n\nafter: %q\n", imagesBefore, imagesAfter)
|
|
}
|
|
}
|
|
cmd(t, "rmi", "utest/docker:tag2")
|
|
{
|
|
imagesAfter, _, _ := cmd(t, "images", "-a")
|
|
if nLines(imagesAfter) != nLines(imagesBefore)+2 {
|
|
t.Fatalf("before: %q\n\nafter: %q\n", imagesBefore, imagesAfter)
|
|
}
|
|
|
|
}
|
|
cmd(t, "rmi", "utest:5000/docker:tag3")
|
|
{
|
|
imagesAfter, _, _ := cmd(t, "images", "-a")
|
|
if nLines(imagesAfter) != nLines(imagesBefore)+1 {
|
|
t.Fatalf("before: %q\n\nafter: %q\n", imagesBefore, imagesAfter)
|
|
}
|
|
|
|
}
|
|
cmd(t, "rmi", "utest:tag1")
|
|
{
|
|
imagesAfter, _, _ := cmd(t, "images", "-a")
|
|
if nLines(imagesAfter) != nLines(imagesBefore)+0 {
|
|
t.Fatalf("before: %q\n\nafter: %q\n", imagesBefore, imagesAfter)
|
|
}
|
|
|
|
}
|
|
logDone("rmi - tag,rmi- tagging the same images multiple times then removing tags")
|
|
}
|
|
|
|
func TestRmiTagWithExistingContainers(t *testing.T) {
|
|
container := "test-delete-tag"
|
|
newtag := "busybox:newtag"
|
|
bb := "busybox:latest"
|
|
if out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "tag", bb, newtag)); err != nil {
|
|
t.Fatalf("Could not tag busybox: %v: %s", err, out)
|
|
}
|
|
if out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "--name", container, bb, "/bin/true")); err != nil {
|
|
t.Fatalf("Could not run busybox: %v: %s", err, out)
|
|
}
|
|
out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "rmi", newtag))
|
|
if err != nil {
|
|
t.Fatalf("Could not remove tag %s: %v: %s", newtag, err, out)
|
|
}
|
|
if d := strings.Count(out, "Untagged: "); d != 1 {
|
|
t.Fatalf("Expected 1 untagged entry got %d: %q", d, out)
|
|
}
|
|
|
|
deleteAllContainers()
|
|
|
|
logDone("rmi - delete tag with existing containers")
|
|
}
|