1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
moby--moby/pkg/devicemapper
Shishir Mahajan 0e633ee14a Fixes Issue # 23418: Race condition between device deferred removal and resume device.
Problem Description:

An example scenario that involves deferred removal
1. A new base image gets created (e.g. 'docker load -i'). The base device is activated and
mounted at some point in time during image creation.
2. While image creation is in progress, a privileged container is started
from another image and the host's mount name space is shared with this
container ('docker run --privileged -v /:/host').
3. Image creation completes and the base device gets unmounted. However,
as the privileged container still holds a reference on the base image
mount point, the base device cannot be removed right away. So it gets
flagged for deferred removal.
4. Next, the privileged container terminates and thus its reference to the
base image mount point gets released. The base device (which is flagged
for deferred removal) may now be cleaned up by the device-mapper. This
opens up an opportunity for a race between a 'kworker' thread (executing
the do_deferred_remove() function) and the Docker daemon (executing the
CreateSnapDevice() function).

This PR cancel the deferred removal, if the device is marked for it. And reschedule the
deferred removal later after the device is resumed successfully.

Signed-off-by: Shishir Mahajan <shishir.mahajan@redhat.com>
2016-08-02 10:33:58 -04:00
..
devmapper.go Fixes Issue # 23418: Race condition between device deferred removal and resume device. 2016-08-02 10:33:58 -04:00
devmapper_log.go Remove (?) from comments in pkg/devicemapper 2015-09-30 10:35:02 +02:00
devmapper_wrapper.go loopback: separate loop logic from devicemapper 2015-12-18 10:57:43 -05:00
devmapper_wrapper_deferred_remove.go Fix golint warnings 2015-11-02 08:02:25 -08:00
devmapper_wrapper_no_deferred_remove.go Lint package pkg/devicemapper 2015-09-05 23:15:13 +02:00
ioctl.go loopback: separate loop logic from devicemapper 2015-12-18 10:57:43 -05:00
log.go devicemapper: define device-mapper log levels 2015-01-20 13:31:12 -05:00