mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
32915b1d0a
Starting with this commit, integration tests should no longer rely on the docker cli, they should be API tests instead. For the existing tests the scripts will use a frozen version of the docker cli with a DOCKER_API_VERSION frozen to 1.30, which should ensure that the CI remains green at all times. To help contributors develop and test manually with a modified docker cli, this commit also adds a DOCKER_CLI_PATH environment variable to the Makefile. This allows to set the path of a custom cli that will be available inside the development container and used to run the integration tests. Signed-off-by: Arnaud Porterie (icecrime) <arnaud.porterie@docker.com> Signed-off-by: Tibor Vass <tibor@docker.com>
42 lines
1.1 KiB
Go
42 lines
1.1 KiB
Go
package flags
|
|
|
|
import (
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/docker/docker/cli"
|
|
"github.com/spf13/pflag"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestCommonOptionsInstallFlags(t *testing.T) {
|
|
flags := pflag.NewFlagSet("testing", pflag.ContinueOnError)
|
|
opts := NewCommonOptions()
|
|
opts.InstallFlags(flags)
|
|
|
|
err := flags.Parse([]string{
|
|
"--tlscacert=\"/foo/cafile\"",
|
|
"--tlscert=\"/foo/cert\"",
|
|
"--tlskey=\"/foo/key\"",
|
|
})
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "/foo/cafile", opts.TLSOptions.CAFile)
|
|
assert.Equal(t, "/foo/cert", opts.TLSOptions.CertFile)
|
|
assert.Equal(t, opts.TLSOptions.KeyFile, "/foo/key")
|
|
}
|
|
|
|
func defaultPath(filename string) string {
|
|
return filepath.Join(cli.ConfigurationDir(), filename)
|
|
}
|
|
|
|
func TestCommonOptionsInstallFlagsWithDefaults(t *testing.T) {
|
|
flags := pflag.NewFlagSet("testing", pflag.ContinueOnError)
|
|
opts := NewCommonOptions()
|
|
opts.InstallFlags(flags)
|
|
|
|
err := flags.Parse([]string{})
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, defaultPath("ca.pem"), opts.TLSOptions.CAFile)
|
|
assert.Equal(t, defaultPath("cert.pem"), opts.TLSOptions.CertFile)
|
|
assert.Equal(t, defaultPath("key.pem"), opts.TLSOptions.KeyFile)
|
|
}
|