mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
cdb8ea90b0
This reverts 26103. 26103 was trying to make it so that if someone did: docker build --build-arg FOO . and FOO wasn't set as an env var then it would pick-up FOO from the Dockerfile's ARG cmd. However, it went too far and removed the ability to specify a build arg w/o any value. Meaning it required the --build-arg param to always be in the form "name=value", and not just "name". This PR does the right fix - it allows just "name" and it'll grab the value from the env vars if set. If "name" isn't set in the env then it still needs to send "name" to the server so that a warning can be printed about an unused --build-arg. And this is why buildArgs in the options is now a *string instead of just a string - 'nil' == mentioned but no value. Closes #29084 Signed-off-by: Doug Davis <dug@us.ibm.com> |
||
|---|---|---|
| .. | ||
| command | ||
| parser | ||
| bflag.go | ||
| bflag_test.go | ||
| builder.go | ||
| builder_unix.go | ||
| builder_windows.go | ||
| dispatchers.go | ||
| dispatchers_test.go | ||
| dispatchers_unix.go | ||
| dispatchers_unix_test.go | ||
| dispatchers_windows.go | ||
| dispatchers_windows_test.go | ||
| envVarTest | ||
| evaluator.go | ||
| evaluator_test.go | ||
| evaluator_unix.go | ||
| evaluator_windows.go | ||
| internals.go | ||
| internals_test.go | ||
| internals_unix.go | ||
| internals_windows.go | ||
| internals_windows_test.go | ||
| shell_parser.go | ||
| shell_parser_test.go | ||
| support.go | ||
| support_test.go | ||
| utils_test.go | ||
| wordsTest | ||