mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
41eb61d5c2
Previously, only perm-related bits where preserved when rewriting FileMode in tar entries on Windows. This had the nasty side effect of having tarsum returning different values when executing from a tar filed produced on Windows or Linux. This fix the issue, and pave the way for incremental build context to work in hybrid contexts. Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
93 lines
2.4 KiB
Go
93 lines
2.4 KiB
Go
// +build windows
|
|
|
|
package archive
|
|
|
|
import (
|
|
"io/ioutil"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
)
|
|
|
|
func TestCopyFileWithInvalidDest(t *testing.T) {
|
|
// TODO Windows: This is currently failing. Not sure what has
|
|
// recently changed in CopyWithTar as used to pass. Further investigation
|
|
// is required.
|
|
t.Skip("Currently fails")
|
|
folder, err := ioutil.TempDir("", "docker-archive-test")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer os.RemoveAll(folder)
|
|
dest := "c:dest"
|
|
srcFolder := filepath.Join(folder, "src")
|
|
src := filepath.Join(folder, "src", "src")
|
|
err = os.MkdirAll(srcFolder, 0740)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
ioutil.WriteFile(src, []byte("content"), 0777)
|
|
err = CopyWithTar(src, dest)
|
|
if err == nil {
|
|
t.Fatalf("archiver.CopyWithTar should throw an error on invalid dest.")
|
|
}
|
|
}
|
|
|
|
func TestCanonicalTarNameForPath(t *testing.T) {
|
|
cases := []struct {
|
|
in, expected string
|
|
shouldFail bool
|
|
}{
|
|
{"foo", "foo", false},
|
|
{"foo/bar", "___", true}, // unix-styled windows path must fail
|
|
{`foo\bar`, "foo/bar", false},
|
|
}
|
|
for _, v := range cases {
|
|
if out, err := CanonicalTarNameForPath(v.in); err != nil && !v.shouldFail {
|
|
t.Fatalf("cannot get canonical name for path: %s: %v", v.in, err)
|
|
} else if v.shouldFail && err == nil {
|
|
t.Fatalf("canonical path call should have failed with error. in=%s out=%s", v.in, out)
|
|
} else if !v.shouldFail && out != v.expected {
|
|
t.Fatalf("wrong canonical tar name. expected:%s got:%s", v.expected, out)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestCanonicalTarName(t *testing.T) {
|
|
cases := []struct {
|
|
in string
|
|
isDir bool
|
|
expected string
|
|
}{
|
|
{"foo", false, "foo"},
|
|
{"foo", true, "foo/"},
|
|
{`foo\bar`, false, "foo/bar"},
|
|
{`foo\bar`, true, "foo/bar/"},
|
|
}
|
|
for _, v := range cases {
|
|
if out, err := canonicalTarName(v.in, v.isDir); err != nil {
|
|
t.Fatalf("cannot get canonical name for path: %s: %v", v.in, err)
|
|
} else if out != v.expected {
|
|
t.Fatalf("wrong canonical tar name. expected:%s got:%s", v.expected, out)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestChmodTarEntry(t *testing.T) {
|
|
cases := []struct {
|
|
in, expected os.FileMode
|
|
}{
|
|
{0000, 0111},
|
|
{0777, 0755},
|
|
{0644, 0755},
|
|
{0755, 0755},
|
|
{0444, 0555},
|
|
{0755 | os.ModeDir, 0755 | os.ModeDir},
|
|
{0755 | os.ModeSymlink, 0755 | os.ModeSymlink},
|
|
}
|
|
for _, v := range cases {
|
|
if out := chmodTarEntry(v.in); out != v.expected {
|
|
t.Fatalf("wrong chmod. expected:%v got:%v", v.expected, out)
|
|
}
|
|
}
|
|
}
|