mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
a46f757c40
Closes #32663 by adding CreatedAt field when volume is created. Displaying CreatedAt value when volume is inspected Adding tests to verfiy the new field is correctly populated Signed-off-by: Marianna <mtesselh@gmail.com> Moving CreatedAt tests from the CLI Moving the tests added for the newly added CreatedAt field for Volume, from CLI to API tests Signed-off-by: Marianna <mtesselh@gmail.com>
103 lines
3.8 KiB
Go
103 lines
3.8 KiB
Go
package main
|
|
|
|
import (
|
|
"encoding/json"
|
|
"fmt"
|
|
"net/http"
|
|
"path/filepath"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/docker/docker/api/types"
|
|
volumetypes "github.com/docker/docker/api/types/volume"
|
|
"github.com/docker/docker/integration-cli/checker"
|
|
"github.com/docker/docker/integration-cli/request"
|
|
"github.com/go-check/check"
|
|
)
|
|
|
|
func (s *DockerSuite) TestVolumesAPIList(c *check.C) {
|
|
prefix, _ := getPrefixAndSlashFromDaemonPlatform()
|
|
dockerCmd(c, "run", "-v", prefix+"/foo", "busybox")
|
|
|
|
status, b, err := request.SockRequest("GET", "/volumes", nil, daemonHost())
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(status, checker.Equals, http.StatusOK)
|
|
|
|
var volumes volumetypes.VolumesListOKBody
|
|
c.Assert(json.Unmarshal(b, &volumes), checker.IsNil)
|
|
|
|
c.Assert(len(volumes.Volumes), checker.Equals, 1, check.Commentf("\n%v", volumes.Volumes))
|
|
}
|
|
|
|
func (s *DockerSuite) TestVolumesAPICreate(c *check.C) {
|
|
config := volumetypes.VolumesCreateBody{
|
|
Name: "test",
|
|
}
|
|
status, b, err := request.SockRequest("POST", "/volumes/create", config, daemonHost())
|
|
c.Assert(err, check.IsNil)
|
|
c.Assert(status, check.Equals, http.StatusCreated, check.Commentf(string(b)))
|
|
|
|
var vol types.Volume
|
|
err = json.Unmarshal(b, &vol)
|
|
c.Assert(err, checker.IsNil)
|
|
|
|
c.Assert(filepath.Base(filepath.Dir(vol.Mountpoint)), checker.Equals, config.Name)
|
|
}
|
|
|
|
func (s *DockerSuite) TestVolumesAPIRemove(c *check.C) {
|
|
prefix, _ := getPrefixAndSlashFromDaemonPlatform()
|
|
dockerCmd(c, "run", "-v", prefix+"/foo", "--name=test", "busybox")
|
|
|
|
status, b, err := request.SockRequest("GET", "/volumes", nil, daemonHost())
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(status, checker.Equals, http.StatusOK)
|
|
|
|
var volumes volumetypes.VolumesListOKBody
|
|
c.Assert(json.Unmarshal(b, &volumes), checker.IsNil)
|
|
c.Assert(len(volumes.Volumes), checker.Equals, 1, check.Commentf("\n%v", volumes.Volumes))
|
|
|
|
v := volumes.Volumes[0]
|
|
status, _, err = request.SockRequest("DELETE", "/volumes/"+v.Name, nil, daemonHost())
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(status, checker.Equals, http.StatusConflict, check.Commentf("Should not be able to remove a volume that is in use"))
|
|
|
|
dockerCmd(c, "rm", "-f", "test")
|
|
status, data, err := request.SockRequest("DELETE", "/volumes/"+v.Name, nil, daemonHost())
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(status, checker.Equals, http.StatusNoContent, check.Commentf(string(data)))
|
|
|
|
}
|
|
|
|
func (s *DockerSuite) TestVolumesAPIInspect(c *check.C) {
|
|
config := volumetypes.VolumesCreateBody{
|
|
Name: "test",
|
|
}
|
|
// sampling current time minus a minute so to now have false positive in case of delays
|
|
now := time.Now().Truncate(time.Minute)
|
|
status, b, err := request.SockRequest("POST", "/volumes/create", config, daemonHost())
|
|
c.Assert(err, check.IsNil)
|
|
c.Assert(status, check.Equals, http.StatusCreated, check.Commentf(string(b)))
|
|
|
|
status, b, err = request.SockRequest("GET", "/volumes", nil, daemonHost())
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(status, checker.Equals, http.StatusOK, check.Commentf(string(b)))
|
|
|
|
var volumes volumetypes.VolumesListOKBody
|
|
c.Assert(json.Unmarshal(b, &volumes), checker.IsNil)
|
|
c.Assert(len(volumes.Volumes), checker.Equals, 1, check.Commentf("\n%v", volumes.Volumes))
|
|
|
|
var vol types.Volume
|
|
status, b, err = request.SockRequest("GET", "/volumes/"+config.Name, nil, daemonHost())
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(status, checker.Equals, http.StatusOK, check.Commentf(string(b)))
|
|
c.Assert(json.Unmarshal(b, &vol), checker.IsNil)
|
|
c.Assert(vol.Name, checker.Equals, config.Name)
|
|
|
|
// comparing CreatedAt field time for the new volume to now. Removing a minute from both to avoid false positive
|
|
testCreatedAt, err := time.Parse(time.RFC3339, strings.TrimSpace(vol.CreatedAt))
|
|
c.Assert(err, check.IsNil)
|
|
testCreatedAt = testCreatedAt.Truncate(time.Minute)
|
|
if !testCreatedAt.Equal(now) {
|
|
c.Assert(fmt.Errorf("Time Volume is CreatedAt not equal to current time"), check.NotNil)
|
|
}
|
|
}
|