mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
388ed88042
docker top: fix command when multiple arguments are supplied
91 lines
3.4 KiB
Go
91 lines
3.4 KiB
Go
package main
|
|
|
|
import (
|
|
"fmt"
|
|
"os/exec"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func TestTopMultipleArgs(t *testing.T) {
|
|
runCmd := exec.Command(dockerBinary, "run", "-i", "-d", "busybox", "sleep", "20")
|
|
out, _, err := runCommandWithOutput(runCmd)
|
|
errorOut(err, t, fmt.Sprintf("failed to start the container: %v", err))
|
|
|
|
cleanedContainerID := stripTrailingCharacters(out)
|
|
defer deleteContainer(cleanedContainerID)
|
|
|
|
topCmd := exec.Command(dockerBinary, "top", cleanedContainerID, "-o", "pid")
|
|
out, _, err = runCommandWithOutput(topCmd)
|
|
errorOut(err, t, fmt.Sprintf("failed to run top: %v %v", out, err))
|
|
|
|
if !strings.Contains(out, "PID") {
|
|
errorOut(nil, t, fmt.Sprintf("did not see PID after top -o pid"))
|
|
}
|
|
|
|
logDone("top - multiple arguments")
|
|
}
|
|
|
|
func TestTopNonPrivileged(t *testing.T) {
|
|
runCmd := exec.Command(dockerBinary, "run", "-i", "-d", "busybox", "sleep", "20")
|
|
out, _, err := runCommandWithOutput(runCmd)
|
|
errorOut(err, t, fmt.Sprintf("failed to start the container: %v", err))
|
|
|
|
cleanedContainerID := stripTrailingCharacters(out)
|
|
|
|
topCmd := exec.Command(dockerBinary, "top", cleanedContainerID)
|
|
out, _, err = runCommandWithOutput(topCmd)
|
|
errorOut(err, t, fmt.Sprintf("failed to run top: %v %v", out, err))
|
|
|
|
topCmd = exec.Command(dockerBinary, "top", cleanedContainerID)
|
|
out2, _, err2 := runCommandWithOutput(topCmd)
|
|
errorOut(err2, t, fmt.Sprintf("failed to run top: %v %v", out2, err2))
|
|
|
|
killCmd := exec.Command(dockerBinary, "kill", cleanedContainerID)
|
|
_, err = runCommand(killCmd)
|
|
errorOut(err, t, fmt.Sprintf("failed to kill container: %v", err))
|
|
|
|
deleteContainer(cleanedContainerID)
|
|
|
|
if !strings.Contains(out, "sleep 20") && !strings.Contains(out2, "sleep 20") {
|
|
t.Fatal("top should've listed `sleep 20` in the process list, but failed twice")
|
|
} else if !strings.Contains(out, "sleep 20") {
|
|
t.Fatal("top should've listed `sleep 20` in the process list, but failed the first time")
|
|
} else if !strings.Contains(out2, "sleep 20") {
|
|
t.Fatal("top should've listed `sleep 20` in the process list, but failed the second itime")
|
|
}
|
|
|
|
logDone("top - sleep process should be listed in non privileged mode")
|
|
}
|
|
|
|
func TestTopPrivileged(t *testing.T) {
|
|
runCmd := exec.Command(dockerBinary, "run", "--privileged", "-i", "-d", "busybox", "sleep", "20")
|
|
out, _, err := runCommandWithOutput(runCmd)
|
|
errorOut(err, t, fmt.Sprintf("failed to start the container: %v", err))
|
|
|
|
cleanedContainerID := stripTrailingCharacters(out)
|
|
|
|
topCmd := exec.Command(dockerBinary, "top", cleanedContainerID)
|
|
out, _, err = runCommandWithOutput(topCmd)
|
|
errorOut(err, t, fmt.Sprintf("failed to run top: %v %v", out, err))
|
|
|
|
topCmd = exec.Command(dockerBinary, "top", cleanedContainerID)
|
|
out2, _, err2 := runCommandWithOutput(topCmd)
|
|
errorOut(err2, t, fmt.Sprintf("failed to run top: %v %v", out2, err2))
|
|
|
|
killCmd := exec.Command(dockerBinary, "kill", cleanedContainerID)
|
|
_, err = runCommand(killCmd)
|
|
errorOut(err, t, fmt.Sprintf("failed to kill container: %v", err))
|
|
|
|
deleteContainer(cleanedContainerID)
|
|
|
|
if !strings.Contains(out, "sleep 20") && !strings.Contains(out2, "sleep 20") {
|
|
t.Fatal("top should've listed `sleep 20` in the process list, but failed twice")
|
|
} else if !strings.Contains(out, "sleep 20") {
|
|
t.Fatal("top should've listed `sleep 20` in the process list, but failed the first time")
|
|
} else if !strings.Contains(out2, "sleep 20") {
|
|
t.Fatal("top should've listed `sleep 20` in the process list, but failed the second itime")
|
|
}
|
|
|
|
logDone("top - sleep process should be listed in privileged mode")
|
|
}
|