1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
moby--moby/api/server
Yong Tang abf31ee083 Return error in case docker network inspect is ambiguous
This fix is partially based on comment
https://github.com/docker/docker/issues/30242#issuecomment-273517205

Currently, `docker network inspect` relies on `FindNetwork()` which
does not take into consideration that multiple networks with the same
name might exist.

This fix propose to return `docker network inspect` in a similiar
fashion like other commands:
1. Lookup full ID
2. Lookup full name
3. Lookup partial ID
If multiple networks exist, an error will be returned.

NOTE: this fix is not a complete fix for the issue raised in
https://github.com/docker/docker/issues/30242#issuecomment-273517205
where SwarmKit is unable to update when multiple networks with the same
name exit.
To fix that issue requires multiple places when `FindNetwork()` is called.
Because of the impact of changing `FindNetwork()`, this fix focus on
the issue in `docker network inspect`.

A separate PR will be created to address
https://github.com/docker/docker/issues/30242#issuecomment-273517205

An integration test has been added.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2017-02-07 18:05:29 -08:00
..
httputils fix some types on errors and form 2017-02-07 20:29:32 +08:00
middleware Revise swarm init/update flags, add unlocking capability 2016-11-09 16:09:00 -08:00
router Return error in case docker network inspect is ambiguous 2017-02-07 18:05:29 -08:00
middleware.go change comment 2016-08-26 18:30:41 +08:00
profiler.go add trace in docker engine's pprof to show execution trace in binary form 2016-05-13 15:24:44 +08:00
router_swapper.go fix typos 2016-03-06 00:59:11 +08:00
server.go Show stacktrace in daemon logs only if 500 internal error 2017-02-06 10:13:21 -08:00
server_test.go replace handleWithGlobalMiddlewares with handlerWithGlobalMiddlewares 2016-08-12 10:53:11 +08:00