1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
moby--moby/pkg
Kir Kolyshkin a1d095199d mount.Unmount(): don't look into /proc/self/mountinfo
Now, every Unmount() call takes a burden to parse the whole nine yards
of /proc/self/mountinfo to figure out whether the given mount point is
mounted or not (and returns an error in case parsing fails somehow).

Instead, let's just call umount() and ignore EINVAL, which results
in the same behavior, but much better performance.

Note that EINVAL is returned from umount(2) not only in the case when
`target` is not mounted, but also for invalid flags. As the flags are
hardcoded here, it can't be the case.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
2018-04-19 14:49:50 -07:00
..
aaparser
archive
authorization Merge pull request #36778 from odg0318/master 2018-04-12 17:39:38 -07:00
broadcaster
chrootarchive
containerfs
devicemapper
directory
discovery
dmesg
filenotify
fileutils
fsutils
homedir
idtools
ioutils
jsonmessage
locker
longpath
loopback
mount mount.Unmount(): don't look into /proc/self/mountinfo 2018-04-19 14:49:50 -07:00
namesgenerator
parsers
pidfile
platform
plugingetter
plugins
pools
progress
pubsub
reexec
signal
stdcopy
streamformatter
stringid
symlink
sysinfo
system
tailfile
tarsum
term
truncindex
urlutil
useragent
README.md

pkg/ is a collection of utility packages used by the Moby project without being specific to its internals.

Utility packages are kept separate from the moby core codebase to keep it as small and concise as possible. If some utilities grow larger and their APIs stabilize, they may be moved to their own repository under the Moby organization, to facilitate re-use by other projects. However that is not the priority.

The directory pkg is named after the same directory in the camlistore project. Since Brad is a core Go maintainer, we thought it made sense to copy his methods for organizing Go code :) Thanks Brad!

Because utility packages are small and neatly separated from the rest of the codebase, they are a good place to start for aspiring maintainers and contributors. Get in touch if you want to help maintain them!