mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
41de7a18d8
The purpose of this PR is for users to distinguish Docker errors from contained command errors. This PR modifies 'docker run' exit codes to follow the chroot standard for exit codes. Exit status: 125 if 'docker run' itself fails 126 if contained command cannot be invoked 127 if contained command cannot be found the exit status otherwise Signed-off-by: Sally O'Malley <somalley@redhat.com>
180 lines
7 KiB
Go
180 lines
7 KiB
Go
package main
|
|
|
|
import (
|
|
"fmt"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/docker/docker/pkg/integration/checker"
|
|
"github.com/go-check/check"
|
|
)
|
|
|
|
// Regression test for https://github.com/docker/docker/issues/7843
|
|
func (s *DockerSuite) TestStartAttachReturnsOnError(c *check.C) {
|
|
testRequires(c, DaemonIsLinux)
|
|
dockerCmd(c, "run", "-d", "--name", "test", "busybox")
|
|
dockerCmd(c, "wait", "test")
|
|
|
|
// Expect this to fail because the above container is stopped, this is what we want
|
|
out, _, err := dockerCmdWithError("run", "-d", "--name", "test2", "--link", "test:test", "busybox")
|
|
// err shouldn't be nil because container test2 try to link to stopped container
|
|
c.Assert(err, checker.NotNil, check.Commentf("out: %s", out))
|
|
|
|
ch := make(chan error)
|
|
go func() {
|
|
// Attempt to start attached to the container that won't start
|
|
// This should return an error immediately since the container can't be started
|
|
if _, _, err := dockerCmdWithError("start", "-a", "test2"); err == nil {
|
|
ch <- fmt.Errorf("Expected error but got none")
|
|
}
|
|
close(ch)
|
|
}()
|
|
|
|
select {
|
|
case err := <-ch:
|
|
c.Assert(err, check.IsNil)
|
|
case <-time.After(time.Second):
|
|
c.Fatalf("Attach did not exit properly")
|
|
}
|
|
}
|
|
|
|
// gh#8555: Exit code should be passed through when using start -a
|
|
func (s *DockerSuite) TestStartAttachCorrectExitCode(c *check.C) {
|
|
testRequires(c, DaemonIsLinux)
|
|
out, _, _ := dockerCmdWithStdoutStderr(c, "run", "-d", "busybox", "sh", "-c", "sleep 2; exit 1")
|
|
out = strings.TrimSpace(out)
|
|
|
|
// make sure the container has exited before trying the "start -a"
|
|
dockerCmd(c, "wait", out)
|
|
|
|
startOut, exitCode, err := dockerCmdWithError("start", "-a", out)
|
|
// start command should fail
|
|
c.Assert(err, checker.NotNil, check.Commentf("startOut: %s", startOut))
|
|
// start -a did not respond with proper exit code
|
|
c.Assert(exitCode, checker.Equals, 1, check.Commentf("startOut: %s", startOut))
|
|
|
|
}
|
|
|
|
func (s *DockerSuite) TestStartAttachSilent(c *check.C) {
|
|
testRequires(c, DaemonIsLinux)
|
|
name := "teststartattachcorrectexitcode"
|
|
dockerCmd(c, "run", "--name", name, "busybox", "echo", "test")
|
|
|
|
// make sure the container has exited before trying the "start -a"
|
|
dockerCmd(c, "wait", name)
|
|
|
|
startOut, _ := dockerCmd(c, "start", "-a", name)
|
|
// start -a produced unexpected output
|
|
c.Assert(startOut, checker.Equals, "test\n")
|
|
}
|
|
|
|
func (s *DockerSuite) TestStartRecordError(c *check.C) {
|
|
testRequires(c, DaemonIsLinux)
|
|
// when container runs successfully, we should not have state.Error
|
|
dockerCmd(c, "run", "-d", "-p", "9999:9999", "--name", "test", "busybox", "top")
|
|
stateErr, err := inspectField("test", "State.Error")
|
|
c.Assert(err, checker.IsNil, check.Commentf("stateErr: %s", stateErr))
|
|
// Expected to not have state error
|
|
c.Assert(stateErr, checker.Equals, "")
|
|
|
|
// Expect this to fail and records error because of ports conflict
|
|
out, _, err := dockerCmdWithError("run", "-d", "--name", "test2", "-p", "9999:9999", "busybox", "top")
|
|
// err shouldn't be nil because docker run will fail
|
|
c.Assert(err, checker.NotNil, check.Commentf("out: %s", out))
|
|
|
|
stateErr, err = inspectField("test2", "State.Error")
|
|
c.Assert(err, check.IsNil, check.Commentf("stateErr: %s", stateErr))
|
|
c.Assert(stateErr, checker.Contains, "port is already allocated")
|
|
|
|
// Expect the conflict to be resolved when we stop the initial container
|
|
dockerCmd(c, "stop", "test")
|
|
dockerCmd(c, "start", "test2")
|
|
stateErr, err = inspectField("test2", "State.Error")
|
|
c.Assert(err, check.IsNil, check.Commentf("stateErr: %s", stateErr))
|
|
// Expected to not have state error but got one
|
|
c.Assert(stateErr, checker.Equals, "")
|
|
}
|
|
|
|
func (s *DockerSuite) TestStartPausedContainer(c *check.C) {
|
|
testRequires(c, DaemonIsLinux)
|
|
defer unpauseAllContainers()
|
|
|
|
dockerCmd(c, "run", "-d", "--name", "testing", "busybox", "top")
|
|
|
|
dockerCmd(c, "pause", "testing")
|
|
|
|
out, _, err := dockerCmdWithError("start", "testing")
|
|
// an error should have been shown that you cannot start paused container
|
|
c.Assert(err, checker.NotNil, check.Commentf("out: %s", out))
|
|
// an error should have been shown that you cannot start paused container
|
|
c.Assert(out, checker.Contains, "Cannot start a paused container, try unpause instead.")
|
|
}
|
|
|
|
func (s *DockerSuite) TestStartMultipleContainers(c *check.C) {
|
|
testRequires(c, DaemonIsLinux)
|
|
// run a container named 'parent' and create two container link to `parent`
|
|
dockerCmd(c, "run", "-d", "--name", "parent", "busybox", "top")
|
|
|
|
for _, container := range []string{"child_first", "child_second"} {
|
|
dockerCmd(c, "create", "--name", container, "--link", "parent:parent", "busybox", "top")
|
|
}
|
|
|
|
// stop 'parent' container
|
|
dockerCmd(c, "stop", "parent")
|
|
|
|
out, err := inspectField("parent", "State.Running")
|
|
c.Assert(err, check.IsNil, check.Commentf("out: %s", out))
|
|
// Container should be stopped
|
|
c.Assert(out, checker.Equals, "false")
|
|
|
|
// start all the three containers, container `child_first` start first which should be failed
|
|
// container 'parent' start second and then start container 'child_second'
|
|
expOut := "Cannot link to a non running container"
|
|
expErr := "failed to start containers: [child_first]"
|
|
out, _, err = dockerCmdWithError("start", "child_first", "parent", "child_second")
|
|
// err shouldn't be nil because start will fail
|
|
c.Assert(err, checker.NotNil, check.Commentf("out: %s", out))
|
|
// output does not correspond to what was expected
|
|
if !(strings.Contains(out, expOut) || strings.Contains(err.Error(), expErr)) {
|
|
c.Fatalf("Expected out: %v with err: %v but got out: %v with err: %v", expOut, expErr, out, err)
|
|
}
|
|
|
|
for container, expected := range map[string]string{"parent": "true", "child_first": "false", "child_second": "true"} {
|
|
out, err := inspectField(container, "State.Running")
|
|
// Container running state wrong
|
|
c.Assert(err, check.IsNil, check.Commentf("out: %s", out))
|
|
// Container running state wrong
|
|
c.Assert(out, checker.Equals, expected)
|
|
}
|
|
}
|
|
|
|
func (s *DockerSuite) TestStartAttachMultipleContainers(c *check.C) {
|
|
testRequires(c, DaemonIsLinux)
|
|
// run multiple containers to test
|
|
for _, container := range []string{"test1", "test2", "test3"} {
|
|
dockerCmd(c, "run", "-d", "--name", container, "busybox", "top")
|
|
}
|
|
|
|
// stop all the containers
|
|
for _, container := range []string{"test1", "test2", "test3"} {
|
|
dockerCmd(c, "stop", container)
|
|
}
|
|
|
|
// test start and attach multiple containers at once, expected error
|
|
for _, option := range []string{"-a", "-i", "-ai"} {
|
|
out, _, err := dockerCmdWithError("start", option, "test1", "test2", "test3")
|
|
// err shouldn't be nil because start will fail
|
|
c.Assert(err, checker.NotNil, check.Commentf("out: %s", out))
|
|
// output does not correspond to what was expected
|
|
c.Assert(out, checker.Contains, "You cannot start and attach multiple containers at once.")
|
|
}
|
|
|
|
// confirm the state of all the containers be stopped
|
|
for container, expected := range map[string]string{"test1": "false", "test2": "false", "test3": "false"} {
|
|
out, err := inspectField(container, "State.Running")
|
|
// Container running state wrong
|
|
c.Assert(err, check.IsNil, check.Commentf("out: %s", out))
|
|
// Container running state wrong
|
|
c.Assert(out, checker.Equals, expected)
|
|
}
|
|
}
|