mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
0c9ff0b45a
Implement a ReadJSON() utility to help reduce some code-duplication,
and to make sure we handle JSON requests consistently (e.g. always
check for the content-type).
Differences compared to current handling:
- prevent possible panic if request.Body is nil ("should never happen")
- always require Content-Type to be "application/json"
- be stricter about additional content after JSON (previously ignored)
- but, allow the body to be empty (an empty body is not invalid);
update TestContainerInvalidJSON accordingly, which was testing the
wrong expectation.
- close body after reading (some code did this)
We should consider to add a "max body size" on this function, similar to
7b9275c0da/api/server/middleware/debug.go (L27-L40)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
72 lines
3.3 KiB
Go
72 lines
3.3 KiB
Go
package container // import "github.com/docker/docker/api/server/router/container"
|
|
|
|
import (
|
|
"github.com/docker/docker/api/server/httputils"
|
|
"github.com/docker/docker/api/server/router"
|
|
)
|
|
|
|
// containerRouter is a router to talk with the container controller
|
|
type containerRouter struct {
|
|
backend Backend
|
|
decoder httputils.ContainerDecoder
|
|
routes []router.Route
|
|
cgroup2 bool
|
|
}
|
|
|
|
// NewRouter initializes a new container router
|
|
func NewRouter(b Backend, decoder httputils.ContainerDecoder, cgroup2 bool) router.Router {
|
|
r := &containerRouter{
|
|
backend: b,
|
|
decoder: decoder,
|
|
cgroup2: cgroup2,
|
|
}
|
|
r.initRoutes()
|
|
return r
|
|
}
|
|
|
|
// Routes returns the available routes to the container controller
|
|
func (r *containerRouter) Routes() []router.Route {
|
|
return r.routes
|
|
}
|
|
|
|
// initRoutes initializes the routes in container router
|
|
func (r *containerRouter) initRoutes() {
|
|
r.routes = []router.Route{
|
|
// HEAD
|
|
router.NewHeadRoute("/containers/{name:.*}/archive", r.headContainersArchive),
|
|
// GET
|
|
router.NewGetRoute("/containers/json", r.getContainersJSON),
|
|
router.NewGetRoute("/containers/{name:.*}/export", r.getContainersExport),
|
|
router.NewGetRoute("/containers/{name:.*}/changes", r.getContainersChanges),
|
|
router.NewGetRoute("/containers/{name:.*}/json", r.getContainersByName),
|
|
router.NewGetRoute("/containers/{name:.*}/top", r.getContainersTop),
|
|
router.NewGetRoute("/containers/{name:.*}/logs", r.getContainersLogs),
|
|
router.NewGetRoute("/containers/{name:.*}/stats", r.getContainersStats),
|
|
router.NewGetRoute("/containers/{name:.*}/attach/ws", r.wsContainersAttach),
|
|
router.NewGetRoute("/exec/{id:.*}/json", r.getExecByID),
|
|
router.NewGetRoute("/containers/{name:.*}/archive", r.getContainersArchive),
|
|
// POST
|
|
router.NewPostRoute("/containers/create", r.postContainersCreate),
|
|
router.NewPostRoute("/containers/{name:.*}/kill", r.postContainersKill),
|
|
router.NewPostRoute("/containers/{name:.*}/pause", r.postContainersPause),
|
|
router.NewPostRoute("/containers/{name:.*}/unpause", r.postContainersUnpause),
|
|
router.NewPostRoute("/containers/{name:.*}/restart", r.postContainersRestart),
|
|
router.NewPostRoute("/containers/{name:.*}/start", r.postContainersStart),
|
|
router.NewPostRoute("/containers/{name:.*}/stop", r.postContainersStop),
|
|
router.NewPostRoute("/containers/{name:.*}/wait", r.postContainersWait),
|
|
router.NewPostRoute("/containers/{name:.*}/resize", r.postContainersResize),
|
|
router.NewPostRoute("/containers/{name:.*}/attach", r.postContainersAttach),
|
|
router.NewPostRoute("/containers/{name:.*}/copy", r.postContainersCopy), // Deprecated since 1.8 (API v1.20), errors out since 1.12 (API v1.24)
|
|
router.NewPostRoute("/containers/{name:.*}/exec", r.postContainerExecCreate),
|
|
router.NewPostRoute("/exec/{name:.*}/start", r.postContainerExecStart),
|
|
router.NewPostRoute("/exec/{name:.*}/resize", r.postContainerExecResize),
|
|
router.NewPostRoute("/containers/{name:.*}/rename", r.postContainerRename),
|
|
router.NewPostRoute("/containers/{name:.*}/update", r.postContainerUpdate),
|
|
router.NewPostRoute("/containers/prune", r.postContainersPrune),
|
|
router.NewPostRoute("/commit", r.postCommit),
|
|
// PUT
|
|
router.NewPutRoute("/containers/{name:.*}/archive", r.putContainersArchive),
|
|
// DELETE
|
|
router.NewDeleteRoute("/containers/{name:.*}", r.deleteContainers),
|
|
}
|
|
}
|