1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
moby--moby/daemon
Sebastiaan van Stijn 3258d565cf
Fix status code for missing --volumes-from container
If the container specified in `--volumes-from` did not exist, the
API returned a 404 status, which was interpreted by the CLI as the
specified _image_ to be missing (even if that was not the case).

This patch changes these error to return a 400 (bad request);

Before this change:

    # make sure the image is present
    docker pull busybox
    docker create --volumes-from=nosuchcontainer busybox
    # Unable to find image 'busybox:latest' locally
    # latest: Pulling from library/busybox
    # Digest: sha256:95cf004f559831017cdf4628aaf1bb30133677be8702a8c5f2994629f637a209
    # Status: Image is up to date for busybox:latest
    # Error response from daemon: No such container: nosuchcontainer

After this change:

    # make sure the image is present
    docker pull busybox
    docker create --volumes-from=nosuchcontainer busybox
    # Error response from daemon: No such container: nosuchcontainer

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2020-06-29 13:28:14 +02:00
..
cluster API: swarm: move PidsLimit to TaskTemplate.Resources 2020-06-05 12:50:38 +02:00
config
discovery
events
exec
graphdriver daemon: use containerd/sys to detect UserNamespaces 2020-06-15 13:06:08 +02:00
images
initlayer
links
listeners
logger Fixes #41010 skip empty lines 2020-06-06 12:36:50 +08:00
names
network
stats
testdata
apparmor_default.go
apparmor_default_unsupported.go
archive.go
archive_tarcopyoptions.go
archive_tarcopyoptions_unix.go
archive_tarcopyoptions_windows.go
archive_unix.go
archive_windows.go
attach.go
auth.go
changes.go
checkpoint.go
cluster.go
commit.go
configs.go
configs_linux.go
configs_unsupported.go
configs_windows.go
container.go
container_linux.go
container_operations.go Merge pull request #41020 from thaJeztah/fix_sandbox_cleanup 2020-06-05 09:55:54 -07:00
container_operations_unix.go Better selection of DNS server 2020-05-25 18:20:56 +02:00
container_operations_windows.go
container_unix_test.go
container_windows.go
create.go
create_test.go
create_unix.go
create_windows.go
daemon.go daemon: use containerd/sys to detect UserNamespaces 2020-06-15 13:06:08 +02:00
daemon_linux.go
daemon_linux_test.go
daemon_test.go
daemon_unix.go daemon: use containerd/sys to detect UserNamespaces 2020-06-15 13:06:08 +02:00
daemon_unix_test.go
daemon_unsupported.go
daemon_windows.go
daemon_windows_test.go
debugtrap_unix.go
debugtrap_unsupported.go
debugtrap_windows.go
delete.go
delete_test.go
dependency.go
devices_linux.go
disk_usage.go
errors.go
events.go
events_test.go
exec.go
exec_linux.go
exec_linux_test.go
exec_windows.go
export.go
health.go
health_test.go
info.go
info_test.go
info_unix.go
info_unix_test.go
info_windows.go
inspect.go
inspect_linux.go
inspect_test.go
inspect_windows.go
keys.go
keys_unsupported.go
kill.go
licensing.go
licensing_test.go
links.go
list.go
list_test.go
list_unix.go
list_windows.go
logdrivers_linux.go
logdrivers_windows.go
logs.go
logs_test.go
metrics.go
metrics_unix.go
metrics_unsupported.go
monitor.go
mounts.go
names.go
network.go
network_windows.go
nvidia_linux.go
oci_linux.go daemon: use containerd/sys to detect UserNamespaces 2020-06-15 13:06:08 +02:00
oci_linux_test.go Add default sysctls to allow ping sockets and privileged ports with no capabilities 2020-06-04 18:11:08 +01:00
oci_utils.go
oci_windows.go
oci_windows_test.go
pause.go
prune.go
reload.go
reload_test.go
reload_unix.go
reload_windows.go
rename.go
resize.go
resize_test.go
restart.go
seccomp_disabled.go
seccomp_linux.go
seccomp_unsupported.go
secrets.go
secrets_linux.go
secrets_unsupported.go
secrets_windows.go
selinux_linux.go
selinux_unsupported.go
start.go
start_unix.go
start_windows.go
stats.go
stats_collector.go
stats_unix.go
stats_windows.go
stop.go
top_unix.go
top_unix_test.go
top_windows.go
trustkey.go
trustkey_test.go
unpause.go
update.go
update_linux.go
update_windows.go
util_test.go
volumes.go Fix status code for missing --volumes-from container 2020-06-29 13:28:14 +02:00
volumes_linux.go
volumes_linux_test.go
volumes_unit_test.go
volumes_unix.go
volumes_unix_test.go
volumes_windows.go
wait.go
workdir.go