mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
3816b51438
In some circumstances we were not properly releasing plugin references, leading to failures in removing a plugin with no way to recover other than restarting the daemon. 1. If volume create fails (in the driver) 2. If a driver validation fails (should be rare) 3. If trying to get a plugin that does not match the passed in capability Ideally the test for 1 and 2 would just be a unit test, however the plugin interfaces are too complicated as `plugingetter` relies on github.com/pkg/plugin/Client (a concrete type), which will require spinning up services from within the unit test... it just wouldn't be a unit test at this point. I attempted to refactor this a bit, but since both libnetwork and swarmkit are reliant on `plugingetter` as well, this would not work. This really requires a re-write of the lower-level plugin management to decouple these pieces. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
64 lines
2 KiB
Go
64 lines
2 KiB
Go
package plugin
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/docker/docker/api/types"
|
|
"github.com/docker/docker/pkg/plugingetter"
|
|
"github.com/docker/docker/plugin/v2"
|
|
)
|
|
|
|
func TestFilterByCapNeg(t *testing.T) {
|
|
p := v2.Plugin{PluginObj: types.Plugin{Name: "test:latest"}}
|
|
iType := types.PluginInterfaceType{Capability: "volumedriver", Prefix: "docker", Version: "1.0"}
|
|
i := types.PluginConfigInterface{Socket: "plugins.sock", Types: []types.PluginInterfaceType{iType}}
|
|
p.PluginObj.Config.Interface = i
|
|
|
|
_, err := p.FilterByCap("foobar")
|
|
if err == nil {
|
|
t.Fatalf("expected inadequate error, got %v", err)
|
|
}
|
|
}
|
|
|
|
func TestFilterByCapPos(t *testing.T) {
|
|
p := v2.Plugin{PluginObj: types.Plugin{Name: "test:latest"}}
|
|
|
|
iType := types.PluginInterfaceType{Capability: "volumedriver", Prefix: "docker", Version: "1.0"}
|
|
i := types.PluginConfigInterface{Socket: "plugins.sock", Types: []types.PluginInterfaceType{iType}}
|
|
p.PluginObj.Config.Interface = i
|
|
|
|
_, err := p.FilterByCap("volumedriver")
|
|
if err != nil {
|
|
t.Fatalf("expected no error, got %v", err)
|
|
}
|
|
}
|
|
|
|
func TestStoreGetPluginNotMatchCapRefs(t *testing.T) {
|
|
s := NewStore()
|
|
p := v2.Plugin{PluginObj: types.Plugin{Name: "test:latest"}}
|
|
|
|
iType := types.PluginInterfaceType{Capability: "whatever", Prefix: "docker", Version: "1.0"}
|
|
i := types.PluginConfigInterface{Socket: "plugins.sock", Types: []types.PluginInterfaceType{iType}}
|
|
p.PluginObj.Config.Interface = i
|
|
|
|
if err := s.Add(&p); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if _, err := s.Get("test", "volumedriver", plugingetter.Acquire); err == nil {
|
|
t.Fatal("exepcted error when getting plugin that doesn't match the passed in capability")
|
|
}
|
|
|
|
if refs := p.GetRefCount(); refs != 0 {
|
|
t.Fatalf("reference count should be 0, got: %d", refs)
|
|
}
|
|
|
|
p.PluginObj.Enabled = true
|
|
if _, err := s.Get("test", "volumedriver", plugingetter.Acquire); err == nil {
|
|
t.Fatal("exepcted error when getting plugin that doesn't match the passed in capability")
|
|
}
|
|
|
|
if refs := p.GetRefCount(); refs != 0 {
|
|
t.Fatalf("reference count should be 0, got: %d", refs)
|
|
}
|
|
}
|