mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
08d01be870
integration-cli/docker_cli_pull_test.go:55:69: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_exec_test.go:46:64: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_service_health_test.go:86:65: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_api_images_test.go:128:66: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_api_swarm_node_test.go:79:69: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_health_test.go:51:57: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_health_test.go:159:73: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_swarm_unix_test.go:60:67: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_api_inspect_test.go:30:33: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_api_build_test.go:429:71: empty-lines: extra empty line at the start of a block (revive)
integration-cli/docker_cli_attach_unix_test.go:19:78: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_api_build_test.go:470:70: empty-lines: extra empty line at the start of a block (revive)
integration-cli/docker_cli_history_test.go:29:64: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_links_test.go:93:86: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_create_test.go:33:61: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_links_test.go:145:78: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_create_test.go:114:70: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_api_attach_test.go:226:153: empty-lines: extra empty line at the start of a block (revive)
integration-cli/docker_cli_by_digest_test.go:239:71: empty-lines: extra empty line at the start of a block (revive)
integration-cli/docker_cli_create_test.go:135:49: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_create_test.go:143:75: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_create_test.go:181:71: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_inspect_test.go:72:65: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_api_swarm_service_test.go:98:77: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_api_swarm_service_test.go:144:69: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_rmi_test.go:63:2: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_api_swarm_service_test.go:199:79: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_rmi_test.go:69:2: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_api_swarm_service_test.go:300:75: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_prune_unix_test.go:35:25: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_events_unix_test.go:393:60: empty-lines: extra empty line at the start of a block (revive)
integration-cli/docker_cli_events_unix_test.go:441:71: empty-lines: extra empty line at the start of a block (revive)
integration-cli/docker_cli_ps_test.go:33:67: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_ps_test.go:559:67: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_events_test.go:117:75: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_api_containers_test.go:547:74: empty-lines: extra empty line at the start of a block (revive)
integration-cli/docker_api_containers_test.go:1054:84: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_api_containers_test.go:1076:87: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_api_containers_test.go:1232:72: empty-lines: extra empty line at the start of a block (revive)
integration-cli/docker_api_containers_test.go:1801:21: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_network_unix_test.go:58:95: empty-lines: extra empty line at the start of a block (revive)
integration-cli/docker_cli_network_unix_test.go:750:75: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_network_unix_test.go:765:76: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_swarm_test.go:617:100: empty-lines: extra empty line at the start of a block (revive)
integration-cli/docker_cli_swarm_test.go:892:72: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_daemon_test.go:119:74: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_daemon_test.go:981:68: empty-lines: extra empty line at the start of a block (revive)
integration-cli/docker_cli_daemon_test.go:1951:87: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_run_test.go:83:66: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_run_test.go:357:72: empty-lines: extra empty line at the start of a block (revive)
integration-cli/docker_cli_build_test.go:89:83: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:114:83: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:183:80: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:290:71: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:314:65: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:331:67: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:366:76: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:403:67: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:648:67: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:708:72: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:938:66: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:1018:72: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:1097:2: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:1182:62: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:1244:66: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:1524:69: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:1546:80: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:1716:70: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:1730:65: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:2162:74: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:2270:71: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:2288:70: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:3206:65: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:3392:66: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:3433:72: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:3678:76: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:3732:67: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:3759:69: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:3802:61: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:3898:66: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:4107:9: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:4791:74: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:4821:73: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:4854:70: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:5341:74: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:5593:81: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_api_containers_test.go:2145:11: empty-lines: extra empty line at the start of a block (revive)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit dc0c2340b8
)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
177 lines
5.6 KiB
Go
177 lines
5.6 KiB
Go
package main
|
|
|
|
import (
|
|
"encoding/json"
|
|
"strconv"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/docker/docker/api/types"
|
|
"github.com/docker/docker/integration-cli/cli/build"
|
|
"gotest.tools/v3/assert"
|
|
)
|
|
|
|
type DockerCLIHealthSuite struct {
|
|
ds *DockerSuite
|
|
}
|
|
|
|
func (s *DockerCLIHealthSuite) TearDownTest(c *testing.T) {
|
|
s.ds.TearDownTest(c)
|
|
}
|
|
|
|
func (s *DockerCLIHealthSuite) OnTimeout(c *testing.T) {
|
|
s.ds.OnTimeout(c)
|
|
}
|
|
|
|
func waitForHealthStatus(c *testing.T, name string, prev string, expected string) {
|
|
prev = prev + "\n"
|
|
expected = expected + "\n"
|
|
for {
|
|
out, _ := dockerCmd(c, "inspect", "--format={{.State.Health.Status}}", name)
|
|
if out == expected {
|
|
return
|
|
}
|
|
assert.Equal(c, out, prev)
|
|
if out != prev {
|
|
return
|
|
}
|
|
time.Sleep(100 * time.Millisecond)
|
|
}
|
|
}
|
|
|
|
func getHealth(c *testing.T, name string) *types.Health {
|
|
out, _ := dockerCmd(c, "inspect", "--format={{json .State.Health}}", name)
|
|
var health types.Health
|
|
err := json.Unmarshal([]byte(out), &health)
|
|
assert.Equal(c, err, nil)
|
|
return &health
|
|
}
|
|
|
|
func (s *DockerCLIHealthSuite) TestHealth(c *testing.T) {
|
|
testRequires(c, DaemonIsLinux) // busybox doesn't work on Windows
|
|
|
|
existingContainers := ExistingContainerIDs(c)
|
|
|
|
imageName := "testhealth"
|
|
buildImageSuccessfully(c, imageName, build.WithDockerfile(`FROM busybox
|
|
RUN echo OK > /status
|
|
CMD ["/bin/sleep", "120"]
|
|
STOPSIGNAL SIGKILL
|
|
HEALTHCHECK --interval=1s --timeout=30s \
|
|
CMD cat /status`))
|
|
|
|
// No health status before starting
|
|
name := "test_health"
|
|
cid, _ := dockerCmd(c, "create", "--name", name, imageName)
|
|
out, _ := dockerCmd(c, "ps", "-a", "--format={{.ID}} {{.Status}}")
|
|
out = RemoveOutputForExistingElements(out, existingContainers)
|
|
assert.Equal(c, out, cid[:12]+" Created\n")
|
|
|
|
// Inspect the options
|
|
out, _ = dockerCmd(c, "inspect",
|
|
"--format=timeout={{.Config.Healthcheck.Timeout}} interval={{.Config.Healthcheck.Interval}} retries={{.Config.Healthcheck.Retries}} test={{.Config.Healthcheck.Test}}", name)
|
|
assert.Equal(c, out, "timeout=30s interval=1s retries=0 test=[CMD-SHELL cat /status]\n")
|
|
|
|
// Start
|
|
dockerCmd(c, "start", name)
|
|
waitForHealthStatus(c, name, "starting", "healthy")
|
|
|
|
// Make it fail
|
|
dockerCmd(c, "exec", name, "rm", "/status")
|
|
waitForHealthStatus(c, name, "healthy", "unhealthy")
|
|
|
|
// Inspect the status
|
|
out, _ = dockerCmd(c, "inspect", "--format={{.State.Health.Status}}", name)
|
|
assert.Equal(c, out, "unhealthy\n")
|
|
|
|
// Make it healthy again
|
|
dockerCmd(c, "exec", name, "touch", "/status")
|
|
waitForHealthStatus(c, name, "unhealthy", "healthy")
|
|
|
|
// Remove container
|
|
dockerCmd(c, "rm", "-f", name)
|
|
|
|
// Disable the check from the CLI
|
|
dockerCmd(c, "create", "--name=noh", "--no-healthcheck", imageName)
|
|
out, _ = dockerCmd(c, "inspect", "--format={{.Config.Healthcheck.Test}}", "noh")
|
|
assert.Equal(c, out, "[NONE]\n")
|
|
dockerCmd(c, "rm", "noh")
|
|
|
|
// Disable the check with a new build
|
|
buildImageSuccessfully(c, "no_healthcheck", build.WithDockerfile(`FROM testhealth
|
|
HEALTHCHECK NONE`))
|
|
|
|
out, _ = dockerCmd(c, "inspect", "--format={{.Config.Healthcheck.Test}}", "no_healthcheck")
|
|
assert.Equal(c, out, "[NONE]\n")
|
|
|
|
// Enable the checks from the CLI
|
|
_, _ = dockerCmd(c, "run", "-d", "--name=fatal_healthcheck",
|
|
"--health-interval=1s",
|
|
"--health-retries=3",
|
|
"--health-cmd=cat /status",
|
|
"no_healthcheck")
|
|
waitForHealthStatus(c, "fatal_healthcheck", "starting", "healthy")
|
|
health := getHealth(c, "fatal_healthcheck")
|
|
assert.Equal(c, health.Status, "healthy")
|
|
assert.Equal(c, health.FailingStreak, 0)
|
|
last := health.Log[len(health.Log)-1]
|
|
assert.Equal(c, last.ExitCode, 0)
|
|
assert.Equal(c, last.Output, "OK\n")
|
|
|
|
// Fail the check
|
|
dockerCmd(c, "exec", "fatal_healthcheck", "rm", "/status")
|
|
waitForHealthStatus(c, "fatal_healthcheck", "healthy", "unhealthy")
|
|
|
|
failsStr, _ := dockerCmd(c, "inspect", "--format={{.State.Health.FailingStreak}}", "fatal_healthcheck")
|
|
fails, err := strconv.Atoi(strings.TrimSpace(failsStr))
|
|
assert.Assert(c, err == nil)
|
|
assert.Equal(c, fails >= 3, true)
|
|
dockerCmd(c, "rm", "-f", "fatal_healthcheck")
|
|
|
|
// Check timeout
|
|
// Note: if the interval is too small, it seems that Docker spends all its time running health
|
|
// checks and never gets around to killing it.
|
|
_, _ = dockerCmd(c, "run", "-d", "--name=test",
|
|
"--health-interval=1s", "--health-cmd=sleep 5m", "--health-timeout=1s", imageName)
|
|
waitForHealthStatus(c, "test", "starting", "unhealthy")
|
|
health = getHealth(c, "test")
|
|
last = health.Log[len(health.Log)-1]
|
|
assert.Equal(c, health.Status, "unhealthy")
|
|
assert.Equal(c, last.ExitCode, -1)
|
|
assert.Equal(c, last.Output, "Health check exceeded timeout (1s)")
|
|
dockerCmd(c, "rm", "-f", "test")
|
|
|
|
// Check JSON-format
|
|
buildImageSuccessfully(c, imageName, build.WithDockerfile(`FROM busybox
|
|
RUN echo OK > /status
|
|
CMD ["/bin/sleep", "120"]
|
|
STOPSIGNAL SIGKILL
|
|
HEALTHCHECK --interval=1s --timeout=30s \
|
|
CMD ["cat", "/my status"]`))
|
|
out, _ = dockerCmd(c, "inspect",
|
|
"--format={{.Config.Healthcheck.Test}}", imageName)
|
|
assert.Equal(c, out, "[CMD cat /my status]\n")
|
|
}
|
|
|
|
// GitHub #33021
|
|
func (s *DockerCLIHealthSuite) TestUnsetEnvVarHealthCheck(c *testing.T) {
|
|
testRequires(c, DaemonIsLinux) // busybox doesn't work on Windows
|
|
|
|
imageName := "testhealth"
|
|
buildImageSuccessfully(c, imageName, build.WithDockerfile(`FROM busybox
|
|
HEALTHCHECK --interval=1s --timeout=5s --retries=5 CMD /bin/sh -c "sleep 1"
|
|
ENTRYPOINT /bin/sh -c "sleep 600"`))
|
|
|
|
name := "env_test_health"
|
|
// No health status before starting
|
|
dockerCmd(c, "run", "-d", "--name", name, "-e", "FOO", imageName)
|
|
defer func() {
|
|
dockerCmd(c, "rm", "-f", name)
|
|
dockerCmd(c, "rmi", imageName)
|
|
}()
|
|
|
|
// Start
|
|
dockerCmd(c, "start", name)
|
|
waitForHealthStatus(c, name, "starting", "healthy")
|
|
}
|