mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
4eb2fd169f
daemon/volumes.go This SetFileCon call made no sense, it was changing the labels of any directory mounted into the containers SELinux label. If it came from me, then I apologize since it is a huge bug. The Volumes Mount code should optionally do this, but it should not always happen, and should never happen on a --privileged container. The change to daemon/graphdriver/vfs/driver.go, is a simplification since this it not a relabel, it is only a setting of the shared label for docker volumes. Docker-DCO-1.1-Signed-off-by: Dan Walsh <dwalsh@redhat.com> (github: rhatdan)
95 lines
1.8 KiB
Go
95 lines
1.8 KiB
Go
package vfs
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"path"
|
|
|
|
"github.com/docker/docker/daemon/graphdriver"
|
|
"github.com/docker/docker/pkg/chrootarchive"
|
|
"github.com/docker/libcontainer/label"
|
|
)
|
|
|
|
func init() {
|
|
graphdriver.Register("vfs", Init)
|
|
}
|
|
|
|
func Init(home string, options []string) (graphdriver.Driver, error) {
|
|
d := &Driver{
|
|
home: home,
|
|
}
|
|
return graphdriver.NaiveDiffDriver(d), nil
|
|
}
|
|
|
|
type Driver struct {
|
|
home string
|
|
}
|
|
|
|
func (d *Driver) String() string {
|
|
return "vfs"
|
|
}
|
|
|
|
func (d *Driver) Status() [][2]string {
|
|
return nil
|
|
}
|
|
|
|
func (d *Driver) Cleanup() error {
|
|
return nil
|
|
}
|
|
|
|
func (d *Driver) Create(id, parent string) error {
|
|
dir := d.dir(id)
|
|
if err := os.MkdirAll(path.Dir(dir), 0700); err != nil {
|
|
return err
|
|
}
|
|
if err := os.Mkdir(dir, 0755); err != nil {
|
|
return err
|
|
}
|
|
opts := []string{"level:s0"}
|
|
if _, mountLabel, err := label.InitLabels(opts); err == nil {
|
|
label.SetFileLabel(dir, mountLabel)
|
|
}
|
|
if parent == "" {
|
|
return nil
|
|
}
|
|
parentDir, err := d.Get(parent, "")
|
|
if err != nil {
|
|
return fmt.Errorf("%s: %s", parent, err)
|
|
}
|
|
if err := chrootarchive.CopyWithTar(parentDir, dir); err != nil {
|
|
return err
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (d *Driver) dir(id string) string {
|
|
return path.Join(d.home, "dir", path.Base(id))
|
|
}
|
|
|
|
func (d *Driver) Remove(id string) error {
|
|
if _, err := os.Stat(d.dir(id)); err != nil {
|
|
return err
|
|
}
|
|
return os.RemoveAll(d.dir(id))
|
|
}
|
|
|
|
func (d *Driver) Get(id, mountLabel string) (string, error) {
|
|
dir := d.dir(id)
|
|
if st, err := os.Stat(dir); err != nil {
|
|
return "", err
|
|
} else if !st.IsDir() {
|
|
return "", fmt.Errorf("%s: not a directory", dir)
|
|
}
|
|
return dir, nil
|
|
}
|
|
|
|
func (d *Driver) Put(id string) error {
|
|
// The vfs driver has no runtime resources (e.g. mounts)
|
|
// to clean up, so we don't need anything here
|
|
return nil
|
|
}
|
|
|
|
func (d *Driver) Exists(id string) bool {
|
|
_, err := os.Stat(d.dir(id))
|
|
return err == nil
|
|
}
|