mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
9a2d0bc3ad
Fixes #22564 When an error occurs on mount, there should not be any call later to unmount. This can throw off refcounting in the underlying driver unexpectedly. Consider these two cases: ``` $ docker run -v foo:/bar busybox true ``` ``` $ docker run -v foo:/bar -w /foo busybox true ``` In the first case, if mounting `foo` fails, the volume driver will not get a call to unmount (this is the incorrect behavior). In the second case, the volume driver will not get a call to unmount (correct behavior). This occurs because in the first case, `/bar` does not exist in the container, and as such there is no call to `volume.Mount()` during the `create` phase. It will error out during the `start` phase. In the second case `/bar` is created before dealing with the volume because of the `-w`. Because of this, when the volume is being setup docker will try to copy the image path contents in the volume, in which case it will attempt to mount the volume and fail. This happens during the `create` phase. This makes it so the container will not be created (or at least fully created) and the user gets the error on `create` instead of `start`. The error handling is different in these two phases. Changed to only send `unmount` if the volume is mounted. While investigating the cause of the reported issue I found some odd behavior in unmount calls so I've cleaned those up a bit here as well. Signed-off-by: Brian Goff <cpuguy83@gmail.com> |
||
|---|---|---|
| .. | ||
| drivers | ||
| local | ||
| store | ||
| testutils | ||
| validate.go | ||
| validate_test.go | ||
| validate_test_unix.go | ||
| validate_test_windows.go | ||
| volume.go | ||
| volume_copy.go | ||
| volume_copy_unix.go | ||
| volume_copy_windows.go | ||
| volume_linux.go | ||
| volume_linux_test.go | ||
| volume_propagation_linux.go | ||
| volume_propagation_linux_test.go | ||
| volume_propagation_unsupported.go | ||
| volume_test.go | ||
| volume_unix.go | ||
| volume_unsupported.go | ||
| volume_windows.go | ||