1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
moby--moby/builder
Aaron Lehmann 6052f2b396 Remove pkg/testutil/assert in favor of testify
I noticed that we're using a homegrown package for assertions. The
functions are extremely similar to testify, but with enough slight
differences to be confusing (for example, Equal takes its arguments in a
different order). We already vendor testify, and it's used in a few
places by tests.

I also found some problems with pkg/testutil/assert. For example, the
NotNil function seems to be broken. It checks the argument against
"nil", which only works for an interface. If you pass in a nil map or
slice, the equality check will fail.

In the interest of avoiding NIH, I'm proposing replacing
pkg/testutil/assert with testify. The test code looks almost the same,
but we avoid the confusion of having two similar but slightly different
assertion packages, and having to maintain our own package instead of
using a commonly-used one.

In the process, I found a few places where the tests should halt if an
assertion fails, so I've made those cases (that I noticed) use "require"
instead of "assert", and I've vendored the "require" package from
testify alongside the already-present "assert" package.

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
2017-04-14 12:03:21 -07:00
..
dockerfile Remove pkg/testutil/assert in favor of testify 2017-04-14 12:03:21 -07:00
dockerignore use t.Fatal() to output the err message where the values used for formatting 2017-02-23 10:16:22 +08:00
remotecontext Fix relative path on windows for uuid paths 2017-03-23 15:12:19 -07:00
builder.go Add support for COPY from previous rootfs 2017-03-23 15:12:15 -07:00
dockerignore.go add defer file.Close to avoid potential fd leak 2016-08-10 08:36:09 +08:00
dockerignore_test.go Builder unit tests refactoring 2016-05-03 19:00:35 +02:00
git.go utils: move git functions to pkg/gitutils 2015-12-14 14:59:52 +01:00
remote.go Fixes work of inspectResponse in case of ContentLength=-1 2017-01-29 20:48:07 +02:00
remote_test.go use t.Fatal() to output the err message where the values used for formatting 2017-02-23 10:16:22 +08:00
tarsum.go Clean up tmp files for interrupted docker build 2016-12-16 21:11:53 -08:00
tarsum_test.go use t.Fatal() to output the err message where the values used for formatting 2017-02-23 10:16:22 +08:00
utils_test.go Move builder cli helper functions to own pkg 2016-12-26 18:53:22 -08:00