mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
5479df79c7
As of now promoting (or demoting) a node that has its role left unchanged will always print a successful message. This PR fixes the issue by matching the behavior on swarmkit's swarmctl command and printing a message when desired role is the current role of the node. As a result this also avoids calling update when it is not necessary. Signed-off-by: Alexandre Beslic <alexandre.beslic@gmail.com>
36 lines
1,008 B
Go
36 lines
1,008 B
Go
package node
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/docker/docker/api/client"
|
|
"github.com/docker/docker/cli"
|
|
"github.com/docker/engine-api/types/swarm"
|
|
"github.com/spf13/cobra"
|
|
)
|
|
|
|
func newPromoteCommand(dockerCli *client.DockerCli) *cobra.Command {
|
|
return &cobra.Command{
|
|
Use: "promote NODE [NODE...]",
|
|
Short: "Promote one or more nodes to manager in the swarm",
|
|
Args: cli.RequiresMinArgs(1),
|
|
RunE: func(cmd *cobra.Command, args []string) error {
|
|
return runPromote(dockerCli, args)
|
|
},
|
|
}
|
|
}
|
|
|
|
func runPromote(dockerCli *client.DockerCli, nodes []string) error {
|
|
promote := func(node *swarm.Node) error {
|
|
if node.Spec.Role == swarm.NodeRoleManager {
|
|
fmt.Fprintf(dockerCli.Out(), "Node %s is already a manager.\n", node.ID)
|
|
return errNoRoleChange
|
|
}
|
|
node.Spec.Role = swarm.NodeRoleManager
|
|
return nil
|
|
}
|
|
success := func(nodeID string) {
|
|
fmt.Fprintf(dockerCli.Out(), "Node %s promoted to a manager in the swarm.\n", nodeID)
|
|
}
|
|
return updateNodes(dockerCli, nodes, promote, success)
|
|
}
|