mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
0abb8dec3f
Support for running overlay/overlay2 on a backing filesystem
without d_type support (most likely: xfs, as ext4 supports
this by default), was deprecated for some time.
Running without d_type support is problematic, and can
lead to difficult to debug issues ("invalid argument" errors,
or unable to remove files from the container's filesystem).
This patch turns the warning that was previously printed
into an "unsupported" error, so that the overlay/overlay2
drivers are not automatically selected when detecting supported
storage drivers.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
20 lines
616 B
Go
20 lines
616 B
Go
// +build linux
|
|
|
|
package overlayutils
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/docker/docker/daemon/graphdriver"
|
|
)
|
|
|
|
// ErrDTypeNotSupported denotes that the backing filesystem doesn't support d_type.
|
|
func ErrDTypeNotSupported(driver, backingFs string) error {
|
|
msg := fmt.Sprintf("%s: the backing %s filesystem is formatted without d_type support, which leads to incorrect behavior.", driver, backingFs)
|
|
if backingFs == "xfs" {
|
|
msg += " Reformat the filesystem with ftype=1 to enable d_type support."
|
|
}
|
|
msg += " Backing filesystems without d_type support are not supported."
|
|
|
|
return graphdriver.NotSupportedError(msg)
|
|
}
|