mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
a01c4dc8f8
Currently the default seccomp profile is fixed. This changes it so that it varies depending on the Linux capabilities selected with the --cap-add and --cap-drop options. Without this, if a user adds privileges, eg to allow ptrace with --cap-add sys_ptrace then still cannot actually use ptrace as it is still blocked by seccomp, so they will probably disable seccomp or use --privileged. With this change the syscalls that are needed for the capability are also allowed by the seccomp profile based on the selected capabilities. While this patch makes it easier to do things with for example cap_sys_admin enabled, as it will now allow creating new namespaces and use of mount, it still allows less than --cap-add cap_sys_admin --security-opt seccomp:unconfined would have previously. It is not recommended that users run containers with cap_sys_admin as this does give full access to the host machine. It also cleans up some architecture specific system calls to be only selected when needed. Signed-off-by: Justin Cormack <justin.cormack@docker.com>
74 lines
1.9 KiB
Go
74 lines
1.9 KiB
Go
// +build linux
|
|
|
|
package seccomp
|
|
|
|
import (
|
|
"encoding/json"
|
|
"fmt"
|
|
|
|
"github.com/docker/engine-api/types"
|
|
"github.com/opencontainers/specs/specs-go"
|
|
)
|
|
|
|
//go:generate go run -tags 'seccomp' generate.go
|
|
|
|
// GetDefaultProfile returns the default seccomp profile.
|
|
func GetDefaultProfile(rs *specs.Spec) (*specs.Seccomp, error) {
|
|
return setupSeccomp(DefaultProfile(rs))
|
|
}
|
|
|
|
// LoadProfile takes a file path and decodes the seccomp profile.
|
|
func LoadProfile(body string) (*specs.Seccomp, error) {
|
|
var config types.Seccomp
|
|
if err := json.Unmarshal([]byte(body), &config); err != nil {
|
|
return nil, fmt.Errorf("Decoding seccomp profile failed: %v", err)
|
|
}
|
|
|
|
return setupSeccomp(&config)
|
|
}
|
|
|
|
func setupSeccomp(config *types.Seccomp) (newConfig *specs.Seccomp, err error) {
|
|
if config == nil {
|
|
return nil, nil
|
|
}
|
|
|
|
// No default action specified, no syscalls listed, assume seccomp disabled
|
|
if config.DefaultAction == "" && len(config.Syscalls) == 0 {
|
|
return nil, nil
|
|
}
|
|
|
|
newConfig = &specs.Seccomp{}
|
|
|
|
// if config.Architectures == 0 then libseccomp will figure out the architecture to use
|
|
if len(config.Architectures) > 0 {
|
|
for _, arch := range config.Architectures {
|
|
newConfig.Architectures = append(newConfig.Architectures, specs.Arch(arch))
|
|
}
|
|
}
|
|
|
|
newConfig.DefaultAction = specs.Action(config.DefaultAction)
|
|
|
|
// Loop through all syscall blocks and convert them to libcontainer format
|
|
for _, call := range config.Syscalls {
|
|
newCall := specs.Syscall{
|
|
Name: call.Name,
|
|
Action: specs.Action(call.Action),
|
|
}
|
|
|
|
// Loop through all the arguments of the syscall and convert them
|
|
for _, arg := range call.Args {
|
|
newArg := specs.Arg{
|
|
Index: arg.Index,
|
|
Value: arg.Value,
|
|
ValueTwo: arg.ValueTwo,
|
|
Op: specs.Operator(arg.Op),
|
|
}
|
|
|
|
newCall.Args = append(newCall.Args, newArg)
|
|
}
|
|
|
|
newConfig.Syscalls = append(newConfig.Syscalls, newCall)
|
|
}
|
|
|
|
return newConfig, nil
|
|
}
|