mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
54240f8da9
- The build-time variables are passed as environment-context for command(s) run as part of the RUN primitve. These variables are not persisted in environment of intermediate and final images when passed as context for RUN. The build environment is prepended to the intermediate continer's command string for aiding cache lookups. It also helps with build traceability. But this also makes the feature less secure from point of view of passing build time secrets. - The build-time variables also get used to expand the symbols used in certain Dockerfile primitves like ADD, COPY, USER etc, without an explicit prior definiton using a ENV primitive. These variables get persisted in the intermediate and final images whenever they are expanded. - The build-time variables are only expanded or passed to the RUN primtive if they are defined in Dockerfile using the ARG primitive or belong to list of built-in variables. HTTP_PROXY, HTTPS_PROXY, http_proxy, https_proxy, FTP_PROXY and NO_PROXY are built-in variables that needn't be explicitly defined in Dockerfile to use this feature. Signed-off-by: Madhav Puri <madhav.puri@gmail.com>
145 lines
4 KiB
Go
145 lines
4 KiB
Go
// Package parser implements a parser and parse tree dumper for Dockerfiles.
|
|
package parser
|
|
|
|
import (
|
|
"bufio"
|
|
"io"
|
|
"regexp"
|
|
"strings"
|
|
"unicode"
|
|
|
|
"github.com/docker/docker/builder/command"
|
|
)
|
|
|
|
// Node is a structure used to represent a parse tree.
|
|
//
|
|
// In the node there are three fields, Value, Next, and Children. Value is the
|
|
// current token's string value. Next is always the next non-child token, and
|
|
// children contains all the children. Here's an example:
|
|
//
|
|
// (value next (child child-next child-next-next) next-next)
|
|
//
|
|
// This data structure is frankly pretty lousy for handling complex languages,
|
|
// but lucky for us the Dockerfile isn't very complicated. This structure
|
|
// works a little more effectively than a "proper" parse tree for our needs.
|
|
//
|
|
type Node struct {
|
|
Value string // actual content
|
|
Next *Node // the next item in the current sexp
|
|
Children []*Node // the children of this sexp
|
|
Attributes map[string]bool // special attributes for this node
|
|
Original string // original line used before parsing
|
|
Flags []string // only top Node should have this set
|
|
}
|
|
|
|
var (
|
|
dispatch map[string]func(string) (*Node, map[string]bool, error)
|
|
tokenWhitespace = regexp.MustCompile(`[\t\v\f\r ]+`)
|
|
tokenLineContinuation = regexp.MustCompile(`\\[ \t]*$`)
|
|
tokenComment = regexp.MustCompile(`^#.*$`)
|
|
)
|
|
|
|
func init() {
|
|
// Dispatch Table. see line_parsers.go for the parse functions.
|
|
// The command is parsed and mapped to the line parser. The line parser
|
|
// receives the arguments but not the command, and returns an AST after
|
|
// reformulating the arguments according to the rules in the parser
|
|
// functions. Errors are propagated up by Parse() and the resulting AST can
|
|
// be incorporated directly into the existing AST as a next.
|
|
dispatch = map[string]func(string) (*Node, map[string]bool, error){
|
|
command.User: parseString,
|
|
command.Onbuild: parseSubCommand,
|
|
command.Workdir: parseString,
|
|
command.Env: parseEnv,
|
|
command.Label: parseLabel,
|
|
command.Maintainer: parseString,
|
|
command.From: parseString,
|
|
command.Add: parseMaybeJSONToList,
|
|
command.Copy: parseMaybeJSONToList,
|
|
command.Run: parseMaybeJSON,
|
|
command.Cmd: parseMaybeJSON,
|
|
command.Entrypoint: parseMaybeJSON,
|
|
command.Expose: parseStringsWhitespaceDelimited,
|
|
command.Volume: parseMaybeJSONToList,
|
|
command.StopSignal: parseString,
|
|
command.Arg: parseNameOrNameVal,
|
|
}
|
|
}
|
|
|
|
// parse a line and return the remainder.
|
|
func parseLine(line string) (string, *Node, error) {
|
|
if line = stripComments(line); line == "" {
|
|
return "", nil, nil
|
|
}
|
|
|
|
if tokenLineContinuation.MatchString(line) {
|
|
line = tokenLineContinuation.ReplaceAllString(line, "")
|
|
return line, nil, nil
|
|
}
|
|
|
|
cmd, flags, args, err := splitCommand(line)
|
|
if err != nil {
|
|
return "", nil, err
|
|
}
|
|
|
|
node := &Node{}
|
|
node.Value = cmd
|
|
|
|
sexp, attrs, err := fullDispatch(cmd, args)
|
|
if err != nil {
|
|
return "", nil, err
|
|
}
|
|
|
|
node.Next = sexp
|
|
node.Attributes = attrs
|
|
node.Original = line
|
|
node.Flags = flags
|
|
|
|
return "", node, nil
|
|
}
|
|
|
|
// Parse is the main parse routine.
|
|
// It handles an io.ReadWriteCloser and returns the root of the AST.
|
|
func Parse(rwc io.Reader) (*Node, error) {
|
|
root := &Node{}
|
|
scanner := bufio.NewScanner(rwc)
|
|
|
|
for scanner.Scan() {
|
|
scannedLine := strings.TrimLeftFunc(scanner.Text(), unicode.IsSpace)
|
|
line, child, err := parseLine(scannedLine)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if line != "" && child == nil {
|
|
for scanner.Scan() {
|
|
newline := scanner.Text()
|
|
|
|
if stripComments(strings.TrimSpace(newline)) == "" {
|
|
continue
|
|
}
|
|
|
|
line, child, err = parseLine(line + newline)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if child != nil {
|
|
break
|
|
}
|
|
}
|
|
if child == nil && line != "" {
|
|
line, child, err = parseLine(line)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
}
|
|
|
|
if child != nil {
|
|
root.Children = append(root.Children, child)
|
|
}
|
|
}
|
|
|
|
return root, nil
|
|
}
|