mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
54240f8da9
- The build-time variables are passed as environment-context for command(s) run as part of the RUN primitve. These variables are not persisted in environment of intermediate and final images when passed as context for RUN. The build environment is prepended to the intermediate continer's command string for aiding cache lookups. It also helps with build traceability. But this also makes the feature less secure from point of view of passing build time secrets. - The build-time variables also get used to expand the symbols used in certain Dockerfile primitves like ADD, COPY, USER etc, without an explicit prior definiton using a ENV primitive. These variables get persisted in the intermediate and final images whenever they are expanded. - The build-time variables are only expanded or passed to the RUN primtive if they are defined in Dockerfile using the ARG primitive or belong to list of built-in variables. HTTP_PROXY, HTTPS_PROXY, http_proxy, https_proxy, FTP_PROXY and NO_PROXY are built-in variables that needn't be explicitly defined in Dockerfile to use this feature. Signed-off-by: Madhav Puri <madhav.puri@gmail.com>
112 lines
2.3 KiB
Go
112 lines
2.3 KiB
Go
package parser
|
|
|
|
import (
|
|
"fmt"
|
|
"io/ioutil"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
)
|
|
|
|
const testDir = "testfiles"
|
|
const negativeTestDir = "testfiles-negative"
|
|
|
|
func getDirs(t *testing.T, dir string) []string {
|
|
f, err := os.Open(dir)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
defer f.Close()
|
|
|
|
dirs, err := f.Readdirnames(0)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
return dirs
|
|
}
|
|
|
|
func TestTestNegative(t *testing.T) {
|
|
for _, dir := range getDirs(t, negativeTestDir) {
|
|
dockerfile := filepath.Join(negativeTestDir, dir, "Dockerfile")
|
|
|
|
df, err := os.Open(dockerfile)
|
|
if err != nil {
|
|
t.Fatalf("Dockerfile missing for %s: %v", dir, err)
|
|
}
|
|
|
|
_, err = Parse(df)
|
|
if err == nil {
|
|
t.Fatalf("No error parsing broken dockerfile for %s", dir)
|
|
}
|
|
|
|
df.Close()
|
|
}
|
|
}
|
|
|
|
func TestTestData(t *testing.T) {
|
|
for _, dir := range getDirs(t, testDir) {
|
|
dockerfile := filepath.Join(testDir, dir, "Dockerfile")
|
|
resultfile := filepath.Join(testDir, dir, "result")
|
|
|
|
df, err := os.Open(dockerfile)
|
|
if err != nil {
|
|
t.Fatalf("Dockerfile missing for %s: %v", dir, err)
|
|
}
|
|
defer df.Close()
|
|
|
|
ast, err := Parse(df)
|
|
if err != nil {
|
|
t.Fatalf("Error parsing %s's dockerfile: %v", dir, err)
|
|
}
|
|
|
|
content, err := ioutil.ReadFile(resultfile)
|
|
if err != nil {
|
|
t.Fatalf("Error reading %s's result file: %v", dir, err)
|
|
}
|
|
|
|
if ast.Dump()+"\n" != string(content) {
|
|
fmt.Fprintln(os.Stderr, "Result:\n"+ast.Dump())
|
|
fmt.Fprintln(os.Stderr, "Expected:\n"+string(content))
|
|
t.Fatalf("%s: AST dump of dockerfile does not match result", dir)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestParseWords(t *testing.T) {
|
|
tests := []map[string][]string{
|
|
{
|
|
"input": {"foo"},
|
|
"expect": {"foo"},
|
|
},
|
|
{
|
|
"input": {"foo bar"},
|
|
"expect": {"foo", "bar"},
|
|
},
|
|
{
|
|
"input": {"foo=bar"},
|
|
"expect": {"foo=bar"},
|
|
},
|
|
{
|
|
"input": {"foo bar 'abc xyz'"},
|
|
"expect": {"foo", "bar", "'abc xyz'"},
|
|
},
|
|
{
|
|
"input": {`foo bar "abc xyz"`},
|
|
"expect": {"foo", "bar", `"abc xyz"`},
|
|
},
|
|
}
|
|
|
|
for _, test := range tests {
|
|
words := parseWords(test["input"][0])
|
|
if len(words) != len(test["expect"]) {
|
|
t.Fatalf("length check failed. input: %v, expect: %v, output: %v", test["input"][0], test["expect"], words)
|
|
}
|
|
for i, word := range words {
|
|
if word != test["expect"][i] {
|
|
t.Fatalf("word check failed for word: %q. input: %v, expect: %v, output: %v", word, test["input"][0], test["expect"], words)
|
|
}
|
|
}
|
|
}
|
|
}
|