mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
3ade7ca12b
Line 59: warning: context.Context should be the first parameter of a function (golint)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 9f9b4290b9)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
215 lines
8.1 KiB
Go
215 lines
8.1 KiB
Go
package container // import "github.com/docker/docker/integration/container"
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/docker/docker/api/types"
|
|
containertypes "github.com/docker/docker/api/types/container"
|
|
"github.com/docker/docker/api/types/network"
|
|
"github.com/docker/docker/api/types/versions"
|
|
"github.com/docker/docker/integration/internal/container"
|
|
"github.com/docker/docker/pkg/stringid"
|
|
"gotest.tools/assert"
|
|
is "gotest.tools/assert/cmp"
|
|
"gotest.tools/poll"
|
|
"gotest.tools/skip"
|
|
)
|
|
|
|
// This test simulates the scenario mentioned in #31392:
|
|
// Having two linked container, renaming the target and bringing a replacement
|
|
// and then deleting and recreating the source container linked to the new target.
|
|
// This checks that "rename" updates source container correctly and doesn't set it to null.
|
|
func TestRenameLinkedContainer(t *testing.T) {
|
|
skip.If(t, versions.LessThan(testEnv.DaemonAPIVersion(), "1.32"), "broken in earlier versions")
|
|
skip.If(t, testEnv.OSType == "windows", "FIXME")
|
|
defer setupTest(t)()
|
|
ctx := context.Background()
|
|
client := testEnv.APIClient()
|
|
|
|
aName := "a0" + t.Name()
|
|
bName := "b0" + t.Name()
|
|
aID := container.Run(ctx, t, client, container.WithName(aName))
|
|
bID := container.Run(ctx, t, client, container.WithName(bName), container.WithLinks(aName))
|
|
|
|
err := client.ContainerRename(ctx, aID, "a1"+t.Name())
|
|
assert.NilError(t, err)
|
|
|
|
container.Run(ctx, t, client, container.WithName(aName))
|
|
|
|
err = client.ContainerRemove(ctx, bID, types.ContainerRemoveOptions{Force: true})
|
|
assert.NilError(t, err)
|
|
|
|
bID = container.Run(ctx, t, client, container.WithName(bName), container.WithLinks(aName))
|
|
|
|
inspect, err := client.ContainerInspect(ctx, bID)
|
|
assert.NilError(t, err)
|
|
assert.Check(t, is.DeepEqual([]string{"/" + aName + ":/" + bName + "/" + aName}, inspect.HostConfig.Links))
|
|
}
|
|
|
|
func TestRenameStoppedContainer(t *testing.T) {
|
|
defer setupTest(t)()
|
|
ctx := context.Background()
|
|
client := testEnv.APIClient()
|
|
|
|
oldName := "first_name" + t.Name()
|
|
cID := container.Run(ctx, t, client, container.WithName(oldName), container.WithCmd("sh"))
|
|
poll.WaitOn(t, container.IsInState(ctx, client, cID, "exited"), poll.WithDelay(100*time.Millisecond))
|
|
|
|
inspect, err := client.ContainerInspect(ctx, cID)
|
|
assert.NilError(t, err)
|
|
assert.Check(t, is.Equal("/"+oldName, inspect.Name))
|
|
|
|
newName := "new_name" + stringid.GenerateRandomID()
|
|
err = client.ContainerRename(ctx, oldName, newName)
|
|
assert.NilError(t, err)
|
|
|
|
inspect, err = client.ContainerInspect(ctx, cID)
|
|
assert.NilError(t, err)
|
|
assert.Check(t, is.Equal("/"+newName, inspect.Name))
|
|
}
|
|
|
|
func TestRenameRunningContainerAndReuse(t *testing.T) {
|
|
defer setupTest(t)()
|
|
ctx := context.Background()
|
|
client := testEnv.APIClient()
|
|
|
|
oldName := "first_name" + t.Name()
|
|
cID := container.Run(ctx, t, client, container.WithName(oldName))
|
|
poll.WaitOn(t, container.IsInState(ctx, client, cID, "running"), poll.WithDelay(100*time.Millisecond))
|
|
|
|
newName := "new_name" + stringid.GenerateRandomID()
|
|
err := client.ContainerRename(ctx, oldName, newName)
|
|
assert.NilError(t, err)
|
|
|
|
inspect, err := client.ContainerInspect(ctx, cID)
|
|
assert.NilError(t, err)
|
|
assert.Check(t, is.Equal("/"+newName, inspect.Name))
|
|
|
|
_, err = client.ContainerInspect(ctx, oldName)
|
|
assert.Check(t, is.ErrorContains(err, "No such container: "+oldName))
|
|
|
|
cID = container.Run(ctx, t, client, container.WithName(oldName))
|
|
poll.WaitOn(t, container.IsInState(ctx, client, cID, "running"), poll.WithDelay(100*time.Millisecond))
|
|
|
|
inspect, err = client.ContainerInspect(ctx, cID)
|
|
assert.NilError(t, err)
|
|
assert.Check(t, is.Equal("/"+oldName, inspect.Name))
|
|
}
|
|
|
|
func TestRenameInvalidName(t *testing.T) {
|
|
defer setupTest(t)()
|
|
ctx := context.Background()
|
|
client := testEnv.APIClient()
|
|
|
|
oldName := "first_name" + t.Name()
|
|
cID := container.Run(ctx, t, client, container.WithName(oldName))
|
|
poll.WaitOn(t, container.IsInState(ctx, client, cID, "running"), poll.WithDelay(100*time.Millisecond))
|
|
|
|
err := client.ContainerRename(ctx, oldName, "new:invalid")
|
|
assert.Check(t, is.ErrorContains(err, "Invalid container name"))
|
|
|
|
inspect, err := client.ContainerInspect(ctx, oldName)
|
|
assert.NilError(t, err)
|
|
assert.Check(t, is.Equal(cID, inspect.ID))
|
|
}
|
|
|
|
// Test case for GitHub issue 22466
|
|
// Docker's service discovery works for named containers so
|
|
// ping to a named container should work, and an anonymous
|
|
// container without a name does not work with service discovery.
|
|
// However, an anonymous could be renamed to a named container.
|
|
// This test is to make sure once the container has been renamed,
|
|
// the service discovery for the (re)named container works.
|
|
func TestRenameAnonymousContainer(t *testing.T) {
|
|
skip.If(t, testEnv.OSType == "windows", "FIXME")
|
|
defer setupTest(t)()
|
|
ctx := context.Background()
|
|
client := testEnv.APIClient()
|
|
|
|
networkName := "network1" + t.Name()
|
|
_, err := client.NetworkCreate(ctx, networkName, types.NetworkCreate{})
|
|
|
|
assert.NilError(t, err)
|
|
cID := container.Run(ctx, t, client, func(c *container.TestContainerConfig) {
|
|
c.NetworkingConfig.EndpointsConfig = map[string]*network.EndpointSettings{
|
|
networkName: {},
|
|
}
|
|
c.HostConfig.NetworkMode = containertypes.NetworkMode(networkName)
|
|
})
|
|
|
|
container1Name := "container1" + t.Name()
|
|
err = client.ContainerRename(ctx, cID, container1Name)
|
|
assert.NilError(t, err)
|
|
// Stop/Start the container to get registered
|
|
// FIXME(vdemeester) this is a really weird behavior as it fails otherwise
|
|
err = client.ContainerStop(ctx, container1Name, nil)
|
|
assert.NilError(t, err)
|
|
err = client.ContainerStart(ctx, container1Name, types.ContainerStartOptions{})
|
|
assert.NilError(t, err)
|
|
|
|
poll.WaitOn(t, container.IsInState(ctx, client, cID, "running"), poll.WithDelay(100*time.Millisecond))
|
|
|
|
count := "-c"
|
|
if testEnv.OSType == "windows" {
|
|
count = "-n"
|
|
}
|
|
cID = container.Run(ctx, t, client, func(c *container.TestContainerConfig) {
|
|
c.NetworkingConfig.EndpointsConfig = map[string]*network.EndpointSettings{
|
|
networkName: {},
|
|
}
|
|
c.HostConfig.NetworkMode = containertypes.NetworkMode(networkName)
|
|
}, container.WithCmd("ping", count, "1", container1Name))
|
|
poll.WaitOn(t, container.IsInState(ctx, client, cID, "exited"), poll.WithDelay(100*time.Millisecond))
|
|
|
|
inspect, err := client.ContainerInspect(ctx, cID)
|
|
assert.NilError(t, err)
|
|
assert.Check(t, is.Equal(0, inspect.State.ExitCode), "container %s exited with the wrong exitcode: %s", cID, inspect.State.Error)
|
|
}
|
|
|
|
// TODO: should be a unit test
|
|
func TestRenameContainerWithSameName(t *testing.T) {
|
|
defer setupTest(t)()
|
|
ctx := context.Background()
|
|
client := testEnv.APIClient()
|
|
|
|
oldName := "old" + t.Name()
|
|
cID := container.Run(ctx, t, client, container.WithName(oldName))
|
|
|
|
poll.WaitOn(t, container.IsInState(ctx, client, cID, "running"), poll.WithDelay(100*time.Millisecond))
|
|
err := client.ContainerRename(ctx, oldName, oldName)
|
|
assert.Check(t, is.ErrorContains(err, "Renaming a container with the same name"))
|
|
err = client.ContainerRename(ctx, cID, oldName)
|
|
assert.Check(t, is.ErrorContains(err, "Renaming a container with the same name"))
|
|
}
|
|
|
|
// Test case for GitHub issue 23973
|
|
// When a container is being renamed, the container might
|
|
// be linked to another container. In that case, the meta data
|
|
// of the linked container should be updated so that the other
|
|
// container could still reference to the container that is renamed.
|
|
func TestRenameContainerWithLinkedContainer(t *testing.T) {
|
|
skip.If(t, testEnv.IsRemoteDaemon)
|
|
skip.If(t, testEnv.OSType == "windows", "FIXME")
|
|
|
|
defer setupTest(t)()
|
|
ctx := context.Background()
|
|
client := testEnv.APIClient()
|
|
|
|
db1Name := "db1" + t.Name()
|
|
db1ID := container.Run(ctx, t, client, container.WithName(db1Name))
|
|
poll.WaitOn(t, container.IsInState(ctx, client, db1ID, "running"), poll.WithDelay(100*time.Millisecond))
|
|
|
|
app1Name := "app1" + t.Name()
|
|
app2Name := "app2" + t.Name()
|
|
app1ID := container.Run(ctx, t, client, container.WithName(app1Name), container.WithLinks(db1Name+":/mysql"))
|
|
poll.WaitOn(t, container.IsInState(ctx, client, app1ID, "running"), poll.WithDelay(100*time.Millisecond))
|
|
|
|
err := client.ContainerRename(ctx, app1Name, app2Name)
|
|
assert.NilError(t, err)
|
|
|
|
inspect, err := client.ContainerInspect(ctx, app2Name+"/mysql")
|
|
assert.NilError(t, err)
|
|
assert.Check(t, is.Equal(db1ID, inspect.ID))
|
|
}
|