mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
1db4be0c32
client.checkResponseErr() was hanging and consuming infinite memory when the serverResp.Body io.Reader returns infinite stream. This commit prohibits reading more than 1MiB. Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
106 lines
2.8 KiB
Go
106 lines
2.8 KiB
Go
package client // import "github.com/docker/docker/client"
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"fmt"
|
|
"io/ioutil"
|
|
"math/rand"
|
|
"net/http"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/docker/docker/api/types"
|
|
"gotest.tools/assert"
|
|
is "gotest.tools/assert/cmp"
|
|
)
|
|
|
|
// TestSetHostHeader should set fake host for local communications, set real host
|
|
// for normal communications.
|
|
func TestSetHostHeader(t *testing.T) {
|
|
testURL := "/test"
|
|
testCases := []struct {
|
|
host string
|
|
expectedHost string
|
|
expectedURLHost string
|
|
}{
|
|
{
|
|
"unix:///var/run/docker.sock",
|
|
"docker",
|
|
"/var/run/docker.sock",
|
|
},
|
|
{
|
|
"npipe:////./pipe/docker_engine",
|
|
"docker",
|
|
"//./pipe/docker_engine",
|
|
},
|
|
{
|
|
"tcp://0.0.0.0:4243",
|
|
"",
|
|
"0.0.0.0:4243",
|
|
},
|
|
{
|
|
"tcp://localhost:4243",
|
|
"",
|
|
"localhost:4243",
|
|
},
|
|
}
|
|
|
|
for c, test := range testCases {
|
|
hostURL, err := ParseHostURL(test.host)
|
|
assert.NilError(t, err)
|
|
|
|
client := &Client{
|
|
client: newMockClient(func(req *http.Request) (*http.Response, error) {
|
|
if !strings.HasPrefix(req.URL.Path, testURL) {
|
|
return nil, fmt.Errorf("Test Case #%d: Expected URL %q, got %q", c, testURL, req.URL)
|
|
}
|
|
if req.Host != test.expectedHost {
|
|
return nil, fmt.Errorf("Test Case #%d: Expected host %q, got %q", c, test.expectedHost, req.Host)
|
|
}
|
|
if req.URL.Host != test.expectedURLHost {
|
|
return nil, fmt.Errorf("Test Case #%d: Expected URL host %q, got %q", c, test.expectedURLHost, req.URL.Host)
|
|
}
|
|
return &http.Response{
|
|
StatusCode: http.StatusOK,
|
|
Body: ioutil.NopCloser(bytes.NewReader([]byte(""))),
|
|
}, nil
|
|
}),
|
|
|
|
proto: hostURL.Scheme,
|
|
addr: hostURL.Host,
|
|
basePath: hostURL.Path,
|
|
}
|
|
|
|
_, err = client.sendRequest(context.Background(), "GET", testURL, nil, nil, nil)
|
|
assert.NilError(t, err)
|
|
}
|
|
}
|
|
|
|
// TestPlainTextError tests the server returning an error in plain text for
|
|
// backwards compatibility with API versions <1.24. All other tests use
|
|
// errors returned as JSON
|
|
func TestPlainTextError(t *testing.T) {
|
|
client := &Client{
|
|
client: newMockClient(plainTextErrorMock(http.StatusInternalServerError, "Server error")),
|
|
}
|
|
_, err := client.ContainerList(context.Background(), types.ContainerListOptions{})
|
|
if err == nil || err.Error() != "Error response from daemon: Server error" {
|
|
t.Fatalf("expected a Server Error, got %v", err)
|
|
}
|
|
}
|
|
|
|
func TestInfiniteError(t *testing.T) {
|
|
infinitR := rand.New(rand.NewSource(42))
|
|
client := &Client{
|
|
client: newMockClient(func(req *http.Request) (*http.Response, error) {
|
|
resp := &http.Response{StatusCode: http.StatusInternalServerError}
|
|
resp.Header = http.Header{}
|
|
resp.Body = ioutil.NopCloser(infinitR)
|
|
return resp, nil
|
|
}),
|
|
}
|
|
|
|
_, err := client.Ping(context.Background())
|
|
assert.Check(t, is.ErrorContains(err, "request returned Internal Server Error"))
|
|
}
|