kotovalexarian-likes-github/moby--moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
Code Releases Activity
moby--moby/integration
History
Sebastiaan van Stijn eeaa0b30d4
Skip TestHealthKillContainer on Windows 
This test is failing on Windows currently:

```
11:59:47 --- FAIL: TestHealthKillContainer (8.12s)
11:59:47     health_test.go:57: assertion failed: error is not nil: Error response from daemon: Invalid signal: SIGUSR1
``

That test was added recently in https://github.com/moby/moby/pull/39454, but
rewritten in a commit in the same PR:
f8aef6a92f

In that rewrite, there were some changes:

- originally it was skipped on Windows, but the rewritten test doesn't have that skip:

    ```go
    testRequires(c, DaemonIsLinux) // busybox doesn't work on Windows
    ```

- the original test used `SIGINT`, but the new one uses `SIGUSR1`

Analysis:

- The Error bubbles up from: 8e610b2b55/pkg/signal/signal.go (L29-L44)
- Interestingly; `ContainerKill` should validate if a signal is valid for the given platform, but somehow we don't hit that part; f1b5612f20/daemon/kill.go (L40-L48)
- Windows only looks to support 2 signals currently 8e610b2b55/pkg/signal/signal_windows.go (L17-L26)
- Upstream Golang looks to define `SIGINT` as well; 77f9b2728e/src/runtime/defs_windows.go (L44)
- This looks like the current list of Signals upstream in Go; 3b58ed4ad3/windows/types_windows.go (L52-L67)

```go
const (
	// More invented values for signals
	SIGHUP  = Signal(0x1)
	SIGINT  = Signal(0x2)
	SIGQUIT = Signal(0x3)
	SIGILL  = Signal(0x4)
	SIGTRAP = Signal(0x5)
	SIGABRT = Signal(0x6)
	SIGBUS  = Signal(0x7)
	SIGFPE  = Signal(0x8)
	SIGKILL = Signal(0x9)
	SIGSEGV = Signal(0xb)
	SIGPIPE = Signal(0xd)
	SIGALRM = Signal(0xe)
	SIGTERM = Signal(0xf)
)
```

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2019-07-19 16:09:50 +02:00
..
build integration: run build session tests on non-experimental 2019-07-17 23:56:04 +02:00
config Add test for keeping same daemon ID on upgrade 2019-06-18 01:40:25 +00:00
container Skip TestHealthKillContainer on Windows 2019-07-19 16:09:50 +02:00
image Add regression tests for invalid platform status codes 2019-07-15 20:37:00 +02:00
internal Merge pull request #39240 from olljanat/enable-new-integration-tests-for-win 2019-06-11 14:24:03 -07:00
network Merge pull request #39431 from thaJeztah/macvlan_redundant_checks 2019-07-15 11:33:15 +02:00
plugin integration: change testGraphDriver signature to fix linting 2019-06-07 13:05:51 +02:00
secret Fatalf -> Fatal 2019-01-27 00:43:24 +00:00
service Merge pull request #38441 from sirlatrom/swarm_plugin_env 2019-07-08 15:26:55 -04:00
session integration: run build session tests on non-experimental 2019-07-17 23:56:04 +02:00
system Revert "Remove Schema1 integration test suite" 2019-06-18 00:23:04 +00:00
testdata/https integration/plugin/authz: port tests from integration-cli 2017-10-02 14:20:59 +01:00
volume Merge pull request #39240 from olljanat/enable-new-integration-tests-for-win 2019-06-11 14:24:03 -07:00
doc.go Add canonical import comment 2018-02-05 16:51:57 -05:00