1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
moby--moby/pkg
Aaron Lehmann 6052f2b396 Remove pkg/testutil/assert in favor of testify
I noticed that we're using a homegrown package for assertions. The
functions are extremely similar to testify, but with enough slight
differences to be confusing (for example, Equal takes its arguments in a
different order). We already vendor testify, and it's used in a few
places by tests.

I also found some problems with pkg/testutil/assert. For example, the
NotNil function seems to be broken. It checks the argument against
"nil", which only works for an interface. If you pass in a nil map or
slice, the equality check will fail.

In the interest of avoiding NIH, I'm proposing replacing
pkg/testutil/assert with testify. The test code looks almost the same,
but we avoid the confusion of having two similar but slightly different
assertion packages, and having to maintain our own package instead of
using a commonly-used one.

In the process, I found a few places where the tests should halt if an
assertion fails, so I've made those cases (that I noticed) use "require"
instead of "assert", and I've vendored the "require" package from
testify alongside the already-present "assert" package.

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
2017-04-14 12:03:21 -07:00
..
aaparser pkg: return directly without ifs where possible 2016-12-13 22:10:11 +02:00
archive Remove pkg/testutil/assert in favor of testify 2017-04-14 12:03:21 -07:00
authorization When authz plugin is disabled, remove from authz middleware chain. 2017-03-22 12:07:39 -07:00
broadcaster
chrootarchive pkg/{chroot,}archive: clean up a few small issues 2017-03-30 16:37:54 +03:00
devicemapper Make pkg/devicemapper and pkg/loopback depend on cgo in build tags 2017-03-29 17:55:42 -07:00
directory Fix filepath.Walk misusage in pkg/directory 2016-05-30 07:40:46 +00:00
discovery Update docker daemon to dockerd 2016-12-27 17:32:15 +08:00
filenotify pkg/file{utils,notify}: don't compare to bool 2017-03-30 16:38:01 +03:00
fileutils pkg/file{utils,notify}: don't compare to bool 2017-03-30 16:38:01 +03:00
fsutils pkg: return directly without ifs where possible 2016-12-13 22:10:11 +02:00
gitutils Fix gitconfig dependency in pkg/gitutils.TestCheckoutGit 2016-06-02 17:44:09 +09:00
homedir gcplogs: forcibly set HOME on static UNIX binary 2016-12-29 03:17:26 +00:00
httputils Fix escaped go vet error 2017-01-18 00:13:09 +08:00
idtools pkg: return directly without ifs where possible 2016-12-13 22:10:11 +02:00
ioutils Merge pull request #32450 from miaoyq/fixed-a-bug-of-multireader 2017-04-10 11:39:47 -04:00
jsonlog pkg/*: clean up a few issues 2017-03-30 16:50:46 +03:00
jsonmessage Synchronous service create and service update 2017-04-03 09:46:01 -07:00
listeners pkg/*: clean up a few issues 2017-03-30 16:50:46 +03:00
locker fix some typos 2016-12-28 09:43:27 +08:00
longpath Windows: Fixing longpath hanlding of UNC paths. 2015-09-30 19:36:08 -07:00
loopback Make pkg/devicemapper and pkg/loopback depend on cgo in build tags 2017-03-29 17:55:42 -07:00
mount pkg/*: clean up a few issues 2017-03-30 16:50:46 +03:00
namesgenerator Add Johannes Kepler and Mary Jackson to name generator 2017-03-17 20:36:12 -07:00
parsers Fix building client on OpenBSD 2017-03-26 20:47:18 +00:00
pidfile pkg: return directly without ifs where possible 2016-12-13 22:10:11 +02:00
platform Swap usage of LazyDLL and LoadDLL to LazySystemDLL. 2016-11-22 14:57:11 -08:00
plugingetter plugingetter: Avoid all caps for constant declarations 2017-01-04 10:19:04 -08:00
plugins Merge pull request #32222 from unclejack/small_cleanup 2017-03-30 21:09:39 +02:00
pools pkg/pool: no need for double pointer for sync.Pool 2016-10-20 15:27:38 -07:00
progress Synchronous service create and service update 2017-04-03 09:46:01 -07:00
promise Move Go() promise-like func from utils to pkg/promise 2014-09-29 23:16:27 -07:00
pubsub Revert "use pubsub instead of filenotify to follow json logs" 2016-02-23 21:43:52 -05:00
random Fix typos found across repository 2015-12-13 18:04:12 +02:00
reexec First header should be a top level header 2016-11-22 09:33:21 +08:00
registrar pkg/*: clean up a few issues 2017-03-30 16:50:46 +03:00
signal Move stack dump dir to exec root 2016-11-16 12:55:18 -05:00
stdcopy fix docker logs error handling 2017-02-14 14:38:42 -08:00
streamformatter Synchronous service create and service update 2017-04-03 09:46:01 -07:00
stringid Move imageID validation to stringid pkg 2016-12-26 18:53:22 -08:00
stringutils change minor mistake of spelling 2016-12-20 21:05:19 +08:00
symlink Update copyright dates 2017-02-24 19:41:59 +00:00
sysinfo Only show global warnings once 2016-11-30 10:11:42 -08:00
system Merge pull request #32387 from Microsoft/jjh/tidystat 2017-04-06 08:40:27 -04:00
tailfile Change reading order of tailfile 2016-11-13 20:08:51 -08:00
tarsum Add support for COPY from previous rootfs 2017-03-23 15:12:15 -07:00
templates Remove pkg/testutil/assert in favor of testify 2017-04-14 12:03:21 -07:00
term fix typo 2017-01-19 15:52:28 +08:00
testutil Remove pkg/testutil/assert in favor of testify 2017-04-14 12:03:21 -07:00
tlsconfig Use system ca pool from tlsconfig 2016-10-31 14:52:07 -07:00
truncindex Fix non thread-safe Iteration around go-patricia 2017-01-09 17:06:50 +00:00
urlutil pkg/urlutil: don't compare to bool 2017-03-30 16:38:01 +03:00
useragent
README.md

pkg/ is a collection of utility packages used by the Docker project without being specific to its internals.

Utility packages are kept separate from the docker core codebase to keep it as small and concise as possible. If some utilities grow larger and their APIs stabilize, they may be moved to their own repository under the Docker organization, to facilitate re-use by other projects. However that is not the priority.

The directory pkg is named after the same directory in the camlistore project. Since Brad is a core Go maintainer, we thought it made sense to copy his methods for organizing Go code :) Thanks Brad!

Because utility packages are small and neatly separated from the rest of the codebase, they are a good place to start for aspiring maintainers and contributors. Get in touch if you want to help maintain them!