kotovalexarian-likes-github
/
moby--moby
mirror of https://github.com/moby/moby.git
1
0
Fork 0
Code Releases Activity
moby--moby/daemon/config
History
Sebastiaan van Stijn 2c97295ad8
daemon: remove v1 shim configuration for containerd 
This removes the plugin section from the containerd configuration file
(`/var/run/docker/containerd/containerd.toml`) that is generated when
starting containerd as child process;

```toml
[plugins]
  [plugins.linux]
    shim = "containerd-shim"
    runtime = "runc"
    runtime_root = "/var/lib/docker/runc"
    no_shim = false
    shim_debug = true
```

This configuration doesn't appear to be used since commit:
0b14c2b67a, which switched the default runtime
to to io.containerd.runc.v2.

Note that containerd itself uses `containerd-shim` and `runc` as default
for `shim` and `runtime` v1, so omitting that configuration doesn't seem
to make a difference.

I'm slightly confused if any of the other options in this configuration were
actually used: for example, even though `runtime_root` was configured to be
`/var/lib/docker/runc`, when starting a container with that coniguration set
on docker 19.03, `/var/lib/docker/runc` doesn't appear to exist:

```console
$ docker ps
CONTAINER ID        IMAGE               COMMAND                  CREATED             STATUS              PORTS               NAMES
098baa4cb0e7        nginx:alpine        "/docker-entrypoint.…"   59 minutes ago      Up 59 minutes       80/tcp              foo

$ ls /var/lib/docker/runc
ls: /var/lib/docker/runc: No such file or directory

$ ps auxf
PID   USER     TIME  COMMAND
    1 root      0:00 sh
   16 root      0:11 dockerd --debug
   26 root      0:09 containerd --config /var/run/docker/containerd/containerd.toml --log-level debug
  234 root      0:00 containerd-shim -namespace moby -workdir /var/lib/docker/containerd/daemon/io.containerd.runtime.v1.linux/moby/09
  251 root      0:00 nginx: master process nginx -g daemon off;
  304 101       0:00 nginx: worker process
...

```

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 		2022-03-07 19:31:24 +01:00
..
builder.go Add GoDoc to fix linting validation 2019-10-21 21:36:22 +02:00
builder_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
config.go daemon: remove v1 shim configuration for containerd 2022-03-07 19:31:24 +01:00
config_linux.go daemon: remove discovery-related config handling 2022-01-06 18:28:17 +01:00
config_linux_test.go Allow switching Windows runtimes. 2021-09-23 17:44:04 +00:00
config_test.go daemon: remove discovery related tests 2022-01-06 18:28:10 +01:00
config_windows.go Allow switching Windows runtimes. 2021-09-23 17:44:04 +00:00
config_windows_test.go refactor: move from io/ioutil to io and os package 2021-08-27 14:56:57 +08:00
opts.go Add canonical import comment 2018-02-05 16:51:57 -05:00