mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
d3eca4451d
Makes `docker volume ls` and `docker volume inspect` ask the volume drivers rather than only using what is cached locally. Previously in order to use a volume from an external driver, one would either have to use `docker volume create` or have a container that is already using that volume for it to be visible to the other volume API's. For keeping uniqueness of volume names in the daemon, names are bound to a driver on a first come first serve basis. If two drivers have a volume with the same name, the first one is chosen, and a warning is logged about the second one. Adds 2 new methods to the plugin API, `List` and `Get`. If a plugin does not implement these endpoints, a user will not be able to find the specified volumes as well requests go through the drivers. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
73 lines
2.1 KiB
Go
73 lines
2.1 KiB
Go
// +build !windows
|
|
|
|
package daemon
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
|
|
containertypes "github.com/docker/docker/api/types/container"
|
|
"github.com/docker/docker/container"
|
|
derr "github.com/docker/docker/errors"
|
|
"github.com/docker/docker/image"
|
|
"github.com/docker/docker/pkg/stringid"
|
|
"github.com/docker/docker/volume"
|
|
"github.com/opencontainers/runc/libcontainer/label"
|
|
)
|
|
|
|
// createContainerPlatformSpecificSettings performs platform specific container create functionality
|
|
func (daemon *Daemon) createContainerPlatformSpecificSettings(container *container.Container, config *containertypes.Config, hostConfig *containertypes.HostConfig, img *image.Image) error {
|
|
if err := daemon.Mount(container); err != nil {
|
|
return err
|
|
}
|
|
defer daemon.Unmount(container)
|
|
|
|
for spec := range config.Volumes {
|
|
name := stringid.GenerateNonCryptoID()
|
|
destination := filepath.Clean(spec)
|
|
|
|
// Skip volumes for which we already have something mounted on that
|
|
// destination because of a --volume-from.
|
|
if container.IsDestinationMounted(destination) {
|
|
continue
|
|
}
|
|
path, err := container.GetResourcePath(destination)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
stat, err := os.Stat(path)
|
|
if err == nil && !stat.IsDir() {
|
|
return derr.ErrorCodeMountOverFile.WithArgs(path)
|
|
}
|
|
|
|
volumeDriver := hostConfig.VolumeDriver
|
|
if destination != "" && img != nil {
|
|
if _, ok := img.ContainerConfig.Volumes[destination]; ok {
|
|
// check for whether bind is not specified and then set to local
|
|
if _, ok := container.MountPoints[destination]; !ok {
|
|
volumeDriver = volume.DefaultDriverName
|
|
}
|
|
}
|
|
}
|
|
|
|
v, err := daemon.volumes.CreateWithRef(name, volumeDriver, container.ID, nil)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if err := label.Relabel(v.Path(), container.MountLabel, true); err != nil {
|
|
return err
|
|
}
|
|
|
|
// never attempt to copy existing content in a container FS to a shared volume
|
|
if v.DriverName() == volume.DefaultDriverName {
|
|
if err := container.CopyImagePathContent(v, destination); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
container.AddMountPointWithVolume(destination, v, true)
|
|
}
|
|
return nil
|
|
}
|