mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
67e3ddb75f
Forbid `docker run -t` with a redirected stdin (such as `echo test | docker run -ti busybox cat`). Forbid `docker exec -t` with a redirected stdin. Forbid `docker attach` with a redirect stdin toward a tty enabled container. Signed-off-by: Arnaud Porterie <arnaud.porterie@docker.com>
136 lines
2.7 KiB
Go
136 lines
2.7 KiB
Go
package main
|
|
|
|
import (
|
|
"io"
|
|
"os/exec"
|
|
"strings"
|
|
"sync"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
const attachWait = 5 * time.Second
|
|
|
|
func TestAttachMultipleAndRestart(t *testing.T) {
|
|
defer deleteAllContainers()
|
|
|
|
endGroup := &sync.WaitGroup{}
|
|
startGroup := &sync.WaitGroup{}
|
|
endGroup.Add(3)
|
|
startGroup.Add(3)
|
|
|
|
if err := waitForContainer("attacher", "-d", "busybox", "/bin/sh", "-c", "while true; do sleep 1; echo hello; done"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
startDone := make(chan struct{})
|
|
endDone := make(chan struct{})
|
|
|
|
go func() {
|
|
endGroup.Wait()
|
|
close(endDone)
|
|
}()
|
|
|
|
go func() {
|
|
startGroup.Wait()
|
|
close(startDone)
|
|
}()
|
|
|
|
for i := 0; i < 3; i++ {
|
|
go func() {
|
|
c := exec.Command(dockerBinary, "attach", "attacher")
|
|
|
|
defer func() {
|
|
c.Wait()
|
|
endGroup.Done()
|
|
}()
|
|
|
|
out, err := c.StdoutPipe()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if err := c.Start(); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
buf := make([]byte, 1024)
|
|
|
|
if _, err := out.Read(buf); err != nil && err != io.EOF {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
startGroup.Done()
|
|
|
|
if !strings.Contains(string(buf), "hello") {
|
|
t.Fatalf("unexpected output %s expected hello\n", string(buf))
|
|
}
|
|
}()
|
|
}
|
|
|
|
select {
|
|
case <-startDone:
|
|
case <-time.After(attachWait):
|
|
t.Fatalf("Attaches did not initialize properly")
|
|
}
|
|
|
|
cmd := exec.Command(dockerBinary, "kill", "attacher")
|
|
if _, err := runCommand(cmd); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
select {
|
|
case <-endDone:
|
|
case <-time.After(attachWait):
|
|
t.Fatalf("Attaches did not finish properly")
|
|
}
|
|
|
|
logDone("attach - multiple attach")
|
|
}
|
|
|
|
func TestAttachTtyWithoutStdin(t *testing.T) {
|
|
defer deleteAllContainers()
|
|
|
|
cmd := exec.Command(dockerBinary, "run", "-d", "-ti", "busybox")
|
|
out, _, err := runCommandWithOutput(cmd)
|
|
if err != nil {
|
|
t.Fatalf("failed to start container: %v (%v)", out, err)
|
|
}
|
|
|
|
id := strings.TrimSpace(out)
|
|
if err := waitRun(id); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
defer func() {
|
|
cmd := exec.Command(dockerBinary, "kill", id)
|
|
if out, _, err := runCommandWithOutput(cmd); err != nil {
|
|
t.Fatalf("failed to kill container: %v (%v)", out, err)
|
|
}
|
|
}()
|
|
|
|
done := make(chan struct{})
|
|
go func() {
|
|
defer close(done)
|
|
|
|
cmd := exec.Command(dockerBinary, "attach", id)
|
|
if _, err := cmd.StdinPipe(); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
expected := "cannot enable tty mode"
|
|
if out, _, err := runCommandWithOutput(cmd); err == nil {
|
|
t.Fatal("attach should have failed")
|
|
} else if !strings.Contains(out, expected) {
|
|
t.Fatal("attach failed with error %q: expected %q", out, expected)
|
|
}
|
|
}()
|
|
|
|
select {
|
|
case <-done:
|
|
case <-time.After(attachWait):
|
|
t.Fatal("attach is running but should have failed")
|
|
}
|
|
|
|
logDone("attach - forbid piped stdin to tty enabled container")
|
|
}
|