mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
20833b06a0
Signed-off-by: John Howard <jhoward@microsoft.com> Also fixes https://github.com/moby/moby/issues/22874 This commit is a pre-requisite to moving moby/moby on Windows to using Containerd for its runtime. The reason for this is that the interface between moby and containerd for the runtime is an OCI spec which must be unambigious. It is the responsibility of the runtime (runhcs in the case of containerd on Windows) to ensure that arguments are escaped prior to calling into HCS and onwards to the Win32 CreateProcess call. Previously, the builder was always escaping arguments which has led to several bugs in moby. Because the local runtime in libcontainerd had context of whether or not arguments were escaped, it was possible to hack around in daemon/oci_windows.go with knowledge of the context of the call (from builder or not). With a remote runtime, this is not possible as there's rightly no context of the caller passed across in the OCI spec. Put another way, as I put above, the OCI spec must be unambigious. The other previous limitation (which leads to various subtle bugs) is that moby is coded entirely from a Linux-centric point of view. Unfortunately, Windows != Linux. Windows CreateProcess uses a command line, not an array of arguments. And it has very specific rules about how to escape a command line. Some interesting reading links about this are: https://blogs.msdn.microsoft.com/twistylittlepassagesallalike/2011/04/23/everyone-quotes-command-line-arguments-the-wrong-way/ https://stackoverflow.com/questions/31838469/how-do-i-convert-argv-to-lpcommandline-parameter-of-createprocess https://docs.microsoft.com/en-us/cpp/cpp/parsing-cpp-command-line-arguments?view=vs-2017 For this reason, the OCI spec has recently been updated to cater for more natural syntax by including a CommandLine option in Process. What does this commit do? Primary objective is to ensure that the built OCI spec is unambigious. It changes the builder so that `ArgsEscaped` as commited in a layer is only controlled by the use of CMD or ENTRYPOINT. Subsequently, when calling in to create a container from the builder, if follows a different path to both `docker run` and `docker create` using the added `ContainerCreateIgnoreImagesArgsEscaped`. This allows a RUN from the builder to control how to escape in the OCI spec. It changes the builder so that when shell form is used for RUN, CMD or ENTRYPOINT, it builds (for WCOW) a more natural command line using the original as put by the user in the dockerfile, not the parsed version as a set of args which loses fidelity. This command line is put into args[0] and `ArgsEscaped` is set to true for CMD or ENTRYPOINT. A RUN statement does not commit `ArgsEscaped` to the commited layer regardless or whether shell or exec form were used. |
||
|---|---|---|
| .. | ||
| checker | ||
| cli | ||
| daemon | ||
| environment | ||
| fixtures | ||
| requirement | ||
| testdata | ||
| benchmark_test.go | ||
| check_test.go | ||
| daemon_swarm_hack_test.go | ||
| docker_api_attach_test.go | ||
| docker_api_build_test.go | ||
| docker_api_build_windows_test.go | ||
| docker_api_containers_test.go | ||
| docker_api_containers_windows_test.go | ||
| docker_api_exec_resize_test.go | ||
| docker_api_exec_test.go | ||
| docker_api_images_test.go | ||
| docker_api_inspect_test.go | ||
| docker_api_logs_test.go | ||
| docker_api_network_test.go | ||
| docker_api_stats_test.go | ||
| docker_api_swarm_node_test.go | ||
| docker_api_swarm_service_test.go | ||
| docker_api_swarm_test.go | ||
| docker_api_test.go | ||
| docker_cli_attach_test.go | ||
| docker_cli_attach_unix_test.go | ||
| docker_cli_build_test.go | ||
| docker_cli_build_unix_test.go | ||
| docker_cli_by_digest_test.go | ||
| docker_cli_commit_test.go | ||
| docker_cli_cp_from_container_test.go | ||
| docker_cli_cp_test.go | ||
| docker_cli_cp_to_container_test.go | ||
| docker_cli_cp_to_container_unix_test.go | ||
| docker_cli_cp_utils_test.go | ||
| docker_cli_create_test.go | ||
| docker_cli_daemon_plugins_test.go | ||
| docker_cli_daemon_test.go | ||
| docker_cli_events_test.go | ||
| docker_cli_events_unix_test.go | ||
| docker_cli_exec_test.go | ||
| docker_cli_exec_unix_test.go | ||
| docker_cli_external_volume_driver_unix_test.go | ||
| docker_cli_health_test.go | ||
| docker_cli_history_test.go | ||
| docker_cli_images_test.go | ||
| docker_cli_import_test.go | ||
| docker_cli_info_test.go | ||
| docker_cli_info_unix_test.go | ||
| docker_cli_inspect_test.go | ||
| docker_cli_links_test.go | ||
| docker_cli_login_test.go | ||
| docker_cli_logout_test.go | ||
| docker_cli_logs_bench_test.go | ||
| docker_cli_logs_test.go | ||
| docker_cli_netmode_test.go | ||
| docker_cli_network_unix_test.go | ||
| docker_cli_plugins_logdriver_test.go | ||
| docker_cli_plugins_test.go | ||
| docker_cli_port_test.go | ||
| docker_cli_proxy_test.go | ||
| docker_cli_prune_unix_test.go | ||
| docker_cli_ps_test.go | ||
| docker_cli_pull_local_test.go | ||
| docker_cli_pull_test.go | ||
| docker_cli_push_test.go | ||
| docker_cli_registry_user_agent_test.go | ||
| docker_cli_restart_test.go | ||
| docker_cli_rmi_test.go | ||
| docker_cli_run_test.go | ||
| docker_cli_run_unix_test.go | ||
| docker_cli_save_load_test.go | ||
| docker_cli_save_load_unix_test.go | ||
| docker_cli_search_test.go | ||
| docker_cli_service_create_test.go | ||
| docker_cli_service_health_test.go | ||
| docker_cli_service_logs_test.go | ||
| docker_cli_service_scale_test.go | ||
| docker_cli_sni_test.go | ||
| docker_cli_start_test.go | ||
| docker_cli_stats_test.go | ||
| docker_cli_swarm_test.go | ||
| docker_cli_swarm_unix_test.go | ||
| docker_cli_top_test.go | ||
| docker_cli_update_unix_test.go | ||
| docker_cli_userns_test.go | ||
| docker_cli_v2_only_test.go | ||
| docker_cli_volume_test.go | ||
| docker_deprecated_api_v124_test.go | ||
| docker_deprecated_api_v124_unix_test.go | ||
| docker_hub_pull_suite_test.go | ||
| docker_utils_test.go | ||
| events_utils_test.go | ||
| fixtures_linux_daemon_test.go | ||
| requirements_test.go | ||
| requirements_unix_test.go | ||
| test_vars_exec_test.go | ||
| test_vars_noexec_test.go | ||
| test_vars_noseccomp_test.go | ||
| test_vars_seccomp_test.go | ||
| test_vars_test.go | ||
| test_vars_unix_test.go | ||
| test_vars_windows_test.go | ||
| utils_test.go | ||