mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
1b3fef5333
Windows Server 2016 (RS1) reached end of support, and Docker Desktop requires
Windows 10 V19H2 (version 1909, build 18363) as a minimum.
This patch makes Windows Server RS5 / ltsc2019 (build 17763) the minimum version
to run the daemon, and removes some hacks for older versions of Windows.
There is one check remaining that checks for Windows RS3 for a workaround
on older versions, but recent changes in Windows seemed to have regressed
on the same issue, so I kept that code for now to check if we may need that
workaround (again);
085c6a98d5/daemon/graphdriver/windows/windows.go (L319-L341)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
81 lines
1.9 KiB
Go
81 lines
1.9 KiB
Go
//go:build windows
|
|
// +build windows
|
|
|
|
package main
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"io"
|
|
"math/rand"
|
|
"strings"
|
|
"testing"
|
|
|
|
winio "github.com/Microsoft/go-winio"
|
|
"github.com/docker/docker/api/types"
|
|
"github.com/docker/docker/api/types/container"
|
|
"github.com/docker/docker/api/types/mount"
|
|
"github.com/pkg/errors"
|
|
"gotest.tools/v3/assert"
|
|
is "gotest.tools/v3/assert/cmp"
|
|
)
|
|
|
|
func (s *DockerSuite) TestContainersAPICreateMountsBindNamedPipe(c *testing.T) {
|
|
// Create a host pipe to map into the container
|
|
hostPipeName := fmt.Sprintf(`\\.\pipe\docker-cli-test-pipe-%x`, rand.Uint64())
|
|
pc := &winio.PipeConfig{
|
|
SecurityDescriptor: "D:P(A;;GA;;;AU)", // Allow all users access to the pipe
|
|
}
|
|
l, err := winio.ListenPipe(hostPipeName, pc)
|
|
if err != nil {
|
|
c.Fatal(err)
|
|
}
|
|
defer l.Close()
|
|
|
|
// Asynchronously read data that the container writes to the mapped pipe.
|
|
var b []byte
|
|
ch := make(chan error)
|
|
go func() {
|
|
conn, err := l.Accept()
|
|
if err == nil {
|
|
b, err = io.ReadAll(conn)
|
|
conn.Close()
|
|
}
|
|
ch <- err
|
|
}()
|
|
|
|
containerPipeName := `\\.\pipe\docker-cli-test-pipe`
|
|
text := "hello from a pipe"
|
|
cmd := fmt.Sprintf("echo %s > %s", text, containerPipeName)
|
|
name := "test-bind-npipe"
|
|
|
|
ctx := context.Background()
|
|
client := testEnv.APIClient()
|
|
_, err = client.ContainerCreate(ctx,
|
|
&container.Config{
|
|
Image: testEnv.PlatformDefaults.BaseImage,
|
|
Cmd: []string{"cmd", "/c", cmd},
|
|
}, &container.HostConfig{
|
|
Mounts: []mount.Mount{
|
|
{
|
|
Type: "npipe",
|
|
Source: hostPipeName,
|
|
Target: containerPipeName,
|
|
},
|
|
},
|
|
},
|
|
nil, nil, name)
|
|
assert.NilError(c, err)
|
|
|
|
err = client.ContainerStart(ctx, name, types.ContainerStartOptions{})
|
|
assert.NilError(c, err)
|
|
|
|
err = <-ch
|
|
assert.NilError(c, err)
|
|
assert.Check(c, is.Equal(text, strings.TrimSpace(string(b))))
|
|
}
|
|
|
|
func mountWrapper(device, target, mType, options string) error {
|
|
// This should never be called.
|
|
return errors.Errorf("there is no implementation of Mount on this platform")
|
|
}
|