1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
moby--moby/pkg/mount
Yong Tang 397a6fefad Inconsistent --tmpfs behavior
This fix tries to address the issue raised in #22420. When
`--tmpfs` is specified with `/tmp`, the default value is
`rw,nosuid,nodev,noexec,relatime,size=65536k`. When `--tmpfs`
is specified with `/tmp:rw`, then the value changed to
`rw,nosuid,nodev,noexec,relatime`.

The reason for such an inconsistency is because docker tries
to add `size=65536k` option only when user provides no option.

This fix tries to address this issue by always pre-progating
`size=65536k` along with `rw,nosuid,nodev,noexec,relatime`.
If user provides a different value (e.g., `size=8192k`), it
will override the `size=65536k` anyway since the combined
options will be parsed and merged to remove any duplicates.

Additional test cases have been added to cover the changes
in this fix.

This fix fixes #22420.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2016-05-26 19:28:18 -07:00
..
flags.go Inconsistent --tmpfs behavior 2016-05-26 19:28:18 -07:00
flags_freebsd.go
flags_linux.go
flags_unsupported.go
mount.go
mount_unix_test.go Inconsistent --tmpfs behavior 2016-05-26 19:28:18 -07:00
mounter_freebsd.go
mounter_linux.go
mounter_solaris.go
mounter_unsupported.go
mountinfo.go
mountinfo_freebsd.go
mountinfo_linux.go
mountinfo_linux_test.go
mountinfo_solaris.go
mountinfo_unsupported.go
mountinfo_windows.go
sharedsubtree_linux.go
sharedsubtree_linux_test.go