1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
moby--moby/integration-cli
Boaz Shuster e050f1760d Fix the create API when fromSrc has a bad URL
When sending a bad URL in the fromSrc parameter using cURL
the response will have status code 200 while it should have 404
or 500 (depends on the error).

This commit addresses this problem in the following ways:
 * Before, `src` was parsed using url.Parse and if the
   returned `url.Scheme` was empty it was set to 'http'
   and `url.Host` was set to `src`.
   This is bad because if `src` was 'web.com/tars/image1.tar'
   The `url.String()` returns 'web.com%2Ftars%2Fimage1.tar`
   which will cause the daemon to fail downloading the file
 * Before writing the "Downloading" message, the image
   is attempted to be downloaded and if there is no error
   the "Downloading" message is sent.

Signed-off-by: Boaz Shuster <ripcurld.github@gmail.com>
2017-03-26 15:21:13 +03:00
..
checker
daemon
environment
fixtures
registry
request
requirement
benchmark_test.go
check_test.go
daemon_swarm_hack_test.go
docker_api_attach_test.go
docker_api_auth_test.go
docker_api_build_test.go
docker_api_containers_test.go
docker_api_create_test.go
docker_api_events_test.go
docker_api_exec_resize_test.go
docker_api_exec_test.go
docker_api_images_test.go Fix the create API when fromSrc has a bad URL 2017-03-26 15:21:13 +03:00
docker_api_info_test.go
docker_api_inspect_test.go
docker_api_inspect_unix_test.go
docker_api_logs_test.go
docker_api_network_test.go
docker_api_resize_test.go
docker_api_service_update_test.go
docker_api_stats_test.go
docker_api_stats_unix_test.go
docker_api_swarm_test.go
docker_api_test.go
docker_api_update_unix_test.go
docker_api_version_test.go
docker_api_volumes_test.go
docker_cli_attach_test.go
docker_cli_attach_unix_test.go
docker_cli_authz_plugin_v2_test.go
docker_cli_authz_unix_test.go
docker_cli_build_test.go
docker_cli_build_unix_test.go
docker_cli_by_digest_test.go
docker_cli_commit_test.go
docker_cli_config_test.go
docker_cli_cp_from_container_test.go
docker_cli_cp_test.go
docker_cli_cp_to_container_test.go
docker_cli_cp_to_container_unix_test.go
docker_cli_cp_utils.go
docker_cli_create_test.go
docker_cli_create_unix_test.go
docker_cli_daemon_plugins_test.go
docker_cli_daemon_test.go Merge pull request #29552 from dnephin/fix-build-with-log-driver 2017-02-07 15:47:41 -05:00
docker_cli_diff_test.go
docker_cli_events_test.go
docker_cli_events_unix_test.go
docker_cli_exec_test.go Merge pull request #30537 from DiSiqueira/asserting_error 2017-02-01 16:08:20 +01:00
docker_cli_exec_unix_test.go
docker_cli_experimental_test.go
docker_cli_export_import_test.go
docker_cli_external_graphdriver_unix_test.go
docker_cli_external_volume_driver_unix_test.go
docker_cli_health_test.go
docker_cli_help_test.go Wrap output of docker cli --help 2017-02-03 11:05:49 +00:00
docker_cli_history_test.go
docker_cli_images_test.go Use distribution reference 2017-02-07 11:08:37 -08:00
docker_cli_import_test.go
docker_cli_info_test.go
docker_cli_info_unix_test.go
docker_cli_inspect_test.go
docker_cli_kill_test.go
docker_cli_links_test.go
docker_cli_links_unix_test.go
docker_cli_login_test.go
docker_cli_logout_test.go
docker_cli_logs_bench_test.go
docker_cli_logs_test.go
docker_cli_nat_test.go
docker_cli_netmode_test.go
docker_cli_network_unix_test.go Revert "Fix IT case for network name validation" 2017-02-02 15:38:12 -08:00
docker_cli_oom_killed_test.go
docker_cli_pause_test.go
docker_cli_plugins_test.go Make propagated mount persist outside rootfs 2017-02-03 16:22:58 -05:00
docker_cli_port_test.go
docker_cli_proxy_test.go
docker_cli_prune_unix_test.go
docker_cli_ps_test.go Bump go-units 2017-02-07 21:58:56 +01:00
docker_cli_pull_local_test.go
docker_cli_pull_test.go
docker_cli_pull_trusted_test.go
docker_cli_push_test.go
docker_cli_registry_user_agent_test.go
docker_cli_rename_test.go
docker_cli_restart_test.go
docker_cli_rm_test.go
docker_cli_rmi_test.go
docker_cli_run_test.go Merge pull request #30654 from Microsoft/jjh/unifyworkdir 2017-02-03 00:37:54 -08:00
docker_cli_run_unix_test.go
docker_cli_save_load_test.go
docker_cli_save_load_unix_test.go
docker_cli_search_test.go
docker_cli_secret_create_test.go
docker_cli_secret_inspect_test.go
docker_cli_service_create_test.go
docker_cli_service_health_test.go
docker_cli_service_logs_experimental_test.go
docker_cli_service_scale_test.go
docker_cli_service_update_test.go
docker_cli_sni_test.go
docker_cli_stack_test.go Add missing build tag for stack tests. 2017-02-01 13:25:37 -05:00
docker_cli_start_test.go
docker_cli_stats_test.go
docker_cli_stop_test.go
docker_cli_swarm_test.go Add --read-only for service create and service update 2017-01-30 12:47:26 -08:00
docker_cli_swarm_unix_test.go
docker_cli_tag_test.go
docker_cli_top_test.go
docker_cli_update_test.go
docker_cli_update_unix_test.go
docker_cli_userns_test.go
docker_cli_v2_only_test.go
docker_cli_version_test.go
docker_cli_volume_test.go Fix duplicate mount point for --volumes-from in docker run 2017-02-07 08:30:56 -08:00
docker_cli_wait_test.go
docker_deprecated_api_v124_test.go
docker_deprecated_api_v124_unix_test.go
docker_experimental_network_test.go
docker_hub_pull_suite_test.go
docker_utils_test.go
events_utils_test.go
fixtures_linux_daemon_test.go
fixtures_test.go
requirements_test.go
requirements_unix_test.go
test_vars_exec_test.go
test_vars_noexec_test.go
test_vars_noseccomp_test.go
test_vars_seccomp_test.go
test_vars_test.go
test_vars_unix_test.go
test_vars_windows_test.go
trust_server_test.go
utils_test.go