mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
1e1156cf67
RHEL/CentOS 3.10 kernels report that kernel-memory accounting is supported,
but it actually does not work.
Runc (when compiled for those kernels) will be compiled without kernel-memory
support, so even though the daemon may be reporting that it's supported,
it actually is not.
This cause tests to fail when testing against a daemon that's using a runc
version without kmem support.
For now, skip these tests based on the kernel version reported by the daemon.
This should fix failures such as:
```
FAIL: /go/src/github.com/docker/docker/integration-cli/docker_cli_run_unix_test.go:499: DockerSuite.TestRunWithKernelMemory
assertion failed:
Command: /usr/bin/docker run --kernel-memory 50M --name test1 busybox cat /sys/fs/cgroup/memory/memory.kmem.limit_in_bytes
ExitCode: 0
Error: <nil>
Stdout: 9223372036854771712
Stderr: WARNING: You specified a kernel memory limit on a kernel older than 4.0. Kernel memory limits are experimental on older kernels, it won't work as expected and can cause your system to be unstable.
Failures:
Expected stdout to contain "52428800"
FAIL: /go/src/github.com/docker/docker/integration-cli/docker_cli_update_unix_test.go:125: DockerSuite.TestUpdateKernelMemory
/go/src/github.com/docker/docker/integration-cli/docker_cli_update_unix_test.go:136:
...open /go/src/github.com/docker/docker/integration-cli/docker_cli_update_unix_test.go: no such file or directory
... obtained string = "9223372036854771712"
... expected string = "104857600"
----------------------------------------------------------------------
FAIL: /go/src/github.com/docker/docker/integration-cli/docker_cli_update_unix_test.go:139: DockerSuite.TestUpdateKernelMemoryUninitialized
/go/src/github.com/docker/docker/integration-cli/docker_cli_update_unix_test.go:149:
...open /go/src/github.com/docker/docker/integration-cli/docker_cli_update_unix_test.go: no such file or directory
... value = nil
```
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
97 lines
3.3 KiB
Go
97 lines
3.3 KiB
Go
// +build !windows
|
|
|
|
package kernel // import "github.com/docker/docker/pkg/parsers/kernel"
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
)
|
|
|
|
func assertParseRelease(t *testing.T, release string, b *VersionInfo, result int) {
|
|
var (
|
|
a *VersionInfo
|
|
)
|
|
a, _ = ParseRelease(release)
|
|
|
|
if r := CompareKernelVersion(*a, *b); r != result {
|
|
t.Fatalf("Unexpected kernel version comparison result for (%v,%v). Found %d, expected %d", release, b, r, result)
|
|
}
|
|
if a.Flavor != b.Flavor {
|
|
t.Fatalf("Unexpected parsed kernel flavor. Found %s, expected %s", a.Flavor, b.Flavor)
|
|
}
|
|
}
|
|
|
|
// TestParseRelease tests the ParseRelease() function
|
|
func TestParseRelease(t *testing.T) {
|
|
assertParseRelease(t, "3.8.0", &VersionInfo{Kernel: 3, Major: 8, Minor: 0}, 0)
|
|
assertParseRelease(t, "3.4.54.longterm-1", &VersionInfo{Kernel: 3, Major: 4, Minor: 54, Flavor: ".longterm-1"}, 0)
|
|
assertParseRelease(t, "3.4.54.longterm-1", &VersionInfo{Kernel: 3, Major: 4, Minor: 54, Flavor: ".longterm-1"}, 0)
|
|
assertParseRelease(t, "3.8.0-19-generic", &VersionInfo{Kernel: 3, Major: 8, Minor: 0, Flavor: "-19-generic"}, 0)
|
|
assertParseRelease(t, "3.10.0-862.2.3.el7.x86_64", &VersionInfo{Kernel: 3, Major: 10, Minor: 0, Flavor: "-862.2.3.el7.x86_64"}, 0)
|
|
assertParseRelease(t, "3.12.8tag", &VersionInfo{Kernel: 3, Major: 12, Minor: 8, Flavor: "tag"}, 0)
|
|
assertParseRelease(t, "3.12-1-amd64", &VersionInfo{Kernel: 3, Major: 12, Minor: 0, Flavor: "-1-amd64"}, 0)
|
|
assertParseRelease(t, "3.8.0", &VersionInfo{Kernel: 4, Major: 8, Minor: 0}, -1)
|
|
// Errors
|
|
invalids := []string{
|
|
"3",
|
|
"a",
|
|
"a.a",
|
|
"a.a.a-a",
|
|
}
|
|
for _, invalid := range invalids {
|
|
expectedMessage := fmt.Sprintf("Can't parse kernel version %v", invalid)
|
|
if _, err := ParseRelease(invalid); err == nil || err.Error() != expectedMessage {
|
|
|
|
}
|
|
}
|
|
}
|
|
|
|
func assertKernelVersion(t *testing.T, a, b VersionInfo, result int) {
|
|
if r := CompareKernelVersion(a, b); r != result {
|
|
t.Fatalf("Unexpected kernel version comparison result. Found %d, expected %d", r, result)
|
|
}
|
|
}
|
|
|
|
// TestCompareKernelVersion tests the CompareKernelVersion() function
|
|
func TestCompareKernelVersion(t *testing.T) {
|
|
assertKernelVersion(t,
|
|
VersionInfo{Kernel: 3, Major: 8, Minor: 0},
|
|
VersionInfo{Kernel: 3, Major: 8, Minor: 0},
|
|
0)
|
|
assertKernelVersion(t,
|
|
VersionInfo{Kernel: 2, Major: 6, Minor: 0},
|
|
VersionInfo{Kernel: 3, Major: 8, Minor: 0},
|
|
-1)
|
|
assertKernelVersion(t,
|
|
VersionInfo{Kernel: 3, Major: 8, Minor: 0},
|
|
VersionInfo{Kernel: 2, Major: 6, Minor: 0},
|
|
1)
|
|
assertKernelVersion(t,
|
|
VersionInfo{Kernel: 3, Major: 8, Minor: 0},
|
|
VersionInfo{Kernel: 3, Major: 8, Minor: 0},
|
|
0)
|
|
assertKernelVersion(t,
|
|
VersionInfo{Kernel: 3, Major: 8, Minor: 5},
|
|
VersionInfo{Kernel: 3, Major: 8, Minor: 0},
|
|
1)
|
|
assertKernelVersion(t,
|
|
VersionInfo{Kernel: 3, Major: 0, Minor: 20},
|
|
VersionInfo{Kernel: 3, Major: 8, Minor: 0},
|
|
-1)
|
|
assertKernelVersion(t,
|
|
VersionInfo{Kernel: 3, Major: 7, Minor: 20},
|
|
VersionInfo{Kernel: 3, Major: 8, Minor: 0},
|
|
-1)
|
|
assertKernelVersion(t,
|
|
VersionInfo{Kernel: 3, Major: 8, Minor: 20},
|
|
VersionInfo{Kernel: 3, Major: 7, Minor: 0},
|
|
1)
|
|
assertKernelVersion(t,
|
|
VersionInfo{Kernel: 3, Major: 8, Minor: 20},
|
|
VersionInfo{Kernel: 3, Major: 8, Minor: 0},
|
|
1)
|
|
assertKernelVersion(t,
|
|
VersionInfo{Kernel: 3, Major: 8, Minor: 0},
|
|
VersionInfo{Kernel: 3, Major: 8, Minor: 20},
|
|
-1)
|
|
}
|