Paweł Gronowski e2bd8edb0d daemon/restart: Don't mutate AutoRemove when restarting ... This caused a race condition where AutoRemove could be restored before container was considered for restart and made autoremove containers impossible to restart. ``` $ make DOCKER_GRAPHDRIVER=vfs BIND_DIR=. TEST_FILTER='TestContainerWithAutoRemoveCanBeRestarted' TESTFLAGS='-test.count 1' test-integration ... === RUN TestContainerWithAutoRemoveCanBeRestarted === RUN TestContainerWithAutoRemoveCanBeRestarted/kill === RUN TestContainerWithAutoRemoveCanBeRestarted/stop --- PASS: TestContainerWithAutoRemoveCanBeRestarted (1.61s) --- PASS: TestContainerWithAutoRemoveCanBeRestarted/kill (0.70s) --- PASS: TestContainerWithAutoRemoveCanBeRestarted/stop (0.86s) PASS DONE 3 tests in 3.062s ``` Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>		2022-07-29 16:49:56 +02:00
..
cluster	gofmt GoDoc comments with go1.19	2022-07-13 22:42:29 +02:00
config	daemon/config: use more assertions in tests	2022-06-29 19:59:23 +02:00
events
exec	container/exec: Support ConsoleSize	2022-06-24 11:54:25 +02:00
graphdriver	gofmt GoDoc comments with go1.19	2022-07-13 22:42:29 +02:00
images	gofmt GoDoc comments with go1.19	2022-07-13 22:42:29 +02:00
initlayer	daemon/initlayer: Init(): remove unused stub for Windows	2022-05-11 01:27:47 +02:00
links	all: replace strings.Replace with strings.ReplaceAll	2022-05-09 19:45:40 +08:00
listeners
logger	logger/journald: fix SA4011: ineffective break statement	2022-07-20 16:57:22 +02:00
names
network
stats
testdata
apparmor_default.go
apparmor_default_unsupported.go
archive.go
archive_tarcopyoptions.go	Finish refactor of UID/GID usage to a new struct	2022-03-14 16:28:57 -04:00
archive_tarcopyoptions_unix.go
archive_tarcopyoptions_windows.go
archive_unix.go
archive_windows.go
attach.go	Make it explicit raw|multiplexed stream implementation being used	2022-05-12 11:36:31 +02:00
auth.go	daemon: unexport Daemon.ID and Daemon.RegistryService	2022-03-02 22:19:22 +01:00
changes.go
checkpoint.go
cluster.go
commit.go
configs.go
configs_linux.go
configs_unsupported.go
configs_windows.go
container.go	gofmt GoDoc comments with go1.19	2022-07-13 22:42:29 +02:00
container_linux.go	daemon: load and cache sysInfo on initialization	2022-01-12 18:28:15 +01:00
container_operations.go
container_operations_unix.go	daemon: killWithSignal, killPossiblyDeadProcess: accept syscall.Signal	2022-05-05 00:53:52 +02:00
container_operations_windows.go
container_unix_test.go
container_windows.go
content.go	daemon: rename some variables, import-aliases and receivers	2022-04-20 21:22:28 +02:00
create.go	update uses of container.ContainerCreateCreatedBody to CreateResponse	2022-04-28 22:39:20 +02:00
create_test.go
create_unix.go
create_windows.go
daemon.go	daemon/config: set default MTU when initializing config	2022-06-29 19:59:16 +02:00
daemon_linux.go	daemon: fix daemon.Shutdown, daemon.Cleanup not cleaning up overlay2 mounts	2022-05-29 16:28:13 +02:00
daemon_linux_test.go	daemon: fix daemon.Shutdown, daemon.Cleanup not cleaning up overlay2 mounts	2022-05-29 16:28:13 +02:00
daemon_test.go	daemon: remove discovery inits	2022-01-06 18:28:21 +01:00
daemon_unix.go	gofmt GoDoc comments with go1.19	2022-07-13 22:42:29 +02:00
daemon_unix_test.go	daemon: remove discovery related tests	2022-01-06 18:28:10 +01:00
daemon_unsupported.go	daemon.NewDaemon(): fix network feature detection on first start	2022-06-03 17:54:43 +02:00
daemon_windows.go	Windows: Re-create custom NAT networks after restart if missing from HNS	2022-07-23 23:16:23 -07:00
daemon_windows_test.go
debugtrap_unix.go
debugtrap_unsupported.go
debugtrap_windows.go
delete.go	backend: add StopOptions to ContainerRestart and ContainerStop	2022-04-20 21:29:30 +02:00
delete_test.go
dependency.go	Bump swarmkit to v2	2022-04-21 17:33:07 -04:00
devices_linux.go
disk_usage.go	api/types: replace uses of deprecated types.Volume with volume.Volume	2022-04-21 19:50:59 +02:00
errors.go	filters: lowercase error	2022-03-18 09:44:53 +01:00
events.go	daemon: LogDaemonEventWithAttributes: don't call SystemInfo()	2022-06-07 22:01:12 +02:00
events_test.go
exec.go	container/exec: Support ConsoleSize	2022-06-24 11:54:25 +02:00
exec_linux.go	oci: inheritable capability set should be empty	2022-02-08 14:33:44 -08:00
exec_linux_test.go
exec_windows.go
export.go	Finish refactor of UID/GID usage to a new struct	2022-03-14 16:28:57 -04:00
health.go	container/exec: Support ConsoleSize	2022-06-24 11:54:25 +02:00
health_test.go
id.go	daemon: separate daemon ID from trust-key	2022-05-04 20:17:18 +02:00
info.go	daemon: remove support for deprecated io.containerd.runtime.v1.linux	2022-06-05 18:41:30 +09:00
info_unix.go	gofmt GoDoc comments with go1.19	2022-07-13 22:42:29 +02:00
info_unix_test.go
info_windows.go
inspect.go
inspect_linux.go
inspect_test.go
inspect_windows.go
keys.go
keys_unsupported.go
kill.go	daemon: fix some minor nits	2022-05-05 11:27:59 +02:00
licensing.go
licensing_test.go
links.go
list.go
list_test.go	filters: lowercase error	2022-03-18 09:44:53 +01:00
list_unix.go
list_windows.go
logdrivers_linux.go
logdrivers_windows.go
logs.go
logs_test.go
metrics.go	health: Start probe timeout after exec starts	2022-04-28 17:21:03 -04:00
metrics_unix.go
metrics_unsupported.go
monitor.go	daemon/restart: Don't mutate AutoRemove when restarting	2022-07-29 16:49:56 +02:00
mounts.go
names.go
network.go	replace golint with revive, as it's deprecated	2022-07-04 10:15:54 +02:00
network_windows.go
nvidia_linux.go
oci_linux.go	Fix validation of IpcMode, PidMode, UTSMode, CgroupnsMode	2022-05-25 17:41:51 +02:00
oci_linux_test.go	Finish refactor of UID/GID usage to a new struct	2022-03-14 16:28:57 -04:00
oci_opts.go	daemon/linux: Set console size on creation	2022-05-19 07:57:27 +02:00
oci_utils.go
oci_windows.go	Implement :// separator for arbitrary Windows Device IDTypes	2022-03-27 13:26:47 +11:00
oci_windows_test.go	Bump swarmkit to v2	2022-04-21 17:33:07 -04:00
pause.go
prune.go
reload.go	daemon: LogDaemonEventWithAttributes: don't call SystemInfo()	2022-06-07 22:01:12 +02:00
reload_test.go	daemon: daemon.networkOptions(): don't pass Config as argument	2022-04-23 23:34:13 +02:00
reload_unix.go
reload_windows.go
rename.go
resize.go
resize_test.go
restart.go	daemon/restart: Don't mutate AutoRemove when restarting	2022-07-29 16:49:56 +02:00
runtime_unix.go	daemon: remove support for deprecated io.containerd.runtime.v1.linux	2022-06-05 18:41:30 +09:00
runtime_windows.go
seccomp_linux.go	Remove "seccomp" build tag	2022-05-12 14:48:35 -07:00
seccomp_linux_test.go	Remove "seccomp" build tag	2022-05-12 14:48:35 -07:00
seccomp_unsupported.go
secrets.go
secrets_linux.go
secrets_unsupported.go
secrets_windows.go
start.go	daemon/restart: Don't mutate AutoRemove when restarting	2022-07-29 16:49:56 +02:00
start_unix.go
start_windows.go
stats.go
stats_collector.go
stats_unix.go
stats_windows.go
stop.go	container: StopSignal(): return syscall.Signal	2022-05-05 00:53:53 +02:00
top_unix.go
top_unix_test.go
top_windows.go	gofmt GoDoc comments with go1.19	2022-07-13 22:42:29 +02:00
trustkey.go
trustkey_test.go	fix unclosed file-handles in tests	2022-05-31 21:53:38 +02:00
unpause.go
update.go
update_linux.go
update_windows.go
util_test.go	libcontainerd: SignalProcess(): accept syscall.Signal	2022-05-05 00:53:49 +02:00
volumes.go	introduce CreateMountpoint for parity between binds and mounts	2022-05-19 16:43:06 +02:00
volumes_linux.go
volumes_linux_test.go
volumes_unit_test.go
volumes_unix.go
volumes_windows.go
wait.go
workdir.go