kotovalexarian-likes-github/moby--moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
Code Releases Activity
moby--moby/daemon
History
Yong Tang ee4bd806ba API/CLI discrepancy on hostname validation (#21595). 
This fix tries to fix the discrepancy between API and CLI on hostname
validation. Previously, the hostname validation was handled at the
CLI interface in runconfig/opts/parse.go and return an error if the
hostname is invalid. However, if an end user use the remote API to
pass the hostname, the error will not be returned immediately.
Instead the error will only be thrown out when the container creation
fails. This creates behavior discrepancy between API and CLI.

In this fix, the hostname validation was moved to
verifyContainerSettings so the behavior will be the same for API and
CLI.

After the change, since CLI does not handle the hostname validation
any more, the previous unit tests about hostname validation on CLI
in runconfig/opts/parse_test.go has to be updated as well because
there is no validation at this stage. All those unit tests are moved
to integration test TestRunTooLongHostname so that the hostname
validation is still properly covered as before.

Note: Since the hostname validation moved to API, the error message
changes from `invalid hostname format for --hostname:` to
`invalid hostname format:` as well because `--hostname` is passed
to CLI only.

This fix fixes #21595.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2016-04-08 06:13:08 +00:00
..
caps Replace execdrivers with containerd implementation 2016-03-18 13:38:32 -07:00
events Compare event nanoseconds properly to filter since a specific date. 2016-03-08 17:07:58 -05:00
exec Replace execdrivers with containerd implementation 2016-03-18 13:38:32 -07:00
graphdriver Merge pull request #21872 from Microsoft/sjw/nanoserver-fix 2016-04-07 21:24:32 -07:00
links
logger daemon: remove some unused code 2016-03-31 11:24:12 -07:00
network Remove runconfig package dependency from image and container routers. 2016-03-28 16:23:51 -04:00
apparmor_default.go Replace execdrivers with containerd implementation 2016-03-18 13:38:32 -07:00
apparmor_default_unsupported.go Replace execdrivers with containerd implementation 2016-03-18 13:38:32 -07:00
archive.go Fix copy chown settings to not default to real root 2016-02-18 14:44:13 -08:00
archive_unix.go
archive_windows.go Windows: Remove TP4 support from main code 2016-04-06 12:12:20 -07:00
attach.go Let client print error when speicify wrong detach keys 2016-04-04 15:35:55 +08:00
builder.go Remove builder dependency from the api. 2016-03-29 17:02:36 -07:00
changes.go
commit.go Remove reference package dependency from the api. 2016-04-07 15:01:23 -07:00
config.go Merge pull request #21687 from allencloud/fix-typos 2016-03-31 14:18:31 -07:00
config_experimental.go
config_stub.go
config_test.go add validating configs from configuration file 2016-03-16 00:05:52 +08:00
config_unix.go Windows: bridgeConfig rework 2016-03-28 12:24:01 -07:00
config_windows.go Windows: bridgeConfig rework 2016-03-28 12:24:01 -07:00
container_operations.go Merge pull request #21816 from estesp/case-of-the-missing-else 2016-04-07 17:01:30 -07:00
container_operations_unix.go all: remove some unused funcs and variables 2016-04-06 10:40:01 -07:00
container_operations_windows.go Merge pull request #21809 from Microsoft/jjh/tp4removal 2016-04-06 14:11:33 -07:00
create.go daemon: register container as late as possible 2016-03-29 13:52:18 -07:00
create_unix.go Merge pull request #21270 from ehazlett/resource-labels 2016-03-22 15:12:33 -04:00
create_windows.go Windows: Remove TP4 support from main code 2016-04-06 12:12:20 -07:00
daemon.go API/CLI discrepancy on hostname validation (#21595). 2016-04-08 06:13:08 +00:00
daemon_experimental.go
daemon_linux.go Fix container mount cleanup issues 2016-03-30 17:25:49 -07:00
daemon_linux_test.go Fix container mount cleanup issues 2016-03-30 17:25:49 -07:00
daemon_stub.go
daemon_test.go add label support for build, networks and volumes 2016-03-22 11:49:06 -04:00
daemon_unix.go When using systemd, pass expected cgroupsPath and cli options to runc. 2016-03-29 14:20:10 -07:00
daemon_unix_test.go Consolidate security options to use = as separator. 2016-03-17 13:34:42 -04:00
daemon_unsupported.go
daemon_windows.go Merge pull request #21872 from Microsoft/sjw/nanoserver-fix 2016-04-07 21:24:32 -07:00
debugtrap_unix.go
debugtrap_unsupported.go
debugtrap_windows.go Windows: psignal alias not required 2016-03-27 17:23:34 -07:00
delete.go Merge pull request #21802 from tiborvass/carry-21716 2016-04-06 15:21:38 -04:00
delete_test.go Remove static errors from errors package. 2016-02-26 15:49:09 -05:00
discovery.go fix typos 2016-03-11 23:22:16 +08:00
discovery_test.go
errors.go Remove static errors from errors package. 2016-02-26 15:49:09 -05:00
events.go
events_test.go
exec.go Let client print error when speicify wrong detach keys 2016-04-04 15:35:55 +08:00
exec_linux.go Replace execdrivers with containerd implementation 2016-03-18 13:38:32 -07:00
exec_windows.go Windows: escape entrypoint before passing to libcontainerd 2016-03-30 12:59:50 -07:00
export.go Remove static errors from errors package. 2016-02-26 15:49:09 -05:00
image_delete.go Remove static errors from errors package. 2016-02-26 15:49:09 -05:00
image_pull.go Remove reference package dependency from the api. 2016-04-07 15:01:23 -07:00
image_push.go Remove reference package dependency from the api. 2016-04-07 15:01:23 -07:00
image_tag.go Remove reference package dependency from the api. 2016-04-07 15:01:23 -07:00
images.go
import.go Remove reference package dependency from the api. 2016-04-07 15:01:23 -07:00
info.go Replace execdrivers with containerd implementation 2016-03-18 13:38:32 -07:00
inspect.go fix typos in several files 2016-03-18 12:51:57 +08:00
inspect_unix.go Replace execdrivers with containerd implementation 2016-03-18 13:38:32 -07:00
inspect_windows.go Windows libcontainerd implementation 2016-03-18 13:38:41 -07:00
kill.go Remove unneeded references to execDriver 2016-03-21 13:06:08 -07:00
links.go
links_test.go
list.go Add name/driver filter support for volume 2016-03-25 01:11:17 +00:00
list_unix.go
list_windows.go
logdrivers_linux.go daemon/logger: Add logging driver for Google Cloud Logging 2016-03-01 08:06:10 -08:00
logdrivers_windows.go Windows: Add ETW logging driver plug-in 2016-02-16 13:24:49 -08:00
logs.go use router.Cancellable instead of direct CloseNotify 2016-03-25 11:33:54 -07:00
monitor.go Adding postRunProcessing infrastructure for hanlding Windows Update. 2016-04-06 14:03:05 -07:00
monitor_linux.go Adding postRunProcessing infrastructure for hanlding Windows Update. 2016-04-06 14:03:05 -07:00
monitor_windows.go Adding postRunProcessing infrastructure for hanlding Windows Update. 2016-04-06 14:03:05 -07:00
mounts.go Remove static errors from errors package. 2016-02-26 15:49:09 -05:00
network.go Remove runconfig package dependency from image and container routers. 2016-03-28 16:23:51 -04:00
oci_linux.go Define readonly/mask paths in spec 2016-04-04 18:55:55 -07:00
oci_windows.go Windows: Support non-base-layered images 2016-04-07 17:52:26 -07:00
pause.go Replace execdrivers with containerd implementation 2016-03-18 13:38:32 -07:00
rename.go Remove static errors from errors package. 2016-02-26 15:49:09 -05:00
resize.go Replace execdrivers with containerd implementation 2016-03-18 13:38:32 -07:00
restart.go Remove static errors from errors package. 2016-02-26 15:49:09 -05:00
seccomp_disabled.go Replace execdrivers with containerd implementation 2016-03-18 13:38:32 -07:00
seccomp_linux.go Reuse profiles/seccomp package 2016-03-19 14:15:39 -07:00
selinux_linux.go
selinux_unsupported.go
start.go Fix container mount cleanup issues 2016-03-30 17:25:49 -07:00
stats.go use router.Cancellable instead of direct CloseNotify 2016-03-25 11:33:54 -07:00
stats_collector_unix.go daemon: log errors from stats calls 2016-03-22 14:03:47 -07:00
stats_collector_windows.go
stop.go Remove static errors from errors package. 2016-02-26 15:49:09 -05:00
top_unix.go Replace execdrivers with containerd implementation 2016-03-18 13:38:32 -07:00
top_windows.go Windows: Minimal docker top implementation 2016-03-20 16:45:53 -07:00
unpause.go Replace execdrivers with containerd implementation 2016-03-18 13:38:32 -07:00
update.go Replace execdrivers with containerd implementation 2016-03-18 13:38:32 -07:00
update_linux.go Replace execdrivers with containerd implementation 2016-03-18 13:38:32 -07:00
update_windows.go Windows libcontainerd implementation 2016-03-18 13:38:41 -07:00
volumes.go Merge pull request #21270 from ehazlett/resource-labels 2016-03-22 15:12:33 -04:00
volumes_unit_test.go
volumes_unix.go Replace execdrivers with containerd implementation 2016-03-18 13:38:32 -07:00
volumes_windows.go Remove unneeded references to execDriver 2016-03-21 13:06:08 -07:00
wait.go