mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
e5ae83e503
The VolumesService did not have information wether or not a volume was _created_ or if a volume already existed in the driver, and the existing volume was used. As a result, multiple "create" events could be generated for the same volume. For example: 1. Run `docker events` in a shell to start listening for events 2. Create a volume: docker volume create myvolume 3. Start a container that uses that volume: docker run -dit -v myvolume:/foo busybox 4. Check the events that were generated: 2021-02-15T18:49:55.874621004+01:00 volume create myvolume (driver=local) 2021-02-15T18:50:11.442759052+01:00 volume create myvolume (driver=local) 2021-02-15T18:50:11.487104176+01:00 container create 45112157c8b1382626bf5e01ef18445a4c680f3846c5e32d01775dddee8ca6d1 (image=busybox, name=gracious_hypatia) 2021-02-15T18:50:11.519288102+01:00 network connect a19f6bb8d44ff84d478670fa4e34c5bf5305f42786294d3d90e790ac74b6d3e0 (container=45112157c8b1382626bf5e01ef18445a4c680f3846c5e32d01775dddee8ca6d1, name=bridge, type=bridge) 2021-02-15T18:50:11.526407799+01:00 volume mount myvolume (container=45112157c8b1382626bf5e01ef18445a4c680f3846c5e32d01775dddee8ca6d1, destination=/foo, driver=local, propagation=, read/write=true) 2021-02-15T18:50:11.864134043+01:00 container start 45112157c8b1382626bf5e01ef18445a4c680f3846c5e32d01775dddee8ca6d1 (image=busybox, name=gracious_hypatia) 5. Notice that a "volume create" event is created twice; - once when `docker volume create` was ran - once when `docker run ...` was ran This patch moves the generation of (most) events to the volume _store_, and only generates an event if the volume did not yet exist. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
194 lines
5.7 KiB
Go
194 lines
5.7 KiB
Go
package system // import "github.com/docker/docker/integration/system"
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"errors"
|
|
"io"
|
|
"net/http"
|
|
"net/url"
|
|
"strconv"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/docker/docker/api/types"
|
|
"github.com/docker/docker/api/types/events"
|
|
"github.com/docker/docker/api/types/filters"
|
|
"github.com/docker/docker/api/types/mount"
|
|
"github.com/docker/docker/api/types/strslice"
|
|
"github.com/docker/docker/api/types/versions"
|
|
"github.com/docker/docker/api/types/volume"
|
|
"github.com/docker/docker/integration/internal/container"
|
|
"github.com/docker/docker/pkg/jsonmessage"
|
|
"github.com/docker/docker/testutil/request"
|
|
req "github.com/docker/docker/testutil/request"
|
|
"gotest.tools/v3/assert"
|
|
is "gotest.tools/v3/assert/cmp"
|
|
"gotest.tools/v3/skip"
|
|
)
|
|
|
|
func TestEventsExecDie(t *testing.T) {
|
|
skip.If(t, versions.LessThan(testEnv.DaemonAPIVersion(), "1.36"), "broken in earlier versions")
|
|
skip.If(t, testEnv.OSType == "windows", "FIXME. Suspect may need to wait until container is running before exec")
|
|
defer setupTest(t)()
|
|
ctx := context.Background()
|
|
client := testEnv.APIClient()
|
|
|
|
cID := container.Run(ctx, t, client)
|
|
|
|
id, err := client.ContainerExecCreate(ctx, cID,
|
|
types.ExecConfig{
|
|
Cmd: strslice.StrSlice([]string{"echo", "hello"}),
|
|
},
|
|
)
|
|
assert.NilError(t, err)
|
|
|
|
filters := filters.NewArgs(
|
|
filters.Arg("container", cID),
|
|
filters.Arg("event", "exec_die"),
|
|
)
|
|
msg, errors := client.Events(ctx, types.EventsOptions{
|
|
Filters: filters,
|
|
})
|
|
|
|
err = client.ContainerExecStart(ctx, id.ID,
|
|
types.ExecStartCheck{
|
|
Detach: true,
|
|
Tty: false,
|
|
},
|
|
)
|
|
assert.NilError(t, err)
|
|
|
|
select {
|
|
case m := <-msg:
|
|
assert.Equal(t, m.Type, "container")
|
|
assert.Equal(t, m.Actor.ID, cID)
|
|
assert.Equal(t, m.Action, "exec_die")
|
|
assert.Equal(t, m.Actor.Attributes["execID"], id.ID)
|
|
assert.Equal(t, m.Actor.Attributes["exitCode"], "0")
|
|
case err = <-errors:
|
|
assert.NilError(t, err)
|
|
case <-time.After(time.Second * 3):
|
|
t.Fatal("timeout hit")
|
|
}
|
|
|
|
}
|
|
|
|
// Test case for #18888: Events messages have been switched from generic
|
|
// `JSONMessage` to `events.Message` types. The switch does not break the
|
|
// backward compatibility so old `JSONMessage` could still be used.
|
|
// This test verifies that backward compatibility maintains.
|
|
func TestEventsBackwardsCompatible(t *testing.T) {
|
|
skip.If(t, testEnv.OSType == "windows", "Windows doesn't support back-compat messages")
|
|
defer setupTest(t)()
|
|
ctx := context.Background()
|
|
client := testEnv.APIClient()
|
|
|
|
since := request.DaemonTime(ctx, t, client, testEnv)
|
|
ts := strconv.FormatInt(since.Unix(), 10)
|
|
|
|
cID := container.Create(ctx, t, client)
|
|
|
|
// In case there is no events, the API should have responded immediately (not blocking),
|
|
// The test here makes sure the response time is less than 3 sec.
|
|
expectedTime := time.Now().Add(3 * time.Second)
|
|
emptyResp, emptyBody, err := req.Get("/events")
|
|
assert.NilError(t, err)
|
|
defer emptyBody.Close()
|
|
assert.Check(t, is.DeepEqual(http.StatusOK, emptyResp.StatusCode))
|
|
assert.Check(t, time.Now().Before(expectedTime), "timeout waiting for events api to respond, should have responded immediately")
|
|
|
|
// We also test to make sure the `events.Message` is compatible with `JSONMessage`
|
|
q := url.Values{}
|
|
q.Set("since", ts)
|
|
_, body, err := req.Get("/events?" + q.Encode())
|
|
assert.NilError(t, err)
|
|
defer body.Close()
|
|
|
|
dec := json.NewDecoder(body)
|
|
var containerCreateEvent *jsonmessage.JSONMessage
|
|
for {
|
|
var event jsonmessage.JSONMessage
|
|
if err := dec.Decode(&event); err != nil {
|
|
if err == io.EOF {
|
|
break
|
|
}
|
|
assert.NilError(t, err)
|
|
}
|
|
if event.Status == "create" && event.ID == cID {
|
|
containerCreateEvent = &event
|
|
break
|
|
}
|
|
}
|
|
|
|
assert.Check(t, containerCreateEvent != nil)
|
|
assert.Check(t, is.Equal("create", containerCreateEvent.Status))
|
|
assert.Check(t, is.Equal(cID, containerCreateEvent.ID))
|
|
assert.Check(t, is.Equal("busybox", containerCreateEvent.From))
|
|
}
|
|
|
|
// TestEventsVolumeCreate verifies that volume create events are only fired
|
|
// once: when creating the volume, and not when attaching to a container.
|
|
func TestEventsVolumeCreate(t *testing.T) {
|
|
skip.If(t, testEnv.OSType == "windows", "FIXME: Windows doesn't trigger the events? Could be a race")
|
|
|
|
defer setupTest(t)()
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
defer cancel()
|
|
|
|
client := testEnv.APIClient()
|
|
|
|
since := request.DaemonUnixTime(ctx, t, client, testEnv)
|
|
volName := t.Name()
|
|
getEvents := func(messages <-chan events.Message, errs <-chan error) ([]events.Message, error) {
|
|
var evts []events.Message
|
|
|
|
for {
|
|
select {
|
|
case m := <-messages:
|
|
evts = append(evts, m)
|
|
case err := <-errs:
|
|
if err == io.EOF {
|
|
return evts, nil
|
|
}
|
|
return nil, err
|
|
case <-time.After(time.Second * 3):
|
|
return nil, errors.New("timeout hit")
|
|
}
|
|
}
|
|
}
|
|
|
|
_, err := client.VolumeCreate(ctx, volume.VolumeCreateBody{Name: volName})
|
|
assert.NilError(t, err)
|
|
|
|
filter := filters.NewArgs(
|
|
filters.Arg("type", "volume"),
|
|
filters.Arg("event", "create"),
|
|
filters.Arg("volume", volName),
|
|
)
|
|
messages, errs := client.Events(ctx, types.EventsOptions{
|
|
Since: since,
|
|
Until: request.DaemonUnixTime(ctx, t, client, testEnv),
|
|
Filters: filter,
|
|
})
|
|
|
|
volEvents, err := getEvents(messages, errs)
|
|
assert.NilError(t, err)
|
|
assert.Equal(t, len(volEvents), 1, "expected volume create event when creating a volume")
|
|
|
|
container.Create(ctx, t, client, container.WithMount(mount.Mount{
|
|
Type: mount.TypeVolume,
|
|
Source: volName,
|
|
Target: "/tmp/foo",
|
|
}))
|
|
|
|
messages, errs = client.Events(ctx, types.EventsOptions{
|
|
Since: since,
|
|
Until: request.DaemonUnixTime(ctx, t, client, testEnv),
|
|
Filters: filter,
|
|
})
|
|
|
|
volEvents, err = getEvents(messages, errs)
|
|
assert.NilError(t, err)
|
|
assert.Equal(t, len(volEvents), 1, "expected volume create event to be fired only once")
|
|
}
|