mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00

I noticed that we're using a homegrown package for assertions. The functions are extremely similar to testify, but with enough slight differences to be confusing (for example, Equal takes its arguments in a different order). We already vendor testify, and it's used in a few places by tests. I also found some problems with pkg/testutil/assert. For example, the NotNil function seems to be broken. It checks the argument against "nil", which only works for an interface. If you pass in a nil map or slice, the equality check will fail. In the interest of avoiding NIH, I'm proposing replacing pkg/testutil/assert with testify. The test code looks almost the same, but we avoid the confusion of having two similar but slightly different assertion packages, and having to maintain our own package instead of using a commonly-used one. In the process, I found a few places where the tests should halt if an assertion fails, so I've made those cases (that I noticed) use "require" instead of "assert", and I've vendored the "require" package from testify alongside the already-present "assert" package. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
152 lines
4.2 KiB
Go
152 lines
4.2 KiB
Go
package volume
|
|
|
|
import (
|
|
"bytes"
|
|
"fmt"
|
|
"io/ioutil"
|
|
"testing"
|
|
|
|
"github.com/docker/docker/api/types"
|
|
"github.com/docker/docker/cli/internal/test"
|
|
"github.com/pkg/errors"
|
|
// Import builders to get the builder function as package function
|
|
. "github.com/docker/docker/cli/internal/test/builders"
|
|
"github.com/docker/docker/pkg/testutil"
|
|
"github.com/docker/docker/pkg/testutil/golden"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestVolumeInspectErrors(t *testing.T) {
|
|
testCases := []struct {
|
|
args []string
|
|
flags map[string]string
|
|
volumeInspectFunc func(volumeID string) (types.Volume, error)
|
|
expectedError string
|
|
}{
|
|
{
|
|
expectedError: "requires at least 1 argument",
|
|
},
|
|
{
|
|
args: []string{"foo"},
|
|
volumeInspectFunc: func(volumeID string) (types.Volume, error) {
|
|
return types.Volume{}, errors.Errorf("error while inspecting the volume")
|
|
},
|
|
expectedError: "error while inspecting the volume",
|
|
},
|
|
{
|
|
args: []string{"foo"},
|
|
flags: map[string]string{
|
|
"format": "{{invalid format}}",
|
|
},
|
|
expectedError: "Template parsing error",
|
|
},
|
|
{
|
|
args: []string{"foo", "bar"},
|
|
volumeInspectFunc: func(volumeID string) (types.Volume, error) {
|
|
if volumeID == "foo" {
|
|
return types.Volume{
|
|
Name: "foo",
|
|
}, nil
|
|
}
|
|
return types.Volume{}, errors.Errorf("error while inspecting the volume")
|
|
},
|
|
expectedError: "error while inspecting the volume",
|
|
},
|
|
}
|
|
for _, tc := range testCases {
|
|
buf := new(bytes.Buffer)
|
|
cmd := newInspectCommand(
|
|
test.NewFakeCli(&fakeClient{
|
|
volumeInspectFunc: tc.volumeInspectFunc,
|
|
}, buf),
|
|
)
|
|
cmd.SetArgs(tc.args)
|
|
for key, value := range tc.flags {
|
|
cmd.Flags().Set(key, value)
|
|
}
|
|
cmd.SetOutput(ioutil.Discard)
|
|
testutil.ErrorContains(t, cmd.Execute(), tc.expectedError)
|
|
}
|
|
}
|
|
|
|
func TestVolumeInspectWithoutFormat(t *testing.T) {
|
|
testCases := []struct {
|
|
name string
|
|
args []string
|
|
volumeInspectFunc func(volumeID string) (types.Volume, error)
|
|
}{
|
|
{
|
|
name: "single-volume",
|
|
args: []string{"foo"},
|
|
volumeInspectFunc: func(volumeID string) (types.Volume, error) {
|
|
if volumeID != "foo" {
|
|
return types.Volume{}, errors.Errorf("Invalid volumeID, expected %s, got %s", "foo", volumeID)
|
|
}
|
|
return *Volume(), nil
|
|
},
|
|
},
|
|
{
|
|
name: "multiple-volume-with-labels",
|
|
args: []string{"foo", "bar"},
|
|
volumeInspectFunc: func(volumeID string) (types.Volume, error) {
|
|
return *Volume(VolumeName(volumeID), VolumeLabels(map[string]string{
|
|
"foo": "bar",
|
|
})), nil
|
|
},
|
|
},
|
|
}
|
|
for _, tc := range testCases {
|
|
buf := new(bytes.Buffer)
|
|
cmd := newInspectCommand(
|
|
test.NewFakeCli(&fakeClient{
|
|
volumeInspectFunc: tc.volumeInspectFunc,
|
|
}, buf),
|
|
)
|
|
cmd.SetArgs(tc.args)
|
|
assert.NoError(t, cmd.Execute())
|
|
actual := buf.String()
|
|
expected := golden.Get(t, []byte(actual), fmt.Sprintf("volume-inspect-without-format.%s.golden", tc.name))
|
|
testutil.EqualNormalizedString(t, testutil.RemoveSpace, actual, string(expected))
|
|
}
|
|
}
|
|
|
|
func TestVolumeInspectWithFormat(t *testing.T) {
|
|
volumeInspectFunc := func(volumeID string) (types.Volume, error) {
|
|
return *Volume(VolumeLabels(map[string]string{
|
|
"foo": "bar",
|
|
})), nil
|
|
}
|
|
testCases := []struct {
|
|
name string
|
|
format string
|
|
args []string
|
|
volumeInspectFunc func(volumeID string) (types.Volume, error)
|
|
}{
|
|
{
|
|
name: "simple-template",
|
|
format: "{{.Name}}",
|
|
args: []string{"foo"},
|
|
volumeInspectFunc: volumeInspectFunc,
|
|
},
|
|
{
|
|
name: "json-template",
|
|
format: "{{json .Labels}}",
|
|
args: []string{"foo"},
|
|
volumeInspectFunc: volumeInspectFunc,
|
|
},
|
|
}
|
|
for _, tc := range testCases {
|
|
buf := new(bytes.Buffer)
|
|
cmd := newInspectCommand(
|
|
test.NewFakeCli(&fakeClient{
|
|
volumeInspectFunc: tc.volumeInspectFunc,
|
|
}, buf),
|
|
)
|
|
cmd.SetArgs(tc.args)
|
|
cmd.Flags().Set("format", tc.format)
|
|
assert.NoError(t, cmd.Execute())
|
|
actual := buf.String()
|
|
expected := golden.Get(t, []byte(actual), fmt.Sprintf("volume-inspect-with-format.%s.golden", tc.name))
|
|
testutil.EqualNormalizedString(t, testutil.RemoveSpace, actual, string(expected))
|
|
}
|
|
}
|