1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
moby--moby/builder
Doug Davis cdb8ea90b0 Fix processing of unset build-args during build
This reverts 26103.  26103 was trying to make it so that if someone did:
  docker build --build-arg FOO .
and FOO wasn't set as an env var then it would pick-up FOO from the
Dockerfile's ARG cmd.  However, it went too far and removed the ability
to specify a build arg w/o any value. Meaning it required the --build-arg
param to always be in the form "name=value", and not just "name".

This PR does the right fix - it allows just "name" and it'll grab the value
from the env vars if set. If "name" isn't set in the env then it still needs
to send "name" to the server so that a warning can be printed about an
unused --build-arg. And this is why buildArgs in the options is now a
*string instead of just a string - 'nil' == mentioned but no value.

Closes #29084

Signed-off-by: Doug Davis <dug@us.ibm.com>
2016-12-07 07:41:55 -08:00
..
dockerfile Fix processing of unset build-args during build 2016-12-07 07:41:55 -08:00
dockerignore add defer file.Close to avoid potential fd leak 2016-08-10 08:36:09 +08:00
builder.go Merge pull request #28988 from vdemeester/28985-dont-validate-hostname 2016-12-02 21:16:56 -05:00
context.go Fix directory walker error checking 2016-05-26 14:59:38 -07:00
context_test.go Builder unit tests refactoring 2016-05-03 19:00:35 +02:00
context_unix.go Move validateContextDirectory to builder package. 2016-02-09 22:19:09 +01:00
context_windows.go Move validateContextDirectory to builder package. 2016-02-09 22:19:09 +01:00
dockerignore.go add defer file.Close to avoid potential fd leak 2016-08-10 08:36:09 +08:00
dockerignore_test.go Builder unit tests refactoring 2016-05-03 19:00:35 +02:00
git.go utils: move git functions to pkg/gitutils 2015-12-14 14:59:52 +01:00
remote.go pkg/archive: remove unnecessary Archive and Reader type 2016-10-20 19:31:24 -07:00
remote_test.go pkg/archive: remove unnecessary Archive and Reader type 2016-10-20 19:31:24 -07:00
tarsum.go Windows: Fix builder cache bug 2016-10-27 12:27:30 -07:00
tarsum_test.go fix using wrong function name for MakeTarSumContext 2016-11-08 17:16:13 +08:00
utils_test.go Builder unit tests refactoring 2016-05-03 19:00:35 +02:00