mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
609d87003a
1. Commit1a22418f9fchanged permissions to `0700` on Windows, or more factually, it removed `rw` (`chmod g-rw,o-rw`) and added executable bits (`chmod u+x`). 2. This was too restrictive, andb7dc9040f0changed permissions to only remove the group- and world-writable bits to give read and execute access to everyone, but setting execute permissions for everyone. 3. However, this also removed the non-permission bits, so41eb61d5c2updated the code to preserve those, and keep parity with Linux. This changes it back to `2.`. I wonder (_think_) _permission_ bits (read, write) can be portable, except for the _executable_ bit (which is not present on Windows). The alternative could be to keep the permission bits, and only set the executable bit (`perm | 0111`) for everyone (equivalent of `chmod +x`), but that likely would be a breaking change. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
84 lines
1.9 KiB
Go
84 lines
1.9 KiB
Go
//go:build windows
|
|
// +build windows
|
|
|
|
package archive // import "github.com/docker/docker/pkg/archive"
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
)
|
|
|
|
func TestCopyFileWithInvalidDest(t *testing.T) {
|
|
// TODO Windows: This is currently failing. Not sure what has
|
|
// recently changed in CopyWithTar as used to pass. Further investigation
|
|
// is required.
|
|
t.Skip("Currently fails")
|
|
folder, err := os.MkdirTemp("", "docker-archive-test")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer os.RemoveAll(folder)
|
|
dest := "c:dest"
|
|
srcFolder := filepath.Join(folder, "src")
|
|
src := filepath.Join(folder, "src", "src")
|
|
err = os.MkdirAll(srcFolder, 0740)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
os.WriteFile(src, []byte("content"), 0777)
|
|
err = defaultCopyWithTar(src, dest)
|
|
if err == nil {
|
|
t.Fatalf("archiver.CopyWithTar should throw an error on invalid dest.")
|
|
}
|
|
}
|
|
|
|
func TestCanonicalTarNameForPath(t *testing.T) {
|
|
cases := []struct {
|
|
in, expected string
|
|
}{
|
|
{"foo", "foo"},
|
|
{"foo/bar", "foo/bar"},
|
|
{`foo\bar`, "foo/bar"},
|
|
}
|
|
for _, v := range cases {
|
|
if CanonicalTarNameForPath(v.in) != v.expected {
|
|
t.Fatalf("wrong canonical tar name. expected:%s got:%s", v.expected, CanonicalTarNameForPath(v.in))
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestCanonicalTarName(t *testing.T) {
|
|
cases := []struct {
|
|
in string
|
|
isDir bool
|
|
expected string
|
|
}{
|
|
{"foo", false, "foo"},
|
|
{"foo", true, "foo/"},
|
|
{`foo\bar`, false, "foo/bar"},
|
|
{`foo\bar`, true, "foo/bar/"},
|
|
}
|
|
for _, v := range cases {
|
|
if canonicalTarName(v.in, v.isDir) != v.expected {
|
|
t.Fatalf("wrong canonical tar name. expected:%s got:%s", v.expected, canonicalTarName(v.in, v.isDir))
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestChmodTarEntry(t *testing.T) {
|
|
cases := []struct {
|
|
in, expected os.FileMode
|
|
}{
|
|
{0000, 0111},
|
|
{0777, 0755},
|
|
{0644, 0755},
|
|
{0755, 0755},
|
|
{0444, 0555},
|
|
}
|
|
for _, v := range cases {
|
|
if out := chmodTarEntry(v.in); out != v.expected {
|
|
t.Fatalf("wrong chmod. expected:%v got:%v", v.expected, out)
|
|
}
|
|
}
|
|
}
|