mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
a8608b5b67
About github.com/opencontainers/runc/libcontainer/user:
According to 195d8d544a
this package has two functions:
- Have a static implementation of user lookup, which is now supported in the
os/user stdlib package with the osusergo build tag, but wasn't at the time.
- Have extra functions that os/user doesn't have, but none of those are used
in homedir.
Since https://github.com/moby/moby/pull/11287, homedir depended directly on
libcontainer's user package for CurrentUser().
This is being replaced with os/user.Current(), because all of our static
binaries are compiled with the osusergo tag, and for dynamic libraries it
is more correct to use libc's implementation than parsing /etc/passwd.
About github.com/docker/docker/pkg/idtools:
Only dependency was from GetStatic() which uses idtools.LookupUID(uid).
The implementation of idtools.LookupUID just calls to
github.com/opencontainers/runc/libcontainer/user.LookupUid or fallbacks
to exec-ing to getent (since https://github.com/moby/moby/pull/27599).
This patch replaces calls to homedir.GetStatic by homedir.Get(), opting out
of supporting nss lookups in static binaries via exec-ing to getent for
the homedir package.
If homedir package users need to support nss lookups, they are advised
to compile dynamically instead.
Signed-off-by: Tibor Vass <tibor@docker.com>
35 lines
915 B
Go
35 lines
915 B
Go
// +build !windows
|
|
|
|
package homedir // import "github.com/docker/docker/pkg/homedir"
|
|
|
|
import (
|
|
"os"
|
|
"os/user"
|
|
)
|
|
|
|
// Key returns the env var name for the user's home dir based on
|
|
// the platform being run on
|
|
func Key() string {
|
|
return "HOME"
|
|
}
|
|
|
|
// Get returns the home directory of the current user with the help of
|
|
// environment variables depending on the target operating system.
|
|
// Returned path should be used with "path/filepath" to form new paths.
|
|
// If compiling statically, ensure the osusergo build tag is used.
|
|
// If needing to do nss lookups, do not compile statically.
|
|
func Get() string {
|
|
home := os.Getenv(Key())
|
|
if home == "" {
|
|
if u, err := user.Current(); err == nil {
|
|
return u.HomeDir
|
|
}
|
|
}
|
|
return home
|
|
}
|
|
|
|
// GetShortcutString returns the string that is shortcut to user's home directory
|
|
// in the native shell of the platform running on.
|
|
func GetShortcutString() string {
|
|
return "~"
|
|
}
|